From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 845C8A0032; Wed, 11 May 2022 09:35:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 67209410F2; Wed, 11 May 2022 09:35:42 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id AE13C40042 for ; Wed, 11 May 2022 09:35:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652254540; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mfW7gcfkJHzgFYJLM4Nmz+x1ZPPA3+rmDaFQDrlnk5Q=; b=b4vxwRdYFd/vRKkBERA+LdNjWn5U7AOKrH9PllFM7WVaIFjw4RW4EnB/qhvFSVH6MjGItQ Zzy5g1YdcAjlhwiPE03JMgqje9R9FjVSd8N9oHQ7NaGDbRovrNBmaBNXKtpNo1WM26hR1T d79CK8Kv8/OC2mf5b0vR25V/swtm5fE= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-107-2Lv-lmwEON6NYJ6doSkJkQ-1; Wed, 11 May 2022 03:35:38 -0400 X-MC-Unique: 2Lv-lmwEON6NYJ6doSkJkQ-1 Received: by mail-lj1-f197.google.com with SMTP id l13-20020a2e868d000000b0024f078d7ea0so418273lji.4 for ; Wed, 11 May 2022 00:35:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mfW7gcfkJHzgFYJLM4Nmz+x1ZPPA3+rmDaFQDrlnk5Q=; b=aODmwmWgTmRAHGC6Q06X/2lhIv+n3ANLdd2Zt+8Q/Aq25Jo4zLCAjjIiR6JaGMdE7C m6f5RO5qolGqCHt/2spNz6AqZHxZMTvJUfS1+o13zo89yMnVXBXRS8PfMj623ASLAAxQ tQhWiRa97CVn4jNvdCNEILTGgYE5+s/Woum1RIRndLhfsohsv6vXVzHtPc9eaM6ZEdsY R6bKxxsbbH7cZ+fCodg6VO4KlwPa3825QFeUV6Yp9a2hkI/xcX3KB/MtP5S/3uKEngir NXgYew/uDJu/Q/SRcSi/+xc3HHmlCR2Mi7675xpFB7bAY4NaWTk00nt+4xueMdXjGVeZ Y9yw== X-Gm-Message-State: AOAM532TkuKORMY5q8NMY924bGwpBgQs2+FdSAZ0lLQDbGszZgb73R/R zO6S787SwhOLXM3tMlP7X3hdw8NyFBCBDXWYBb1YtXawKelJxiG8/77d8ICrW2YmEAg3ANDarlf UmjZD6BeVCGzzWNl7o4g= X-Received: by 2002:a05:6512:3d28:b0:472:6386:9eab with SMTP id d40-20020a0565123d2800b0047263869eabmr19537879lfv.484.1652254537071; Wed, 11 May 2022 00:35:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx0hVdU5S5QxBgJ+izERsrG63jYXad1SykvxNOFG4QxtHvHVHBcGwkUhE62iLoxu+wgkuSbng8/syjRRrHNnj8= X-Received: by 2002:a05:6512:3d28:b0:472:6386:9eab with SMTP id d40-20020a0565123d2800b0047263869eabmr19537868lfv.484.1652254536885; Wed, 11 May 2022 00:35:36 -0700 (PDT) MIME-Version: 1.0 References: <20220511065837.1267895-1-maxime.coquelin@redhat.com> In-Reply-To: <20220511065837.1267895-1-maxime.coquelin@redhat.com> From: David Marchand Date: Wed, 11 May 2022 09:35:25 +0200 Message-ID: Subject: Re: [PATCH v2] vhost: add runtime locking check in unsafe APIs To: Maxime Coquelin Cc: dev , "Xia, Chenbo" , Xuan Ding , Jiayu Hu , Cheng Jiang , Sunil Pai G Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, May 11, 2022 at 8:58 AM Maxime Coquelin wrote: > > This patch adds runtime checks in unsafe Vhost async APIs, > to ensure the access lock is taken. > > The detection won't work every time, as another thread > could take the lock, but it would help to detect misuse > of these unsafe API. > > Signed-off-by: Maxime Coquelin Reviewed-by: David Marchand -- David Marchand