From: David Marchand <david.marchand@redhat.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3] eal/mem: preallocate VA space in no-huge mode
Date: Fri, 27 Mar 2020 07:33:40 +0100 [thread overview]
Message-ID: <CAJFAV8zSpsROwdm2nKcMi19XTo8bML3iWHxihP-R-ki9_MDDBg@mail.gmail.com> (raw)
In-Reply-To: <bd6ed5db-d234-cf49-d104-3ee20ba75971@intel.com>
On Thu, Mar 26, 2020 at 6:07 PM Burakov, Anatoly
<anatoly.burakov@intel.com> wrote:
>
> On 25-Mar-20 2:39 PM, David Marchand wrote:
> > On Fri, Feb 7, 2020 at 12:11 PM Anatoly Burakov
> > <anatoly.burakov@intel.com> wrote:
> >>
> >> When --no-huge mode is used, the memory is currently allocated with
> >> mmap(NULL, ...). This is fine in most cases, but can fail in cases
> >> where DPDK is run on a machine with an IOMMU that is of more limited
> >> address width than that of a VA, because we're not specifying the
> >> address hint for mmap() call.
> >>
> >> Fix it by preallocating VA space before mapping it.
> >>
> >> Cc: stable@dpdk.org
> >>
> >> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> >
> > Reproduced issue reported by Thomas on v2.
> > Works fine with v3.
> >
> > Tested-by: David Marchand <david.marchand@redhat.com>
> >
> >
> > Does this issue affect FreeBSD too?
> >
>
> I don't think we have support for IOMMU on FreeBSD so my guess is no :)
Fair enough, I will take it today.
Thanks.
--
David Marchand
next prev parent reply other threads:[~2020-03-27 6:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 17:01 [dpdk-dev] [PATCH] " Anatoly Burakov
2020-01-24 17:05 ` [dpdk-dev] [PATCH v2] " Anatoly Burakov
2020-02-06 15:39 ` Thomas Monjalon
2020-02-06 21:07 ` Thomas Monjalon
2020-02-07 11:11 ` [dpdk-dev] [PATCH v3] " Anatoly Burakov
2020-03-25 14:39 ` [dpdk-dev] [dpdk-stable] " David Marchand
2020-03-26 17:06 ` Burakov, Anatoly
2020-03-27 6:33 ` David Marchand [this message]
[not found] ` <6473a4fe45d8437285fd8a1e931a1cb8@intel.com>
2020-03-27 2:23 ` Zhou, JunX W
2020-03-27 10:16 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8zSpsROwdm2nKcMi19XTo8bML3iWHxihP-R-ki9_MDDBg@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).