From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA0CF433B5; Fri, 24 Nov 2023 09:12:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2578543267; Fri, 24 Nov 2023 09:12:07 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id DCAD0402B3 for ; Fri, 24 Nov 2023 09:12:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700813521; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ctXwcohN1cIa9wSRH+d3jJMadCSll8eT9/I2yv2qTe8=; b=WuV8AFD2ZNAaVoVqbpnmMybGdjh8gxgWmUFLlgRCAQiFf1/yfA6y/eSRARaFviVpyvsgc+ 4RSfga1/XQ/j1JXqnRKH3sPZNnE6dSxoXyzCxYDlcFGtlzLFtlhwbsJER8BwWTMBy8Hep4 8p2KO2URVTx1SsHQH7l+xcaseFmFpO8= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-408-wBTHy_OtMKG1pVdHvG0DmQ-1; Fri, 24 Nov 2023 03:12:00 -0500 X-MC-Unique: wBTHy_OtMKG1pVdHvG0DmQ-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2c883c7380fso14209611fa.2 for ; Fri, 24 Nov 2023 00:11:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700813518; x=1701418318; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ctXwcohN1cIa9wSRH+d3jJMadCSll8eT9/I2yv2qTe8=; b=VbM/h6Jh50i0ZqkdN5z2lzgKdLgS0mw3gQ/vDwP0dgGNJkDU37ozHPq24lMaZwFq19 ccJsKvihAAKRYNJ80jzwKuuOB8Q6xIF+N60lpI8EdETUMjoAUfMNy7zB76H73aq5woaI kp64SfqwGxBW/kwFG9NDuquRGHbQFTUUTwIKOxuXadV05gBeeLIvO/G8QeaAOnLnS7+I HsvsQ7PgONJ8yF1NFCt3vV2eBpUWztHUArrBZdxHJHpZ7rB0yQbBRE6Dp2Y/XBFUYlWb 91T5b5//C2C1L+wowBxy2S7Yyfz8mNaQ0Au+ytKygFAXP+SrV7Z7u3udBpnMQxOgKZt1 Tldw== X-Gm-Message-State: AOJu0Yx6vff7LU8KhGoI5eutmHvnbVIb7kVV8yWJWW3phVUrOuvhQ4n3 rl8yTBxb+/0strrokyNdAQFwANAtR2kwIIMgXHvFcQBN3pqjJeymNwfj/DfbO6uvHtwzMgR08FX HMxqrYKjDOSt2FABpe/w= X-Received: by 2002:a2e:b170:0:b0:2c8:3888:bbb2 with SMTP id a16-20020a2eb170000000b002c83888bbb2mr1138586ljm.38.1700813518646; Fri, 24 Nov 2023 00:11:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IGDFr4nPWbtGZgCNFIGerfKFRkZkDNvgzhDM7QuBiOBMZSUJYfM+gbNK15SZFNxl09yIT3TYwRUoXwUICM2jUo= X-Received: by 2002:a2e:b170:0:b0:2c8:3888:bbb2 with SMTP id a16-20020a2eb170000000b002c83888bbb2mr1138552ljm.38.1700813518325; Fri, 24 Nov 2023 00:11:58 -0800 (PST) MIME-Version: 1.0 References: <20231123114405.2611371-1-david.marchand@redhat.com> <20231123114405.2611371-4-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Fri, 24 Nov 2023 09:11:46 +0100 Message-ID: Subject: Re: [PATCH 3/5] doc: fix some ordered lists To: Dariusz Sosnowski Cc: "dev@dpdk.org" , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , "stable@dpdk.org" , Slava Ovsiienko , Ori Kam , Suanming Mou , Matan Azrad , Maxime Coquelin , Chenbo Xia , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Jiayu Hu , Michael Baum , Jianfeng Tan , Yuanhan Liu , Tiwei Bie , Yinan Wang , Jerin Jacob , Mark Kavanagh , Konstantin Ananyev , John McNamara X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Nov 23, 2023 at 6:22=E2=80=AFPM Dariusz Sosnowski wrote: > > Hi, > > > diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index > > 45379960f0..39a8c5d7b4 100644 > > --- a/doc/guides/nics/mlx5.rst > > +++ b/doc/guides/nics/mlx5.rst > > @@ -2326,19 +2326,18 @@ This command performs: > > > > #. Call the regular ``port attach`` function with updated identifier. > > > > -For example, to attach a port whose PCI address is ``0000:0a:00.0`` -a= nd its > > socket path is ``/var/run/import_ipc_socket``: > > + For example, to attach a port whose PCI address is ``0000:0a:00.0`` > > + and its socket path is ``/var/run/import_ipc_socket``: > > > > -.. code-block:: console > > - > > - testpmd> mlx5 port attach 0000:0a:00.0 > > socket=3D/var/run/import_ipc_socket > > - testpmd: MLX5 socket path is /var/run/import_ipc_socket > > - testpmd: Attach port with extra devargs > > 0000:0a:00.0,cmd_fd=3D40,pd_handle=3D1 > > - Attaching a new port... > > - EAL: Probe PCI driver: mlx5_pci (15b3:101d) device: 0000:0a:00.0 (s= ocket > > 0) > > - Port 0 is attached. Now total ports is 1 > > - Done > > + .. code-block:: console > > > > + testpmd> mlx5 port attach 0000:0a:00.0 > > socket=3D/var/run/import_ipc_socket > > + testpmd: MLX5 socket path is /var/run/import_ipc_socket > > + testpmd: Attach port with extra devargs > > 0000:0a:00.0,cmd_fd=3D40,pd_handle=3D1 > > + Attaching a new port... > > + EAL: Probe PCI driver: mlx5_pci (15b3:101d) device: 0000:0a:00.0= (socket > > 0) > > + Port 0 is attached. Now total ports is 1 > > + Done > > > > port map external Rx queue > > ~~~~~~~~~~~~~~~~~~~~~~~~~~ > The preceding list explains what "mlx5 port attach" command does and the = following section provides an example of usage. > I don't think this section should be a part of that list. Re-reading this section, I agree. I will drop this hunk. Thanks Dariusz. --=20 David Marchand