From: David Marchand <david.marchand@redhat.com>
To: "Doherty, Declan" <declan.doherty@intel.com>
Cc: Adam Dybkowski <adamx.dybkowski@intel.com>, dev <dev@dpdk.org>,
"Trahe, Fiona" <fiona.trahe@intel.com>,
Akhil Goyal <akhil.goyal@nxp.com>,
Arek Kusztal <arkadiuszx.kusztal@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
Ray Kinsella <mdr@ashroe.eu>
Subject: Re: [dpdk-dev] [PATCH] cryptodev: revert ABI compatibility for ChaCha20-Poly1305
Date: Wed, 7 Oct 2020 14:06:51 +0200 [thread overview]
Message-ID: <CAJFAV8zT41LZ=0CyKaL09RibW3SBE6ox4+o3u+bVG_mJmOLrjw@mail.gmail.com> (raw)
In-Reply-To: <f294de5c-7c38-fdbc-c899-f7f0f561cd96@intel.com>
On Wed, Oct 7, 2020 at 12:41 PM Doherty, Declan
<declan.doherty@intel.com> wrote:
> >> @@ -789,33 +781,9 @@ rte_cryptodev_stats_reset(uint8_t dev_id);
> >> * the last valid element has it's op field set to
> >> * RTE_CRYPTO_OP_TYPE_UNDEFINED.
> >> */
> >> -
> >> -void
> >> +extern void
> > Nit: no need for extern.
> Hey David, I think the cryptodev API consistently uses extern on nearly
> all it's function declarations. I'd proposed we do a separate patchset
> which removes extern on all function declarations to make it more
> consistent with the rest of DPDKs libraries.
Ok for me.
--
David Marchand
next prev parent reply other threads:[~2020-10-07 12:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 9:59 Adam Dybkowski
2020-08-25 8:18 ` Kusztal, ArkadiuszX
2020-10-06 12:32 ` David Marchand
2020-10-06 14:27 ` Dybkowski, AdamX
2020-10-07 10:41 ` Doherty, Declan
2020-10-07 12:06 ` David Marchand [this message]
2020-10-08 8:32 ` [dpdk-dev] [PATCH v2 0/1] cryptodev: remove v20 ABI compatibility Adam Dybkowski
2020-10-08 8:32 ` [dpdk-dev] [PATCH v2 1/1] " Adam Dybkowski
2020-10-09 17:41 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8zT41LZ=0CyKaL09RibW3SBE6ox4+o3u+bVG_mJmOLrjw@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=adamx.dybkowski@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=mdr@ashroe.eu \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).