From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6465AA04BA; Wed, 7 Oct 2020 14:07:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3D0F91B9EE; Wed, 7 Oct 2020 14:07:09 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 6DC061B9E0 for ; Wed, 7 Oct 2020 14:07:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602072424; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mvYPWFALciybRMbVpILuWY2U3UTRL/GCtvBNkoUsl/4=; b=J9MYYLKqLGV896jiXOS/ssetX4UpzRR1wK3lJHW04cutkBne+gUmenHQA6S7a0DEk6DCG/ vuaxDRbcJUmt0SvPK104Kd16QaEU4oRYF8cjOgui46pNRI0RxsAcoTP8jE2/lTxi4W1RzY 0mtgcn4McyqF9V0mTgvRNcDl5eISLYs= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-45-Va7Z8ymyOj67vYt3P08LGg-1; Wed, 07 Oct 2020 08:07:03 -0400 X-MC-Unique: Va7Z8ymyOj67vYt3P08LGg-1 Received: by mail-ua1-f70.google.com with SMTP id e2so553517uaj.8 for ; Wed, 07 Oct 2020 05:07:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mvYPWFALciybRMbVpILuWY2U3UTRL/GCtvBNkoUsl/4=; b=eJbpysYHvbSLZzbEwAwGQGIIPm4/9p7B/zVdbgbi9kB8jn8h3VRoGVTpBbgSoecX3T +06yFvPK28lQ8jEwU4x33OgNXnJBtnvhCWy7wXudU+Az2d4IeZiWS5gBWpg8sr2kW4qk I95DWIJUbHIOfywpcm7nDUKwJz02p3D81fJydRAuxqc32e5s+tooLANM3BaVrINMzM9g K1MZDe5iHZNiLiGRhohyktVuPUP4OPUqpEclsVZDbgksxeZTR38TiLiDa7InTJdzM2eB wwAof53tpmdiJ24WumWeMsEpmsD76ya5SfxY4WmL3HBVTUrhkF6olfCBbRrHbrTBIIQ5 uPuw== X-Gm-Message-State: AOAM533jg0E+OS0ZJDpnzwtsFgm3PHEmGJ42Hdwwr+tRXGZGPZINwFa0 S4eS+AjSABqhYZf1/25ff8HKM0gxw6cfm2OQ1Wif5JpWFB+0yTssWUKbov3+txN/29hzvPT2Cte MzhGYmweax9xIGmZNTho= X-Received: by 2002:a1f:a290:: with SMTP id l138mr1396374vke.9.1602072422530; Wed, 07 Oct 2020 05:07:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy9/KwKc1i6c9M4q7KKRSqE6eZ1XPxRViyFcp1urwEPS3FqM8xBgwVmkBwiuvaXikR7ZQ1dAYvp3exmsxa1Kac= X-Received: by 2002:a1f:a290:: with SMTP id l138mr1396342vke.9.1602072422165; Wed, 07 Oct 2020 05:07:02 -0700 (PDT) MIME-Version: 1.0 References: <20200814095942.1726-1-adamx.dybkowski@intel.com> In-Reply-To: From: David Marchand Date: Wed, 7 Oct 2020 14:06:51 +0200 Message-ID: To: "Doherty, Declan" Cc: Adam Dybkowski , dev , "Trahe, Fiona" , Akhil Goyal , Arek Kusztal , Thomas Monjalon , Ray Kinsella Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] cryptodev: revert ABI compatibility for ChaCha20-Poly1305 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 7, 2020 at 12:41 PM Doherty, Declan wrote: > >> @@ -789,33 +781,9 @@ rte_cryptodev_stats_reset(uint8_t dev_id); > >> * the last valid element has it's op field set to > >> * RTE_CRYPTO_OP_TYPE_UNDEFINED. > >> */ > >> - > >> -void > >> +extern void > > Nit: no need for extern. > Hey David, I think the cryptodev API consistently uses extern on nearly > all it's function declarations. I'd proposed we do a separate patchset > which removes extern on all function declarations to make it more > consistent with the rest of DPDKs libraries. Ok for me. -- David Marchand