Re: [PATCH v2 0/2] net/virtio: vhost-vdpa fixes

[David Marchand <david.marchand@redhat.com>]

On Wed, Mar 13, 2024 at 1:59 PM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
>
> While investigating vhost-vdpa initialization issue with mlx5
> vDPA, we found two issues fixed by following patches.
>
> In this v2, the control queue issue mentioned in v1 is
> fixed. It turned out to the control queue being enabled
> only if multiqueue was negotiated. It is fixed by enabling
> it at device startup, and disabling it at stop time.
>
> We still have an issue on one of our setup with mlx5, where
> the mlx5 device sets VIRTIO_CONFIG_S_FAILED status, it is
> currently being investigated.

v2 is working fine on my system, what else matters? :-)

The current fixes in this series make sense.
We may do followup fixes in the next release.


>
> Changes in v2:
> --------------
> - Fix cvq enablement
> - Fix typo in commit message (David)
>
>
> Maxime Coquelin (2):
>   net/virtio: fix vDPA device init advertising control queue
>   net/virtio: fix notification area initialization
>
>  .../net/virtio/virtio_user/virtio_user_dev.c  | 27 +++++++++++++------
>  1 file changed, 19 insertions(+), 8 deletions(-)
>

Series applied, thanks.


-- 
David Marchand