From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 481DD43CA0; Wed, 13 Mar 2024 15:49:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BDD04406BC; Wed, 13 Mar 2024 15:49:06 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id C6919402B8 for ; Wed, 13 Mar 2024 15:49:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710341345; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YvG/LRXwS/gCvG2UBGXTwbHnyKOcMWhxg3a413swOU4=; b=Qsj5GL98XYEkVyebW2Oc4K+4ODoiXTGX5WfCEnVuZBDvHNYeMd0VTOCqQWfJz5U5X82OEE SftGFS3Kcj7K2YKJgjbnz7qK/iGMgdPndKCUHvr6j3sLa8T5UJeEjHRGBxEwZWu1w0wBOE E2omWHKI6zF1UBGxPnahDe6sV+OYH8k= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-678-TmG_Yia1OiS_cWOlDRJytA-1; Wed, 13 Mar 2024 10:49:03 -0400 X-MC-Unique: TmG_Yia1OiS_cWOlDRJytA-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-50e91f9d422so7947531e87.2 for ; Wed, 13 Mar 2024 07:49:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710341342; x=1710946142; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YvG/LRXwS/gCvG2UBGXTwbHnyKOcMWhxg3a413swOU4=; b=szGgxs43h6X3l+YSFGMrLuq3iqhLFCHIaY06OYEMzEDIAl4njPWXBbyvrhmW6oij9q QnbumivmAfbD7X+8aWzsc6yYotMb3QO9B2V5acr1MdafS8IEYXWRZBbXUL+qTdNMA+GT QbPvQNLAQVgoUsmhq+DerEEJEFvTB4CjE6cegx3xO/1RZnJLQE3KMSUnXhNRsGGSvlfj U2slLsUNDUIzkz7m4pUaBGQafbI0/Ek7ZyOhHflpPi6lTKZd81SA/v6a5CgGHsDgOaEo 0Kke82O5PIXax+dPjG+wNy6eOauaktA2hN2KnOn391HXpsTmjOnpE4I10uvc42EO8uGu FN6A== X-Gm-Message-State: AOJu0Yyg5BLSlGPsZmQW3CPUNZxTdprCiNZDY7czp1IeqB7C8QvzZlXB Igd0HIzhnPWbzXC+Z1yfU/p5BaGc9zoFtlX8zEGygTnVxEBaRgim9cT8VtIhXOlz0Qxly0IbM2H mzXhgmLCUMCtc8VYDgETW4UKGzaGt/Gs6Dl4Q+WKHsWaRblndpoyCQwRAoDuWuCoKgj6eLy6yZm QWwDmwSo7B174E6vQ= X-Received: by 2002:ac2:4db5:0:b0:513:c227:70bd with SMTP id h21-20020ac24db5000000b00513c22770bdmr3255699lfe.60.1710341341969; Wed, 13 Mar 2024 07:49:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFh2ezD/B4tK8h5Dk4gIYHS9UgTkhpPhksVd2yOm0GVxMYRt2qDHQzjVaMz7UEHzGkAEj0f+GIaKNlN5Rv/mYs= X-Received: by 2002:ac2:4db5:0:b0:513:c227:70bd with SMTP id h21-20020ac24db5000000b00513c22770bdmr3255687lfe.60.1710341341649; Wed, 13 Mar 2024 07:49:01 -0700 (PDT) MIME-Version: 1.0 References: <20240313125932.1878279-1-maxime.coquelin@redhat.com> In-Reply-To: <20240313125932.1878279-1-maxime.coquelin@redhat.com> From: David Marchand Date: Wed, 13 Mar 2024 15:48:50 +0100 Message-ID: Subject: Re: [PATCH v2 0/2] net/virtio: vhost-vdpa fixes To: Maxime Coquelin Cc: dev@dpdk.org, chenbox@nvidia.com, schalla@marvell.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Mar 13, 2024 at 1:59=E2=80=AFPM Maxime Coquelin wrote: > > While investigating vhost-vdpa initialization issue with mlx5 > vDPA, we found two issues fixed by following patches. > > In this v2, the control queue issue mentioned in v1 is > fixed. It turned out to the control queue being enabled > only if multiqueue was negotiated. It is fixed by enabling > it at device startup, and disabling it at stop time. > > We still have an issue on one of our setup with mlx5, where > the mlx5 device sets VIRTIO_CONFIG_S_FAILED status, it is > currently being investigated. v2 is working fine on my system, what else matters? :-) The current fixes in this series make sense. We may do followup fixes in the next release. > > Changes in v2: > -------------- > - Fix cvq enablement > - Fix typo in commit message (David) > > > Maxime Coquelin (2): > net/virtio: fix vDPA device init advertising control queue > net/virtio: fix notification area initialization > > .../net/virtio/virtio_user/virtio_user_dev.c | 27 +++++++++++++------ > 1 file changed, 19 insertions(+), 8 deletions(-) > Series applied, thanks. --=20 David Marchand