From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4003DA0350; Sun, 24 Nov 2019 21:18:34 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CD6822C6A; Sun, 24 Nov 2019 21:18:32 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 979232952 for ; Sun, 24 Nov 2019 21:18:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574626710; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2CodQ3hY/G6S+Jq21I2jJ2QM9rjg24EjvaAyKj9QCGQ=; b=Tq7BLvtLbuxWehH81tPdrqNx0HUUej7FXrQPgj0kR8BuHJ9ms5ZueNGZE7T4M116yFI+X+ r54JT6DotJPLNxycySk7eRq/JG1/claH+avyDDYXI66YYrcgVzPGA4GWfZq9YzWttt/ul7 cA6CCyB0KT4MepSUb389fXc/NUn/GGY= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-244-78Ck8E_3PmGLhbxdldnYaA-1; Sun, 24 Nov 2019 15:18:26 -0500 Received: by mail-vk1-f199.google.com with SMTP id s1so6346019vkm.11 for ; Sun, 24 Nov 2019 12:18:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oPWLrZZmomrMyeC73LYbMhDY3S3zcjIKrWyxdMHgNu8=; b=KSF8pn7sQwPZOQxj0VGT4+zT898ysesjxewkicW/lxeU0llyyv/WtLqZMM4TkoNtrX zQfUG7RApDdPSSnPIZQrvCd1RhYc5r7tsnd03eEadkQZWCnqHzf1BSGQwZr4P7UE6hb7 dNJF2PDnTseGWxgfyYLqHqm3TMEVXlG76Jmu/QwV/U0wKiyMIXEP/Ek98m98RoBrZifs 4bhJQIqqWFAZ1ad8ZtWtMa20ctjpv27vRN2V6Hszc6PE0oAmMqdrV1V6YFsItJCoOlxn K+KDRjtoKbZ8Wy5rdHd3uRVwVC238cffNn4K1s9ZBHhsDyN02a4vSKjwHYT0jfOk6fC6 IJUQ== X-Gm-Message-State: APjAAAXt4u6dsf34ep01xS4YJJcxCtcNSKOA6vBknBucjhthN0WrRzwo EGL3HxzgKKjpXx9mXmOXff5C6LlX0lUUtgxbU0rzRfJF9a7m3zH56B6Sj6UHIwRWw781YILk13u MMKpNv5EMNXwA0MZST5I= X-Received: by 2002:a9f:3772:: with SMTP id a47mr16582743uae.53.1574626706116; Sun, 24 Nov 2019 12:18:26 -0800 (PST) X-Google-Smtp-Source: APXvYqyynofLRv500Izir2Dd/oLlg0rrh1Qltwnnr/lERPJyz8oyK4+wqIGPU2uXhxv4v6Nnfdbl6uc5C+TjkH4BPEs= X-Received: by 2002:a9f:3772:: with SMTP id a47mr16582733uae.53.1574626705667; Sun, 24 Nov 2019 12:18:25 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Sun, 24 Nov 2019 21:18:14 +0100 Message-ID: To: Neil Horman Cc: "dev@dpdk.org" , Olivier Matz , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Raslan Darawsheh X-MC-Unique: 78Ck8E_3PmGLhbxdldnYaA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] Build with coverage fail on rte_flow_dynf_metadata_offs is not flagged as experimental X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Nov 23, 2019 at 11:24 AM Andrew Rybchenko wrote: > > Hi, > > I've failed to quickly make a patch to fix it. > > make config T=3Dx86_64-native-linux-gcc O=3Dbuild_coverage > make -j8 EXTRA_CFLAGS=3D'-ggdb --coverage' EXTRA_LDFLAGS=3D-lgcov > > results in > > ... > CC ethdev_private.o > CC rte_ethdev.o > CC rte_class_eth.o > CC rte_flow.o > CC rte_tm.o > CC rte_mtr.o > CC ethdev_profile.o > rte_flow_dynf_metadata_offs is not flagged as experimental > but is listed in version map > Please add __rte_experimental to the definition of > rte_flow_dynf_metadata_offs > /home/arybchik/src/dpdk/mk/internal/rte.compile-pre.mk:114: recipe for > target 'rte_flow.o' failed > make[4]: *** [rte_flow.o] Error 1 > > I've manually reproduced it using gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4= .0 > but seen it on many different distros. Oh, good catch. We have a problem in the check script and maybe in the experimental tag. - This rte_flow_dynf_metadata_offs symbol is in .data but gets an associated symbol (seen with rhel7 gcc): $ objdump -t master/build/lib/librte_ethdev/rte_flow.o |grep rte_flow_dynf_metadata_offs 0000000000000000 l F .text.startup 000000000000000a _GLOBAL__sub_I_65535_0_rte_flow_dynf_metadata_offs 0000000000000620 g O .data 0000000000000004 rte_flow_dynf_metadata_o= ffs The script noticed the symbol in text and is complaining about not seeing it in text.experimental. But well, this is a bug as we did not protect for expansion in: if grep -q "\.text.*$SYM$" $DUMPFILE && ! grep -q "\.text\.experimental.*$SYM$" $DUMPFILE I suppose this would do the trick: if grep -q "\.text.*[[:space:]]$SYM$" $DUMPFILE && ! grep -q "\.text\.experimental.*[[:space:]]$SYM$" $DUMPFILE - I don't think variables were considered in the rte_experimental framework: seeing the __rte_experimental macro, I doubt it would work for variables to be put in .text. Do we need a different marker for those? or did I miss something else? Neil? Think we will have to live with this in 19.11... --=20 David Marchand