From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 08D0DA0487 for ; Fri, 5 Jul 2019 09:58:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ABF291B99B; Fri, 5 Jul 2019 09:58:58 +0200 (CEST) Received: from mail-ua1-f65.google.com (mail-ua1-f65.google.com [209.85.222.65]) by dpdk.org (Postfix) with ESMTP id 433401B959 for ; Fri, 5 Jul 2019 09:58:57 +0200 (CEST) Received: by mail-ua1-f65.google.com with SMTP id j2so1900914uaq.5 for ; Fri, 05 Jul 2019 00:58:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hwtqrFgA2lj07SZQ8U/cUCaq5T42dYWZsdXVM1SdB/0=; b=n+7NIXYUPKUCjYkbgt8bhHMBD9eMu2ilokl3HsT4V4NNt5QjoxjlfFmBQ0A0MFkNtu pZS+dJ4qPITxHu7NW6oTl315XVOGpLvYBUFK3eudHyhTbPvpZWmX4eHYd9ckcyusobLZ O5dM9Tmm/OoHBK+k7/lGWYZedKdGnWoBeILv+uX2YGeSV1gr3UqHpJ2+/Xme9kZdFZVl Fu9sdhlf2FKhlaAYJjeIgaAHLvs8MNeZG3mYls+eSi0v78dVEjFpBorIcf4aN6OUPeAE KH59VYIgcfdf7er1W23+C/h2PNkiQF/CjiSq4+AM3Zcm67HOsl+zGulxuoO0nCgPp7Nm nE+A== X-Gm-Message-State: APjAAAVTDVKLd7poUnmevde0l3EowvYqw+GJyExZe5O+XR1sqEASdL9M RfQHiwNRyswpfKpk160vhyBxPlYCswFtSnqEXXz0Pw== X-Google-Smtp-Source: APXvYqzRAf7jWHLVSMjsTLpOV+d7F1DD/qlDxp74iL9OWRAtCVCgd7oEyBDWYctRkQPxeyu0N0BWLlHc4Sltbjao8S0= X-Received: by 2002:ab0:168a:: with SMTP id e10mr1099874uaf.87.1562313536630; Fri, 05 Jul 2019 00:58:56 -0700 (PDT) MIME-Version: 1.0 References: <20190530174819.1160221-1-benjamin.walker@intel.com> <1560505157-9769-1-git-send-email-david.marchand@redhat.com> <1560505157-9769-4-git-send-email-david.marchand@redhat.com> <20190704101418.4fc26cc3@hermes.lan> In-Reply-To: <20190704101418.4fc26cc3@hermes.lan> From: David Marchand Date: Fri, 5 Jul 2019 09:58:44 +0200 Message-ID: To: Stephen Hemminger Cc: dev , Ben Walker , Jerin Jacob Kollanukkaran , "Burakov, Anatoly" , Maxime Coquelin , Thomas Monjalon Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 3/3] bus/pci: only consider usable devices to select IOVA mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 4, 2019 at 7:14 PM Stephen Hemminger wrote: > On Fri, 14 Jun 2019 11:39:17 +0200 > David Marchand wrote: > > > /* Supports only RTE_KDRV_NIC_UIO */ > > + if (pdev->kdrv != RTE_KDRV_NIC_UIO) > > + RTE_LOG(DEBUG, EAL, "Unsupported kernel driver? Defaulting > to IOVA as 'PA'\n"); > > Maybe NOTICE level, rather than DEBUG which is usually suppressed. > What do you mean by "suppressed" ? We had a hardwired log level some time ago, but it has been removed and all logs are in the binaries now. https://git.dpdk.org/dpdk/commit/?id=5d8f0baf69ea > > + } else if (is_vfio_noiommu_enabled != 0) { > > + RTE_LOG(DEBUG, EAL, "Forcing to 'PA', vfio-noiommu > mode configured\n"); > ditto > > -- David Marchand