From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9841CA0C43; Thu, 23 Sep 2021 10:12:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 855AE4124D; Thu, 23 Sep 2021 10:12:25 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id AFF964124A for ; Thu, 23 Sep 2021 10:12:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632384743; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fG7E0R4pvBn/M3gjLq7BIACc8lDCV6pdMZPk7qGAaxA=; b=fKYhKxG2EWS3ztPnaLzP1B65ZK/0/FLw2Jy4lYBKWg7e/0Nab/NYwpD1Fpx7p8k+xgckGR 3lAsJ9SmGQpKT+ms091/7jk47NNgsPEBMI/1OEZFXsh9g7+zwSYsoz1sqfm747ez6IZVsw gv2MIZ/IWfwcvKk20npqZqBz3Cm8ZDY= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-558-j3XAeF-8PTWdiJe7iSuYBA-1; Thu, 23 Sep 2021 04:12:22 -0400 X-MC-Unique: j3XAeF-8PTWdiJe7iSuYBA-1 Received: by mail-lf1-f71.google.com with SMTP id s28-20020a056512203c00b003f42015e912so5413416lfs.4 for ; Thu, 23 Sep 2021 01:12:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fG7E0R4pvBn/M3gjLq7BIACc8lDCV6pdMZPk7qGAaxA=; b=Dl5kgMiOQxiI2IL2FyiP5WvyB++QyWRGHMatvPap6YBun7TFZYqXS7Stl8IpJqMX1z Wcj6uSw1d6784kFZOavV8bCmGgTohIz24SrqHtlKNAxH1y+e9EHQTHzbejXxQk1nK8Ip CQz/rFLBhWVMHSoUHpHP4BHcYIUGU7QAEoLDmVtj9racEvsMJG0N6eW/qXCITaT0k3Qr YA7tJJvphDeRVc9y+FKPU/DB0VUTnAtJhdPDRTi+O5D43G68symS99vW9Dc+QeXcvi1C qj6bsV4FfYXqPLb7+q01o1jbI0GGJrIetALP3DgsmamH7R0srU/H5VfJbWwiwopBt1gH onRg== X-Gm-Message-State: AOAM531mYDpHajbFX4D95IrndSgLUvxvvXCi/iHjZ2xeD3yZwR0uH/Zk WCz25hoBx0DFnRCEhA0ja9h3VImwCg0BL75h9MmsCQEbZH99St6GACGIeTtq9K2ZiFUhDafHYkB oent3FUYWt3DP3h9Q+GA= X-Received: by 2002:a05:6512:370f:: with SMTP id z15mr3139055lfr.484.1632384740569; Thu, 23 Sep 2021 01:12:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyqcPohcKGJYpSQ7B2nGmb5MB/wdYHonA/hZrImahUWZPub2EG/GafhiH8FeRrmPDudq9UNjRXLIjGC70ctrRA= X-Received: by 2002:a05:6512:370f:: with SMTP id z15mr3139042lfr.484.1632384740340; Thu, 23 Sep 2021 01:12:20 -0700 (PDT) MIME-Version: 1.0 References: <20210921115015.36442-1-david.hunt@intel.com> <20210922122920.34759-1-david.hunt@intel.com> <20210922122920.34759-2-david.hunt@intel.com> In-Reply-To: <20210922122920.34759-2-david.hunt@intel.com> From: David Marchand Date: Thu, 23 Sep 2021 10:12:09 +0200 Message-ID: To: David Hunt Cc: dev , Bruce Richardson , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 2/2] eal: add additional info if core mask too long X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Sep 22, 2021 at 2:29 PM David Hunt wrote: > > If the user requests to use an lcore above 128 using -c, > the eal will exit with "EAL: invalid core list syntax" and > very little else useful information. invalid coremask* > > This patch adds some extra information suggesting to use --lcores > so that physical cores above RTE_MAX_LCORE (default 128) can be > used. This is achieved by using the --lcores option by mapping > the logical cores in the application to physical cores. > > For example, if "-c 0x300000000000000000000000000000000" is > used, we see the following additional output on the command line: > > EAL: lcore 128 >= RTE_MAX_LCORE (128) > EAL: lcore 129 >= RTE_MAX_LCORE (128) > EAL: to use high physical core ids , please use --lcores to > map them to lcore ids below RTE_MAX_LCORE, > EAL: e.g. --lcores 0@128,1@129 > > Signed-off-by: David Hunt > Acked-by: Bruce Richardson > --- > changes in v3 > * added this patch to the set. Addresses the changes for > the -c option. > changes in v4 > * fixed buffer overrun in populating lcore array > * switched from strlcpy to strdup due to a clang error > --- > --- > lib/eal/common/eal_common_options.c | 66 +++++++++++++++++++++++------ > 1 file changed, 54 insertions(+), 12 deletions(-) > > diff --git a/lib/eal/common/eal_common_options.c b/lib/eal/common/eal_common_options.c > index de1717946f..19d3588f78 100644 > --- a/lib/eal/common/eal_common_options.c > +++ b/lib/eal/common/eal_common_options.c > @@ -747,15 +747,23 @@ check_core_list(int *lcores, unsigned int count) > static int > eal_parse_coremask(const char *coremask, int *cores) > { > - unsigned count = 0; > + unsigned int count = 0, k; Same as patch 1, no need for count. > int i, j, idx; > int val; > char c; > + int lcores[RTE_MAX_LCORE]; > + char *coremask_copy = NULL; Contrary to patch 1, coremask_copy is used. But, coremask is const, we can directly use it in log messages. So same as patch 1, please remove coremask_copy. > > for (idx = 0; idx < RTE_MAX_LCORE; idx++) > cores[idx] = -1; > idx = 0; > > + coremask_copy = strdup(coremask); > + if (coremask_copy == NULL) { > + RTE_LOG(ERR, EAL, "Unable to duplicate coremask\n"); > + return -ENOMEM; > + } > + > /* Remove all blank characters ahead and after . > * Remove 0x/0X if exists. > */ > @@ -767,30 +775,64 @@ eal_parse_coremask(const char *coremask, int *cores) > i = strlen(coremask); > while ((i > 0) && isblank(coremask[i - 1])) > i--; > - if (i == 0) > - return -1; > + if (i == 0) { > + RTE_LOG(ERR, EAL, "No lcores in coremask: %s\n", coremask_copy); > + goto err; > + } > > - for (i = i - 1; i >= 0 && idx < RTE_MAX_LCORE; i--) { > + for (i = i - 1; i >= 0; i--) { > c = coremask[i]; > if (isxdigit(c) == 0) { > /* invalid characters */ > - return -1; > + RTE_LOG(ERR, EAL, "invalid characters in coremask: %s\n", > + coremask_copy); > + goto err; > } > val = xdigit2val(c); > - for (j = 0; j < BITS_PER_HEX && idx < RTE_MAX_LCORE; j++, idx++) > + for (j = 0; j < BITS_PER_HEX; j++, idx++) > { > if ((1 << j) & val) { > - cores[idx] = count; > - count++; > + if (count < RTE_MAX_LCORE) { > + lcores[count++] = idx; > + } else { > + RTE_LOG(ERR, EAL, "Too many lcores provided. Cannot exceed %d\n", > + RTE_MAX_LCORE); > + goto err; > + } You can invert those blocks: if (count >= RTE_MAX_LCORE) { RTE_LOG(); goto err; } lcores[count] = idx; count++; > } > } > } > for (; i >= 0; i--) > - if (coremask[i] != '0') > - return -1; > - if (count == 0) > - return -1; > + if (coremask[i] != '0') { > + RTE_LOG(ERR, EAL, "invalid characters in coremask: %s\n", > + coremask_copy); > + goto err; > + } > + if (count == 0) { > + RTE_LOG(ERR, EAL, "No lcores in coremask: %s\n", coremask_copy); > + goto err; > + } > + > + if (check_core_list(lcores, count)) > + goto err; > + > + /* > + * Now that we've gto a list of cores no longer than > + * RTE_MAX_LCORE, and no lcore in that list is greater > + * than RTE_MAX_LCORE, populate the cores > + * array and return. > + */ > + for (k = 0; k < count; k++) > + cores[lcores[k]] = k; > + > + if (coremask_copy) > + free(coremask_copy); > + > return 0; > +err: > + if (coremask_copy) > + free(coremask_copy); > + return -1; > } > > static int > -- > 2.17.1 > -- David Marchand