From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06811A04C0; Fri, 25 Sep 2020 16:22:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 42F5F1E978; Fri, 25 Sep 2020 16:22:54 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 29FB01E977 for ; Fri, 25 Sep 2020 16:22:52 +0200 (CEST) Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601043770; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3KnnQsUkK5NzoDP+llmP8s2AuNHHNSVSSAlZ9SxrYeo=; b=ga/GntXbRS7JNriTZEJZkOSvelB+mXyCJYFX/UjMfFKyel+ud3ymBtmRgmzfyIY0qKxAAq GPAntNXhwSE91I0OxuEMhe7PW7zQkfSE7OjJrPnegiHJkmPTBoRmlGdJMK2aVyoeHvU2Sw 23nfIFmeQx0PZWX1pOBHFXeogzORUh0= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-219-oK23b_VnMym4pbdsDZiceA-1; Fri, 25 Sep 2020 10:22:47 -0400 X-MC-Unique: oK23b_VnMym4pbdsDZiceA-1 Received: by mail-ua1-f72.google.com with SMTP id m17so750061uan.19 for ; Fri, 25 Sep 2020 07:22:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3KnnQsUkK5NzoDP+llmP8s2AuNHHNSVSSAlZ9SxrYeo=; b=cF6knKtNXXZgAlXoSc44CQ0Agq8i7bcih9hC2uQD9E4uPF3eJ1Qp+171KQ1u5zYNA5 U4MFanfMQ9jzIaRF+FcsXa+USJjsZxhTv5C6UJq6LC9Un9gjGThSJXULw+tPe+G9RImo KIKI6MYDQthW6+32c0fCXn3Hk9yAPCuilqROoLES80c00lKShztY2u/0i4B6Yje8hgv4 DZ8plrZ3/5aX2EPdQBjZiYCUB3SmrrJFZ7EzIWwjFsSBgsOtyuBSCIe0lPaf4f0UL7JO 0okeMtHAQALtkEpprdmaBM1ge83xhubWhir6hVv4V5aFtJwI+xNslf2j3ez0CbWvp37y iUCg== X-Gm-Message-State: AOAM532H6Ld/pGBsFrVCFTDsiq03RaYVdlIqN/hi0FN8uEInmFklrRoT BUPvW44iSRHkjKfd+UOMjiYyMbM4psra6ESFSYEdDAJrpVI0dnTk4JdEMiha5U6GZvbwAJgQsrU 1zpdSrZKhA8IHqKqirZk= X-Received: by 2002:a67:e2c2:: with SMTP id i2mr3196591vsm.27.1601043767056; Fri, 25 Sep 2020 07:22:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxV0fpa3JGW1AFvRAmgNmdBp186ImloB2IlZnwvfzUWFtIdjg6tqMeMYylKNaDVsC8ogEWTGuHVRrPDB9Ffbsw= X-Received: by 2002:a67:e2c2:: with SMTP id i2mr3196568vsm.27.1601043766820; Fri, 25 Sep 2020 07:22:46 -0700 (PDT) MIME-Version: 1.0 References: <20200415064238.24012-1-sarosh.arif@emumba.com> <20200908102204.727240-1-sarosh.arif@emumba.com> In-Reply-To: <20200908102204.727240-1-sarosh.arif@emumba.com> From: David Marchand Date: Fri, 25 Sep 2020 16:22:35 +0200 Message-ID: To: Sarosh Arif , David Hunt Cc: Lukasz Wojciechowski , dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [v3 PATCH] test_distributor: prevent memory leakages from the pool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Sep 8, 2020 at 12:22 PM Sarosh Arif wrote: > > rte_mempool_get_bulk is used to get bufs/many_bufs from the pool, > but at some locations when test fails the bufs/many_bufs are > not returned back to the pool. > Due to this, multiple executions of distributor_autotest gives the > following error message: Error getting mbufs from pool. > To resolve this issue rte_mempool_put_bulk is used whenever the test > fails and returns. > > Signed-off-by: Sarosh Arif It deserves a Fixes: line. I can see a ack from Lukasz. David, review please? -- David Marchand