From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF8C8A0C47; Thu, 14 Oct 2021 15:07:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5E0554112E; Thu, 14 Oct 2021 15:07:10 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 695A940E50 for ; Thu, 14 Oct 2021 15:07:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634216827; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7HwcMr0uZrPwLeorqVOO/5iLdIDFLnEhUiBReuEbrM4=; b=Mw3LKWYT21FyapyCkeBlYt8yvMa1156GEk56y586t6S3dwCv2OMki8dosWp80NF6Mz7Rzx sr8xSObJaKmM8Ifm983bVsGsXgn+9CnYvNfm9lrj/1ULR0iw1N8B3ReM+ThwHm0xE7I+8t FPIJxPXKMaDg8djFWt9s3CS9Sv+IRRM= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-527-jASTzRk4O8C6TIPQ6VpTaw-1; Thu, 14 Oct 2021 09:07:01 -0400 X-MC-Unique: jASTzRk4O8C6TIPQ6VpTaw-1 Received: by mail-lf1-f69.google.com with SMTP id bt36-20020a056512262400b003fd7e6a96e8so4281603lfb.19 for ; Thu, 14 Oct 2021 06:07:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7HwcMr0uZrPwLeorqVOO/5iLdIDFLnEhUiBReuEbrM4=; b=tHQqdLeS+bU5Xbj1e6H17tyqaO3VBVkFjCBviswUt1/MeYNirKm+fiYVG0dKX64nFf aGmNRSmcdGETJ2Z4RP5nbOpunUtabdAcsdMQk9lyZ4uHjYVudcuwa21kdUwpT/FII6+h SP8tlV+prf8VuXHDXkN0TpmS1EjqP/xmKpmCEYxux33RaLSltGwC+uBOq9QZhzDKhBIR diePIEXAJhS/6SXymdFHdrFIa7ZNt79sNdLgZsYfN8/u9LF7az7sDxXdVUV79kgqJipn oVaNy4ixi8IPXbmFxYNGT+vvDdEz3xmHMLdQSKoUjFmsrbbdaWcwui7Cv75AMrbNmc5V MtLQ== X-Gm-Message-State: AOAM532uDETcf6anm1fjY5HvOarfdrT1oNYi+e56YvO7e2UYW55sHpd2 Wsvb43xXyrw4pS1Negel3xwVXXspNkT1GuXAiDqPWBsWPzOFcKRpYq3Qpkv2wFWi7fQSVactyrc tRd4NV7WB/zLVGfzdsU0= X-Received: by 2002:a19:c514:: with SMTP id w20mr2019883lfe.265.1634216819515; Thu, 14 Oct 2021 06:06:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyT+P1mgd7C02Lg1Bovl1rd1GpjCibGglabWPTjPIWXE3vvohmFDfp2Vqvs9otDk0p0yq8/sbNZxevz+mT0xGE= X-Received: by 2002:a19:c514:: with SMTP id w20mr2019827lfe.265.1634216818980; Thu, 14 Oct 2021 06:06:58 -0700 (PDT) MIME-Version: 1.0 References: <20210824095556.740201-1-maciej.szwed@intel.com> In-Reply-To: <20210824095556.740201-1-maciej.szwed@intel.com> From: David Marchand Date: Thu, 14 Oct 2021 15:06:47 +0200 Message-ID: To: Maciej Szwed Cc: dev , Harman Kalra , "Burakov, Anatoly" , Jeff Guo Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4] eal: read data buffer on RTE_INTR_HANDLE_VFIO_REQ X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Aug 24, 2021 at 12:28 PM Maciej Szwed wrote: > > We should call read() on RTE_INTR_HANDLE_VFIO_REQ event > to confirm that event. Still no review, Cc: maintainers / contributors to this code. This looks like a fix, if so, please add a Fixes: tag. Should this be backported to stable branches? > > Signed-off-by: Maciej Szwed > --- > lib/eal/linux/eal_interrupts.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/lib/eal/linux/eal_interrupts.c b/lib/eal/linux/eal_interrupts.c > index 22b3b7bcd9..dc42527344 100644 > --- a/lib/eal/linux/eal_interrupts.c > +++ b/lib/eal/linux/eal_interrupts.c > @@ -918,17 +918,16 @@ eal_intr_process_interrupts(struct epoll_event *events, int nfds) > bytes_read = sizeof(buf.timerfd_num); > break; > #ifdef VFIO_PRESENT > +#ifdef HAVE_VFIO_DEV_REQ_INTERFACE > + case RTE_INTR_HANDLE_VFIO_REQ: > + call = true; Afaiu, call should be set only if the read() call succeeds. > +#endif > + /* fall through */ > case RTE_INTR_HANDLE_VFIO_MSIX: > case RTE_INTR_HANDLE_VFIO_MSI: > case RTE_INTR_HANDLE_VFIO_LEGACY: > bytes_read = sizeof(buf.vfio_intr_count); > break; > -#ifdef HAVE_VFIO_DEV_REQ_INTERFACE > - case RTE_INTR_HANDLE_VFIO_REQ: > - bytes_read = 0; > - call = true; > - break; > -#endif > #endif > case RTE_INTR_HANDLE_VDEV: > case RTE_INTR_HANDLE_EXT: > -- > 2.27.0 > -- David Marchand