From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8284742CC2; Thu, 15 Jun 2023 09:28:20 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 71A2941101; Thu, 15 Jun 2023 09:28:20 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 928E4410D0 for ; Thu, 15 Jun 2023 09:28:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686814098; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nayTwwSkSMi2Xyz7m/pBPOf/U2mI39cRbbopwEyNI9U=; b=N5dBy9uMbk0/C1QO+r8xzSwRxm4JyK+0iFrZJcnYLlZWqwy5ihZ+HGfSbmreG25NW+sGo/ rSj1k2Viq9kteieTxs7HmWnxcb8eVsT4Ip5cnH7YUa66d0MZg5V6sgI3PKlg9vAOIRu6Q9 ei7XEFOwqit2LDwKc3xw4I0g9fIKey8= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-281-Q-_3Nqd2O2G6du_MDBdkcg-1; Thu, 15 Jun 2023 03:28:16 -0400 X-MC-Unique: Q-_3Nqd2O2G6du_MDBdkcg-1 Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-25c13937316so1413164a91.2 for ; Thu, 15 Jun 2023 00:28:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686814096; x=1689406096; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nayTwwSkSMi2Xyz7m/pBPOf/U2mI39cRbbopwEyNI9U=; b=coD0rX3Vulikogo1M7oWpTRKUrN0wookYRo3ulc/dJ7XZfBWjbzfRAH2a1/9vRWpC+ sJ0vJzHKMUUCml1WPCbICQusmcDfC0t7u7HKYq6Y4f/IAcgDo8StO4l04fJHdZgLrZdM LB53lYaGyVvesGijg+aRLxNOiXC/u0hH8f+I2QmgcIs29Zo10O4oAr6KGujP7UjQ/tsF hjmoKZVkQpJ4FhV4XPao+3JLKc/+ZhuWCZdFntp1Y8HtIHLRQpMZKJpSbEr///BbWa0I R1Y9mwn/KNwQKK3HLKruOIjpWTK2sATYJAofDsfoPBu0zVHVZgrmHIOSMJG2tks/5HtD B1RA== X-Gm-Message-State: AC+VfDy0DJCka039TH+jWEueeOFR310bKFyqPZHOpecGDzL9A7d33sEh Eicgf0lT8hS0FpaDxcAfpbZ0SVYfGGlueuBqc/KfkytnGd+89BYOZZ1716gnz/pf9Qg93Lck05G 8F41gD4A+sT/8h49g1Ws= X-Received: by 2002:a17:90a:8004:b0:25e:9d0e:9d42 with SMTP id b4-20020a17090a800400b0025e9d0e9d42mr313661pjn.19.1686814095883; Thu, 15 Jun 2023 00:28:15 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6fxZSAwATJX4YqJsu9y3iMisLnRrQ0RWGbY+NhRxeSoalgadWHOFyqQE/IvHaWKn6wRcmwIKiA4xr8KVwKm/g= X-Received: by 2002:a17:90a:8004:b0:25e:9d0e:9d42 with SMTP id b4-20020a17090a800400b0025e9d0e9d42mr313655pjn.19.1686814095567; Thu, 15 Jun 2023 00:28:15 -0700 (PDT) MIME-Version: 1.0 References: <20230615051717.2906443-1-junfeng.guo@intel.com> In-Reply-To: <20230615051717.2906443-1-junfeng.guo@intel.com> From: David Marchand Date: Thu, 15 Jun 2023 09:28:04 +0200 Message-ID: Subject: Re: [PATCH 0/2] fix variable type in pattern parsing for raw flow To: Junfeng Guo Cc: qi.z.zhang@intel.com, qiming.yang@intel.com, dev@dpdk.org, stable@dpdk.org, ting.xu@intel.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jun 15, 2023 at 7:17=E2=80=AFAM Junfeng Guo = wrote: > > In current pattern parsing function for protocol agnostic flow > offloading (raw flow), some of the variables of packet length are > defined as uint8_t, which are too small for some large-size packets, > such as srv6 (Segment Routing over IPv6 dataplane) type. Change the > type to uint16_t. > > For example, the length of below srv6 paket is 268 B, larger than the > max of uint8_t type (i.e., 256). > "mac()/ipv6(nextheader=3D43)/ipv6srh(headerextlength=3D4,nextheader=3D41)= \ > /ipv6(dst=3D2001:2:0:0:0:0:0:2)" > > Junfeng Guo (2): > net/ice: fix variable type in pattern parsing for raw flow > net/iavf: fix variable type in pattern parsing for raw flow In the commit title, it is better to describe a functional impact rather than repeat the implementation of a fix. This makes it easier for people looking for a fix for their specific issue they are investigating. And, on the contrary, it also makes it easier when looking for a regression on a specific feature. Here, "fix variable type" gives no clue that it is linked to packet length or the protocol agnostic/raw pattern offloading feature. So, I don't understand this part of the code, but I think a better title would be: net/ice: fix protocol agnostic offloading with big packets Does it sound ok to you? > > drivers/net/iavf/iavf_hash.c | 2 +- > drivers/net/ice/ice_fdir_filter.c | 2 +- > drivers/net/ice/ice_hash.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > -- > 2.25.1 > --=20 David Marchand