From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 557B142534; Thu, 7 Sep 2023 10:55:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 501F9402AF; Thu, 7 Sep 2023 10:55:45 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id BC8444026C for ; Thu, 7 Sep 2023 10:55:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694076943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BHsRiejzTWVppXmD4gOe4V7Xy9NXAg6U2Yry2hTf36Q=; b=ZFDxdL1fRGq/kaWmLtbP0BWjZbO1OMRbNI0Ah9/PD8my0rypIc1TnXJiYQY1DY3S7VLDOj JkX2zEqW61Fis5wULXdNhbWztG46pz5J8OlMh1n/94YbCq0D4UZ2BPBGv2F1fYAo1FCr11 lyqW8TD6sNBvTje5e/e4I6M05zhHqLA= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-501-kB00i31CMaG2Lb3B4IoWqQ-1; Thu, 07 Sep 2023 04:55:42 -0400 X-MC-Unique: kB00i31CMaG2Lb3B4IoWqQ-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2bcb47970eeso8446481fa.3 for ; Thu, 07 Sep 2023 01:55:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694076940; x=1694681740; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BHsRiejzTWVppXmD4gOe4V7Xy9NXAg6U2Yry2hTf36Q=; b=fnXutIsFrZ3iCMd77RcalLVThUULkFLVsYkJOA/qE36EB+N5AaJrJ3byuHjUm2KBeE BZXrp5eP4WCiVN53IddAYmIDioG5QYvC9jum8rvOCW5+2j+8CUeKUFJuzq65Tq1KJ7xq f+FaVv5/tUCKquz9G1MjNuj3Eh6WQYoqkER2gqvaFwPk95El+cBdgGQCdPeUl0ACN0Ys PtTbO2CMfzPd20sAUr/JOObRe8/OI5d46/FJ4qzTCrru+CzkL3oFATHje8n0bYSvbVAn VX0dObquAAvEcMTDm3yMINuQT8hzieLi3FFAMW7+nBJaSKcPNdCiGUPJvHevzISanW/p HvsA== X-Gm-Message-State: AOJu0Yy8apF5TDu8DzmWw2VQxPt5zbo/x+IyhsrGpXXgrbd5E7iK/1t6 FAq9d2obgFUYqyx76VPzS252zm3qV+f6SfvJwA5t3m7ewZj2c0E6AOXl7tDQA8w4kM16vIT1nQ7 1+tIvGWqo1HsVAJVoHIE= X-Received: by 2002:a2e:3e1a:0:b0:2bc:eb95:15c7 with SMTP id l26-20020a2e3e1a000000b002bceb9515c7mr3812041lja.49.1694076940691; Thu, 07 Sep 2023 01:55:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGq2PPFc2AzorTvIQoPB0UM9DWPlNPuijMj0G4Rd1PD2Ep9KK259DoH25D7VrDnRNq0RtoR6z17miFbWYAvTAw= X-Received: by 2002:a2e:3e1a:0:b0:2bc:eb95:15c7 with SMTP id l26-20020a2e3e1a000000b002bceb9515c7mr3812029lja.49.1694076940333; Thu, 07 Sep 2023 01:55:40 -0700 (PDT) MIME-Version: 1.0 References: <20230906162226.1618088-1-thomas@monjalon.net> <20230906162226.1618088-6-thomas@monjalon.net> <98CBD80474FA8B44BF855DF32C47DC35D87B82@smartserver.smartshare.dk> In-Reply-To: From: David Marchand Date: Thu, 7 Sep 2023 10:55:29 +0200 Message-ID: Subject: Re: [PATCH 05/11] eal: force prefix for internal threads To: =?UTF-8?Q?Morten_Br=C3=B8rup?= Cc: Thomas Monjalon , dev@dpdk.org, Tyler Retzlaff , Ferruh Yigit X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Sep 7, 2023 at 10:53=E2=80=AFAM David Marchand wrote: > > On Thu, Sep 7, 2023 at 10:50=E2=80=AFAM Morten Br=C3=B8rup wrote: > > > This 10 value in the comment is easy to miss if some change with the > > > prefix is done. > > > Mentionning RTE_THREAD_INTERNAL_NAME_SIZE is enough. > > > > I disagree with David's comment to this. > > > > The function documentation is easier to read if the actual number is al= so mentioned. > > > > For the best of both worlds, you can add something like this nearby: > > > > _Static_assert(sizeof(RTE_THREAD_NAME_PREFIX) =3D=3D sizeof("dpdk-"), > > "Length of RTE_THREAD_NAME_PREFIX has changed; " > > "the documentation needs updating."); > > And how will it catch the comment about 10 characters ? I mean you still have to re-read the whole documentation and look for some reference somewhere about 10 characters. --=20 David Marchand