From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D8D0A328D for ; Tue, 22 Oct 2019 11:05:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5C4601BE9B; Tue, 22 Oct 2019 11:05:17 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id AA8571BE95 for ; Tue, 22 Oct 2019 11:05:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571735115; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qZM5weuxnIh4WZAAOPJRmEU3EM/YGqVngQFXFX51jjg=; b=f5m4PUkQU1dyNmbRYS+sItI3/UXV0WRwFxpbcmcQ+1/dRr92fvUrEpH0HCT5EU3zb9SS3/ Ctl37ckgpRaxTaQ+Ld7Vy1lVBIRHwq5cWgIFcKiStoY2j4uP6N6DggKEydy7h7g8MMoSWC zGKIND0rGNojz+zUGdjqMv7FEzMnSTk= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-130-VXXKMTqpPteOSS7M-_LsMQ-1; Tue, 22 Oct 2019 05:05:14 -0400 Received: by mail-ua1-f71.google.com with SMTP id 4so1951509uay.14 for ; Tue, 22 Oct 2019 02:05:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hDoiaHHSEYwJy0qI0zb8k2SD5PXue/VGHUI0tsTYco4=; b=KmjaF3qHHPt5yolRS2vmmBKMegoaOpHbZjx+DPnoCNkBHU2/b6tpBKCXp1YeR+67jJ 4hLLo7i2s3jF7AijCkhTt49YbTC+wxwKx/dhWmIdQzUaGwkfRXJCzNxq/jXB7bS0V5IA hdLtnqVG+ujPE6KkLd2D6bVdALw76U6rY6UW/9Lwe2UyYPfsY1WYrJb9Chpn1E1QwshO UtcBzsrXCXnC98sr72Hz6JW27k5g6ymmSmsZ2QRtd0RkwshNWvBiVuRkU7zn234tzmfq kzvsdhSSX8C+y3AuPo+zooqQXK4kdA/J7NqFgXL17yttEvwgG7cglxIGAHimmXFHaZb1 H98Q== X-Gm-Message-State: APjAAAXFYdQOidcDQVTQGXonVC9vhP0UZu+0K9UjTyvFAKjEhm0ArGRZ Hyt3Pv9HAsKngp21V8XHayb74lt2liSEs3I8E2e6XKFnHXgANALifSFc7TtPftXoo4vapzbYfIk 7P9XAQ9WfvhLLMqCmsKs= X-Received: by 2002:a05:6102:387:: with SMTP id m7mr1191415vsq.105.1571735113437; Tue, 22 Oct 2019 02:05:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqwneNzE4cB0cTfrruAHdDINOXpSHJZsyB1D5F6wPL2/cv+tKMLGOpiYvdrcuNymlHUgFWg+4tqACd96HwMyYPE= X-Received: by 2002:a05:6102:387:: with SMTP id m7mr1191386vsq.105.1571735112928; Tue, 22 Oct 2019 02:05:12 -0700 (PDT) MIME-Version: 1.0 References: <20190925161013.3656-1-stephen@networkplumber.org> <20191002194024.28782-1-stephen@networkplumber.org> In-Reply-To: <20191002194024.28782-1-stephen@networkplumber.org> From: David Marchand Date: Tue, 22 Oct 2019 11:05:01 +0200 Message-ID: To: Stephen Hemminger Cc: dev X-MC-Unique: VXXKMTqpPteOSS7M-_LsMQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v8] eal: make lcore_config private X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 2, 2019 at 9:40 PM Stephen Hemminger wrote: > +struct lcore_config { > + pthread_t thread_id; /**< pthread identifier */ > + int pipe_master2slave[2]; /**< communication pipe with master */ > + int pipe_slave2master[2]; /**< communication pipe with master */ > + > + lcore_function_t * volatile f; /**< function to call */ > + void * volatile arg; /**< argument of function */ > + volatile int ret; /**< return value of function */ > + > + uint32_t core_id; /**< core number on socket for this lc= ore */ > + uint32_t core_index; /**< relative index, starting from 0 *= / > + uint16_t socket_id; /**< physical socket id for this lcore= */ > + uint8_t core_role; /**< role of core eg: OFF, RTE, SERVIC= E */ > + uint8_t detected; /**< true if lcore was detected */ > + volatile enum rte_lcore_state_t state; /**< lcore state */ > + rte_cpuset_t cpuset; /**< cpu set which the lcore affinity = to */ > +}; There are still changes on the core_id, core_index, socket_id that I am not confortable with (at this point). I prepared a series for -rc1 on ABI changes in EAL (that I will send shortl= y). I took your patch without the changes on core_id, core_index and socket_id. We can discuss those changes later, thanks. --=20 David Marchand