From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dmarchan@redhat.com>
Received: from mail-vs1-f68.google.com (mail-vs1-f68.google.com
[209.85.217.68]) by dpdk.org (Postfix) with ESMTP id 0F2C71B69B
for <dev@dpdk.org>; Thu, 10 Jan 2019 14:57:54 +0100 (CET)
Received: by mail-vs1-f68.google.com with SMTP id n13so7047435vsk.4
for <dev@dpdk.org>; Thu, 10 Jan 2019 05:57:53 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=D2a7u41gBBcM/I82BDZqv2+q99DU4pd9jywboPJN8IQ=;
b=uDCVa0x20j0ZD/pkeX0RgO0Rp3/zTQHE7OEjovkah08Gn05y8tg1Zp3pTvL9QD9bUw
zEfFoa8WLsmx1inZbRWouX8B3pb+aApaam4HfXOCrl/XTaDVXgd0oMNNIqjr08R/umFG
B3sjiVW38pvwWis3l9lhDbZTapE++Gf1gVCQUsusqhHkI0Tiqwce9DTxcV1j1iVSrV1e
8Y5oTXur9CxJpbPwyNMhH7Ww9kAY6p/KEObzIE0fAx6DYbDqVDPDbIGvxARsz0NaOrzi
jgIUU1/Ak7Pnvij9PgI/VlTVUY3nj2nPnQYyzAGTY75edMM85spriusXLsgcg5jRemoW
9vBQ==
X-Gm-Message-State: AJcUukeCRFZPFNWeuj8UdpwwOz2vIusJeLqisbgrD/b99Svm2LKmtFyT
cvOB3IQwDCIpGTYWRwVgd9KFZh4B6EwXRl9S24fiKg==
X-Google-Smtp-Source: ALg8bN4vplH86e0m7N3Zhnjazx86BieOq5hKhVykDjkrZv4wfohzAARjgoP1VEML6i9AhBqxIw0TG6aZSJbBWwyX6rM=
X-Received: by 2002:a67:c48a:: with SMTP id d10mr4394447vsk.105.1547128673333;
Thu, 10 Jan 2019 05:57:53 -0800 (PST)
MIME-Version: 1.0
References: <20190110111104.56464-1-bruce.richardson@intel.com>
<20190110134732.57052-1-bruce.richardson@intel.com>
In-Reply-To: <20190110134732.57052-1-bruce.richardson@intel.com>
From: David Marchand <david.marchand@redhat.com>
Date: Thu, 10 Jan 2019 14:57:41 +0100
Message-ID: <CAJFAV8zUjAb2grHOu1M_ndYDq5b2uR3sVmcFEj=L0UUDv_srDA@mail.gmail.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>, dpdk stable <stable@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v2] compat: merge compat library into EAL
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Jan 2019 13:57:54 -0000
On Thu, Jan 10, 2019 at 2:48 PM Bruce Richardson <bruce.richardson@intel.com>
wrote:
> Since compat library is only a single header, we can easily move it into
> the EAL common headers instead of tracking it separately. The downside of
> this is that it becomes a little more difficult to have any libs that are
> built before EAL depend on it. Thankfully, this is not a major problem as
> the only library which uses rte_compat.h and is built before EAL (kvargs)
> already has the path to the compat.h header file explicitly called out as
> an include path.
>
> However, to ensure that we don't later hit problems later with this, we can
> add EAL common headers folder to the global include list in the meson build
> which means that all common headers can be safely used by all libraries, no
> matter what their build order.
>
> As a side-effect, this patch also fixes an issue with building on BSD using
> meson, due to compat lib no longer needing to be listed as a dependency.
>
CC stable.
>
> Fixes: a8499f65a1d1 ("log: add missing experimental tag")
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> ---
> V2: Clean up a few missed references to the compat library in our
> documentation and MAINTAINERS file.
> Added in fixes tag, as this patch should also fix build issues
> with BSD.
> ---
> MAINTAINERS | 1 -
> doc/api/doxy-api.conf.in | 1 -
> doc/guides/contributing/documentation.rst | 1 -
> doc/guides/contributing/versioning.rst | 2 +-
> lib/Makefile | 2 --
> lib/librte_cmdline/meson.build | 1 -
> lib/librte_compat/Makefile | 13 -------------
> lib/librte_compat/meson.build | 8 --------
> lib/librte_eal/common/Makefile | 2 +-
> .../common/include}/rte_compat.h | 0
> lib/librte_eal/common/meson.build | 1 +
> lib/librte_eal/linuxapp/eal/meson.build | 2 +-
> lib/librte_eal/meson.build | 1 -
> lib/librte_kvargs/meson.build | 3 ---
> lib/meson.build | 2 +-
> meson.build | 2 +-
> 16 files changed, 6 insertions(+), 36 deletions(-)
> delete mode 100644 lib/librte_compat/Makefile
> delete mode 100644 lib/librte_compat/meson.build
> rename lib/{librte_compat => librte_eal/common/include}/rte_compat.h
> (100%)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 470f36b9c..4dbb111a0 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -121,7 +121,6 @@ F: buildtools/symlink-drivers-solibs.sh
>
> ABI versioning
> M: Neil Horman <nhorman@tuxdriver.com>
> -F: lib/librte_compat/
>
Maybe ?
+F: lib/librte_eal/common/include/rte_compat.h
Tested-by: David Marchand <david.marchand@redhat.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand