From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0603741B8D; Tue, 31 Jan 2023 11:10:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E4D4641611; Tue, 31 Jan 2023 11:10:22 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 9591D4113C for ; Tue, 31 Jan 2023 11:10:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675159821; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tym9kYilMd5shWiSsZJDzNNqF+amKxD9AniVdicnt8c=; b=frbR48niMgF7SabfnZe2ddcIEl3kSxY+MVHgtm6A25npz9utNe2dgbSOw5F9iyE8lWQIAz Y8iYlfzokS2o7mdpEpHMf84zAgWinYattyOfVmUXKtBmyLRkg3V1T2pOxctRyziVq/Fxy4 8qlWJGOJG36HXxrdvIalU5T+Wy/Jkq4= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-202-5RIFzRilNa69Ux19xzgBGg-1; Tue, 31 Jan 2023 05:10:19 -0500 X-MC-Unique: 5RIFzRilNa69Ux19xzgBGg-1 Received: by mail-pf1-f197.google.com with SMTP id x9-20020aa79409000000b00593a1f7c3d8so3697899pfo.14 for ; Tue, 31 Jan 2023 02:10:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tym9kYilMd5shWiSsZJDzNNqF+amKxD9AniVdicnt8c=; b=dGhD9KstEMt0+OP59QphD+Lcaf6shdnBjWhdf31wbUBflyn30LXrG6Syg5G8/fDUi3 +gqP3GFYpEgncldkD6CFqHwOoET01gxgOmENyx0EHIYRP27gHEBmet3SxQShB2JZJzRG +BcoJrstQWCZdN0ztpoeqRHk70JjvMfAqGeYeUIIF+lVP2OikamLd3BGexySgmSLAy+K IgSkKxw565f7MwTk0/UW0AAZqtkTj9W97VpZyxeBtJfGxkJDvIRvyP1fqasT+iRDfZiY LM+YQpAzeY8JFRfpWwML1x9gR0jag8tQNi162EjEDwCivsFaRHN8bYD01f3XWYUsMpbf XLgw== X-Gm-Message-State: AO0yUKXVRHwIK+60ULeeaL6Yk4O/BEYHxmOFdR7FbCu7U7JI4X7MSESL j62A3wFax+LPGdMAPtKkWfPsXQVsOcywI5cBBIMk1yCw886YNM3OjNBTu6o14E6OYYWm6E9VOhp ux+fSGR6nAmQuwA9SeMk= X-Received: by 2002:aa7:9606:0:b0:593:b0fa:ad95 with SMTP id q6-20020aa79606000000b00593b0faad95mr1465547pfg.48.1675159818695; Tue, 31 Jan 2023 02:10:18 -0800 (PST) X-Google-Smtp-Source: AK7set+/shh8Qj3bCVbSBcYYgjUDqa3fa4awYuNG6BzN+RgWbxL+Qs/nTDAffs7fLCyK7wycXFx4g9/HoysYyNOPbDY= X-Received: by 2002:aa7:9606:0:b0:593:b0fa:ad95 with SMTP id q6-20020aa79606000000b00593b0faad95mr1465541pfg.48.1675159818372; Tue, 31 Jan 2023 02:10:18 -0800 (PST) MIME-Version: 1.0 References: <20230104074051.3420378-1-alvaro.karsz@solid-run.com> In-Reply-To: <20230104074051.3420378-1-alvaro.karsz@solid-run.com> From: David Marchand Date: Tue, 31 Jan 2023 11:10:07 +0100 Message-ID: Subject: Re: [PATCH v3] bus/fslmc: unlock spinlock in case of timeout To: Alvaro Karsz , sachin.saxena@oss.nxp.com, hemant.agrawal@nxp.com Cc: dev@dpdk.org, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jan 4, 2023 at 8:41 AM Alvaro Karsz wrote: > > Bug in function mc_send_command, > A spinlock is not unlocked in case of timeouts. > > Fixes: 79711846f676 ("bus/fslmc: add timeout in MC send command") > Cc: stable@dpdk.org > > Signed-off-by: Alvaro Karsz > Reviewed-by: David Marchand No review from the driver maintainers after a month. The fix seems valid to me. Applied, thanks. -- David Marchand