From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8CF5AA0C4A; Wed, 7 Jul 2021 10:57:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 042F7406FF; Wed, 7 Jul 2021 10:57:44 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 41A02406B4 for ; Wed, 7 Jul 2021 10:57:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625648261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8kFKrC6zjz2Ki5cIqA+6rXxHUGb7FAjQCeK1LGF4Wyc=; b=DG+i9XI9wfOyGr+zFapDe/BJCoJo+alS+sP4ayMFG2bNA3MTzepSoJGJ4xBd8Vw0DHCEMk 2fz1vre/+quVVyOIozFYgy44fd2BfHjhXmr4jmqbU3jgBNQvMH6d5dXH/muQGXCiouSNX2 0i3AED5mogrBV87ZEVl6I1Z8c0OJGgU= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-179-fbgOmxy8NlusAcUO1Sm2OA-1; Wed, 07 Jul 2021 04:57:39 -0400 X-MC-Unique: fbgOmxy8NlusAcUO1Sm2OA-1 Received: by mail-vk1-f199.google.com with SMTP id c17-20020a1f1c110000b0290253e315d9c7so240167vkc.13 for ; Wed, 07 Jul 2021 01:57:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8kFKrC6zjz2Ki5cIqA+6rXxHUGb7FAjQCeK1LGF4Wyc=; b=NTNppPgw93UtHwPRbnAXBk0PYLxudVn9k89ozaWHONvdoo2H8xjrJp04TKxBtGvdZq 2sS4QYLjoV2E0ntGWB44K0AUCs82jf71TF+9KbpsjM9tPGRaAfnLscx1WLoOiw8hRiGs naT7BZdxdfn+9J7cDdH5B8jCsL8SyieLEPX9Cm+nuNvROYXbE/L+qj1HtUGPU2pNvMVa mwm7ZDFO5F2NrIj1WszPTqiHVpz49Pm2OMSTulTEbzQy46MDLXTTvgWDZx+kzPVpokQg MmipVrE9ww+9zRqJuY+PU4KHerdu4NUgxeiIf40Z6ufeY27Ug0tetw4HvZf1ssg+MOui TRMA== X-Gm-Message-State: AOAM532g1XxLDuwLObXxX+u1r2GxwELCQlF3+DgTsgRtb3kf6O6K8/Hv yPzJCA0G2VKl9hH3+fJB9J9aFq4OiTsScp9kaQBqgiIxvcTGiwDtgvIPZqQ0PtC4VxnQt401Po9 3lph8DMLVgdh4tbrdU4c= X-Received: by 2002:ab0:6805:: with SMTP id z5mr7728599uar.87.1625648258880; Wed, 07 Jul 2021 01:57:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxc+Ky2A7rGNzyiJLX/ITP1L8G3pylsbdrYV88WVUUvkwMhVUrY9Vp0AVmmDqdJupkfmthkGCuaBL6fl0aND6E= X-Received: by 2002:ab0:6805:: with SMTP id z5mr7728590uar.87.1625648258617; Wed, 07 Jul 2021 01:57:38 -0700 (PDT) MIME-Version: 1.0 References: <1625231891-2963-1-git-send-email-fengchengwen@huawei.com> <20210706202841.661302-1-bruce.richardson@intel.com> <20210706202841.661302-2-bruce.richardson@intel.com> In-Reply-To: From: David Marchand Date: Wed, 7 Jul 2021 10:57:27 +0200 Message-ID: To: Bruce Richardson Cc: dev , Chengwen Feng , Jerin Jacob , Jerin Jacob , =?UTF-8?Q?Morten_Br=C3=B8rup?= Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [RFC UPDATE PATCH 1/9] dmadev: add missing exports X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jul 7, 2021 at 10:37 AM Bruce Richardson wrote: > > On Wed, Jul 07, 2021 at 10:26:36AM +0200, David Marchand wrote: > > On Tue, Jul 6, 2021 at 10:29 PM Bruce Richardson > > wrote: > > > > > > Export the rte_dmadevices array and the allocate and release functions > > > which are needed by PMDs. > > > > rte_dmadevices[] might be an issue for inline accesses, but pmd > > allocate/release should be internal (driver only). > > > So if I understand correctly, they still need to be in the version.map drivers still need them exported, so yes they must be in version.map with INTERNAL version. > file, but with "interal" versioning rather than "experimental", right? But I would move them too in a separate header, for drivers, like ethdev_driver.h. And the __rte_internal tag will be needed at their declarations. https://git.dpdk.org/dpdk/tree/lib/ethdev/ethdev_driver.h#n1005 https://git.dpdk.org/dpdk/tree/lib/ethdev/version.map#n257 -- David Marchand