From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1288443E04; Fri, 5 Apr 2024 10:59:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8DE42402D4; Fri, 5 Apr 2024 10:59:14 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 6AAED402CE for ; Fri, 5 Apr 2024 10:59:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712307552; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8/W0lw84P9ZZX7XgDrZw6T6nqsfHtWOdxJNeqBLZn5E=; b=Ey0OyASpwWgOVn/YeyJCOyOfl1MhRu7KpUKiSs5g4MU9AFLUbYzO0Vsc70AjiAc45z/HdH 9aFwh45liiAf2Qeh8GLUDSoNHGk8by5wBlTv/MIrfQLLP1MuXxL4AqR/Kr3K6CKvN0CcBa oAQIWT/obHzHvHzOWFrgj4Exr1LgMAI= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-505-4Zb02KeIOuaCftZjhfGSkA-1; Fri, 05 Apr 2024 04:59:11 -0400 X-MC-Unique: 4Zb02KeIOuaCftZjhfGSkA-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2d85b9e7504so12331831fa.1 for ; Fri, 05 Apr 2024 01:59:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712307549; x=1712912349; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8/W0lw84P9ZZX7XgDrZw6T6nqsfHtWOdxJNeqBLZn5E=; b=YalYy9sT+7l0DiJZckSBmIoCU6bdGrgxqwP4e0prmvheNUrRxGG4J0R2d8NQ7QTa8F Te/bLj4sjMDM6Pf7qfwCNcxPWatrqvi19l821etNvhV059uVttjP0elZGN4hZyc1CuTd wvVO+15k28zpwhuLnLwqIndu7OIDpchANDcMb6EcZh7CQl1aKfmGocGiL8eOCp6NbPZH u59vrmcB3JnwgXpnHxnegAaS+mHE4dP3vF2xoJR0eKg3Ah0KZJZRXhHRArOZBHRweadq 6fJl+sjFIqyPuN8TU1oorSOkYEk70nxfhPY/LliGo0R94Bb4K7E8o428PRyfzFlFQscb Ge4w== X-Forwarded-Encrypted: i=1; AJvYcCUKjSDuYfUTx/OzGE+/nfbsIYP2+dkFzgo1qWUK/v+F5sKjGvMt5ppInKcK+9BjRt6i41N53XHd+Y+VTSk= X-Gm-Message-State: AOJu0YxA/JN0uY1zTqVvuZgswTvkM9MIkbVUIhaQFBicTM470JoZq1Co W1732RMNIinsaUWqCOcqYB00P+54WLD6YuV3Vu2/mu5OTIhW0LInJHwguAS9m3f6/xIRWAdU0d6 E7AFETKZ8VNOb0yqfjsF4LPhF3PuZAM4S5XoXA+RkjR3hqVoCv6N7oFUP3Vc11Fp3uPUWj0EGKS +0cCcoKou38WNzQM0= X-Received: by 2002:a2e:9794:0:b0:2d8:6c9f:418 with SMTP id y20-20020a2e9794000000b002d86c9f0418mr324665lji.44.1712307549676; Fri, 05 Apr 2024 01:59:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGr/kB4wgsxMPEVSqoJgOkhsFsAmB8WBNMwpLAhadu7zPBiyQRFPC8bLI7Fud8tRS+dDsldH40WQiOvqaBYX54= X-Received: by 2002:a2e:9794:0:b0:2d8:6c9f:418 with SMTP id y20-20020a2e9794000000b002d86c9f0418mr324656lji.44.1712307549376; Fri, 05 Apr 2024 01:59:09 -0700 (PDT) MIME-Version: 1.0 References: <20240326235909.25276-1-mpazdan@arista.com> <20240403134026.7037-1-mpazdan@arista.com> <20240403164937.GA14169@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <20240405005518.GA27122@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20240405005518.GA27122@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> From: David Marchand Date: Fri, 5 Apr 2024 10:58:57 +0200 Message-ID: Subject: Re: [PATCH] lib: add get/set link settings interface To: Tyler Retzlaff , Dodji Seketeli Cc: Thomas Monjalon , dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Apr 5, 2024 at 2:55=E2=80=AFAM Tyler Retzlaff wrote: > On Thu, Apr 04, 2024 at 09:09:40AM +0200, David Marchand wrote: > > On Wed, Apr 3, 2024 at 6:49=E2=80=AFPM Tyler Retzlaff > > > this breaks the abi. David does libabigail pick this up i wonder? > > > > Yes, the CI flagged it. > > > > Looking at the UNH report (in patchwork): > > http://mails.dpdk.org/archives/test-report/2024-April/631222.html > > i'm jealous we don't have libabigail on windows, so helpful. libabigail is written in C++ and relies on the elfutils and libxml2 librari= es. I am unclear about what binary format is used in Windows... so I am not sure how much work would be required to have it on Windows. That's more something to discuss with Dodji :-). --=20 David Marchand