From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2EBAAA0093; Mon, 11 Apr 2022 13:26:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 041C14068C; Mon, 11 Apr 2022 13:26:11 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id C497440685 for ; Mon, 11 Apr 2022 13:26:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649676368; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=40APSftUlPTUErdXKVaUhqDjkkS946hG7kuQHJT38j0=; b=NhRHLof0GvecqxQOJlFLG2iIhQCY/Y5fZmytseIdhGcajD61oDHdWZUOapxsK/KFIz4ejM FP/+uJl4tJFpJumQei6dpaCiXtEfNJNNFBQhaM2M0GNDUHmPmdRex8OlBZ4AD/nBmr36nO mGANKDR/TGE9jKWYYCTwXek3lLIKX40= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-361-s7PCEsHqOzKFlbgo676stg-1; Mon, 11 Apr 2022 07:26:07 -0400 X-MC-Unique: s7PCEsHqOzKFlbgo676stg-1 Received: by mail-lj1-f197.google.com with SMTP id e3-20020a2e9303000000b00249765c005cso5913342ljh.17 for ; Mon, 11 Apr 2022 04:26:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=40APSftUlPTUErdXKVaUhqDjkkS946hG7kuQHJT38j0=; b=PNdbvhGR9ZsG5Dcp3eRT9T+k24TEdSuMmYzAI6Avqo22/iktgcT0grtC5ADmy5o4xU Ohi4hOeMz30fL2ZzJOEM6RPOVaUuM7i7Uxs+BNE6SHyWnGVxQwS0uTb2uXwT7FEKMetl TsTpr68NAYVqtbowfCaAG/7QOi6FnL/Cny10aeKgl6whDJlgbSjUFtQjdIfkvOzipCKl SRzIBosx2Av8TohHL25EVLC0nbDAOtnVKhSAQrL1Mh3JHmS7n/aMX/1plHWHbipszA0p vDdxfLm2zTBgecYn5HxKodFZ57r3tW4A24cb8lO4GkEwXcNSDI1xpoEykz9U//1fBMhj NDdw== X-Gm-Message-State: AOAM531K2fEZxKi/DZWrj89MpkKCj00RBIM3WAud4e9s1bpCbIiXuYNs SDLBCo5ys5kQ86oBKAYDN7XowqQFBaPHMzVhfsUN+zDV8oGlaKsNV4NjGM7pjnMPM/zy+oLYXzx +n48JronrLqtp/Juc0SA= X-Received: by 2002:a05:651c:179c:b0:247:e1b4:92aa with SMTP id bn28-20020a05651c179c00b00247e1b492aamr20596762ljb.55.1649676365816; Mon, 11 Apr 2022 04:26:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy8VxAwIw9zb1ZduWMDmtIY1TasWpH2Wx8rtw1sQF0wHee9056lRJKtw1rqDfsL88Bsr719hOP92IKjIqt6Ufk= X-Received: by 2002:a05:651c:179c:b0:247:e1b4:92aa with SMTP id bn28-20020a05651c179c00b00247e1b492aamr20596752ljb.55.1649676365596; Mon, 11 Apr 2022 04:26:05 -0700 (PDT) MIME-Version: 1.0 References: <20220410135140.161842-1-mattias.ronnblom@ericsson.com> <20220410135140.161842-3-mattias.ronnblom@ericsson.com> In-Reply-To: <20220410135140.161842-3-mattias.ronnblom@ericsson.com> From: David Marchand Date: Mon, 11 Apr 2022 13:25:53 +0200 Message-ID: Subject: Re: [RFC 3/3] examples/bond: fix invalid use of trylock To: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= Cc: dev , Thomas Monjalon , Honnappa Nagarahalli , =?UTF-8?Q?Morten_Br=C3=B8rup?= , hofors@lysator.liu.se, michalx.k.jastrzebski@intel.com Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, Apr 10, 2022 at 3:53 PM Mattias R=C3=B6nnblom wrote: > > The conditional rte_spinlock_trylock() was used as if it is an > unconditional lock operation in a number of places. > > Fixes: cc7e8ae84faa ("examples/bond: add example application for link bon= ding mode 6") > Cc: michalx.k.jastrzebski@intel.com Any reason not to ask for backport in stable branches? > > Signed-off-by: Mattias R=C3=B6nnblom Otherwise, this series looks good, thanks Mattias. --=20 David Marchand