DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: "Min Hu (Connor)" <humin29@huawei.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] Question about bonding port promiscuous
Date: Wed, 27 Oct 2021 15:47:09 +0200
Message-ID: <CAJFAV8zVsixMRyMuCBPgy371MhDwNqmofJ70TFaO-TvDu5+Fsw@mail.gmail.com> (raw)
In-Reply-To: <84348740-547e-27b0-0553-747bd1e50789@huawei.com>

On Wed, Oct 27, 2021 at 5:21 AM Min Hu (Connor) <humin29@huawei.com> wrote:
>
> Hi, David,
> In function "bond_ethdev_promiscuous_disable",
> for "ROUND ROBIN","BALANCE","BROADCAST","8023AD" mode, Promiscuous mode
> is propagated to all slaves.
>
> While for "ACTIVE_BACKUP", "TLB", "ALB", promiscuous mode is propagated
> only to primary slave.
>
> Why?

From what I remember of the rework I did some time ago, the code was
already doing it and I did not question it.
I guess it mimicks what the Linux kernel bonding driver does.

>
> The second question, for "ACTIVE_BACKUP", when primary active slave
> fails, a different slave becomes active, does the promiscuous mode state
> of former primary should be set to the new primary?

IOW, setting promisc on the link that becomes primary?
If it is not done, it sounds like a bug.


-- 
David Marchand


  reply	other threads:[~2021-10-27 13:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-27  3:21 Min Hu (Connor)
2021-10-27 13:47 ` David Marchand [this message]
2021-10-28  2:08   ` Min Hu (Connor)
  -- strict thread matches above, loose matches on Subject: below --
2021-10-14  2:13 Min Hu (Connor)
2021-10-19 11:52 ` Min Hu (Connor)
2021-10-21 12:58   ` Min Hu (Connor)
2021-10-21 13:39     ` Min Hu (Connor)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8zVsixMRyMuCBPgy371MhDwNqmofJ70TFaO-TvDu5+Fsw@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=humin29@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git