From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2587FA0C47; Wed, 27 Oct 2021 15:47:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A97FC40DDA; Wed, 27 Oct 2021 15:47:24 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id DEFE1407FF for ; Wed, 27 Oct 2021 15:47:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635342443; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ie4bx+vf9uXsJXTW7QJ6kqglkvKIN1Sf7BAg+zzw6Fk=; b=Mrv5F/fZFKmjaXJDaa02SzMooSSJoK8QanrKiv8Q7fAmYfBSwAdzWr7NkMjq+3fD959Flh LoicWPVyjdHg0qEgo5untCFMg/l4Gp8SCXzmYnlarhGelsFLwQCtTvADAQnjXncS2mrpJ3 A8ELnAnL9T9uZJtJzV1QrhTYlfbl4Tg= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-565-_aKZFDRqMp-mCG0jhgUrPg-1; Wed, 27 Oct 2021 09:47:22 -0400 X-MC-Unique: _aKZFDRqMp-mCG0jhgUrPg-1 Received: by mail-lf1-f71.google.com with SMTP id bq29-20020a056512151d00b003ffce2467adso1440608lfb.3 for ; Wed, 27 Oct 2021 06:47:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ie4bx+vf9uXsJXTW7QJ6kqglkvKIN1Sf7BAg+zzw6Fk=; b=dJx9xE0n+g5FfUULDnsePr39jR8/liljilVRXbBNGGNwLK/ZcdcbHbqB24F0fTq8uW LxzgelWESizUjkAVDdpMd5jaPMFWzzcqrP/4VqwcG1mqfNhAiNd+Gu9CxDGBJ0W/5ZA9 4t1QzFXC6/8F0Wlz9p7A6Q//v+sX6jwAzTHgISm7uuFHx/VRoz4tFaGXnaQ4jU3zMep/ 3OB/TTg+PJA+R3ITtM17uE94EUh39XoLdBQOTXftnconiWWm+trH8F0FSEEn8dz0pu2+ 89kJlIWlBHrl1MXS9cmxZMVW3zmOlSW2fOg775b9ZysOE2jkCT5yJ2kq5Eq9rYhFte/K s9wA== X-Gm-Message-State: AOAM532+C0ndz4jlLo6cM37aQ61FI5GLgm223S0XKkmjsQ9JQHGHRCkI 7mXF/03M0aV1cP51nrL3LYEgjPSEnFDSWaDmFXUaXIsLcKmwmbl1erLOaLXq9Fk2+BDDpl0ZV24 XXz24opPlqV1TgKGToqk= X-Received: by 2002:a05:6512:3e11:: with SMTP id i17mr3357514lfv.560.1635342440530; Wed, 27 Oct 2021 06:47:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzaMOZUFnlfH12YxtCHDnl4am9xT08W9JU9pyzrl4SaXDXId4lG+whKAQ3H7WrWCp8Uu2EioZt22l+iOVCHkeE= X-Received: by 2002:a05:6512:3e11:: with SMTP id i17mr3357495lfv.560.1635342440341; Wed, 27 Oct 2021 06:47:20 -0700 (PDT) MIME-Version: 1.0 References: <84348740-547e-27b0-0553-747bd1e50789@huawei.com> In-Reply-To: <84348740-547e-27b0-0553-747bd1e50789@huawei.com> From: David Marchand Date: Wed, 27 Oct 2021 15:47:09 +0200 Message-ID: To: "Min Hu (Connor)" Cc: "dev@dpdk.org" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] Question about bonding port promiscuous X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 27, 2021 at 5:21 AM Min Hu (Connor) wrote: > > Hi, David, > In function "bond_ethdev_promiscuous_disable", > for "ROUND ROBIN","BALANCE","BROADCAST","8023AD" mode, Promiscuous mode > is propagated to all slaves. > > While for "ACTIVE_BACKUP", "TLB", "ALB", promiscuous mode is propagated > only to primary slave. > > Why? >From what I remember of the rework I did some time ago, the code was already doing it and I did not question it. I guess it mimicks what the Linux kernel bonding driver does. > > The second question, for "ACTIVE_BACKUP", when primary active slave > fails, a different slave becomes active, does the promiscuous mode state > of former primary should be set to the new primary? IOW, setting promisc on the link that becomes primary? If it is not done, it sounds like a bug. -- David Marchand