From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5EB743A35; Thu, 1 Feb 2024 11:33:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AFED340EF0; Thu, 1 Feb 2024 11:33:10 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 4FB6040299 for ; Thu, 1 Feb 2024 11:33:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706783588; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jiGGcKmel8CkcIXyxlVgIyg8mWP7tDu6k/nKQEzjF3I=; b=NvOrwJ4WpxeUEfHcHIckbkXdZ8lbhbJurbtx09o5CB7+SUEn96lMfK6yAj+k1sFz9YRJ/k rsEhButqIymPJvkEP3SDDnBcYHnKU8lTQTXbRYOtB5tV0M0tvGKxXZ6fnWhTMD8781tLuf f96wwxaV7F6tdrx3UmtUL0gMGTRVUoE= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-421-cx9CmIiJNkqouoA3JOZEMQ-1; Thu, 01 Feb 2024 05:33:07 -0500 X-MC-Unique: cx9CmIiJNkqouoA3JOZEMQ-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-5102bbe8839so583329e87.3 for ; Thu, 01 Feb 2024 02:33:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706783586; x=1707388386; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jiGGcKmel8CkcIXyxlVgIyg8mWP7tDu6k/nKQEzjF3I=; b=AGrEtqunZxUuQ5tamo9QESFe1Lk4WizJyzOOBI0HLpYIY/AijUAnG22hXAl4Yx2T/p u2jCsAt8I6zE7xCLesu1EIDF693FQaWeSlzsVvmxw7o9uvUvwXPZhdUTd2w5gH03eJyg 7IPhhJdDx/g/4RuAiJ69BUSZr0/6ubmivP/GmXK1G5HanECbSmTgKkJtmeB6vNnj8FKq t4rQTglvFon8ihvWHExZx+SzG91ekd97X94E9HVurZmcdrLqlsmdILEQOhvsLatYra52 gIEMjQd/SkChmL7VS30k56BdkmOgBfxQy3LbfGwn5uoMBRp0AV+6/CxA6nikQnSUYvtq icHA== X-Gm-Message-State: AOJu0Yw7KlxP+0+1Zla+kDITOzV4VdP1UoK0PUBmbE2+Gb7j2mY77Qi2 6gUZhE2B+GEFtdgK0ADIVGvK7fPyX6HKXNhVyA7YCB0xZraMAt/5HdMseAV1PXoZXdYVYssjwlH fJybcXEJHNT7brTX2tM0p5g6xJTW27JQdnLGdvV6GFNkcnOo8diQyA5fLg7BuCGFLr6GWIuYKEt x4Yruzla/Fj0ZvLrc= X-Received: by 2002:a05:6512:23a4:b0:510:1624:d78a with SMTP id c36-20020a05651223a400b005101624d78amr2013186lfv.48.1706783586270; Thu, 01 Feb 2024 02:33:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IHbmd12sdYe48ifREBWDjlhtdUp/aNR3WTnuIX5CjxQc/LutCVDW25jOPq/YoHsXjFNTVHCTSO1ExxDHLLTvOE= X-Received: by 2002:a05:6512:23a4:b0:510:1624:d78a with SMTP id c36-20020a05651223a400b005101624d78amr2013171lfv.48.1706783585974; Thu, 01 Feb 2024 02:33:05 -0800 (PST) MIME-Version: 1.0 References: <20231206112952.1588-1-vipin.varghese@amd.com> In-Reply-To: <20231206112952.1588-1-vipin.varghese@amd.com> From: David Marchand Date: Thu, 1 Feb 2024 11:32:54 +0100 Message-ID: Subject: Re: [PATCH] cfgfile: increase value length To: Vipin Varghese Cc: dev@dpdk.org, cristian.dumitrescu@intel.com, Ferruh Yigit , Bruce Richardson X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Dec 6, 2023 at 12:31=E2=80=AFPM Vipin Varghese wrote: > > The default value for CFG_VALUE_LEN is set to 256 characters. > This limits the parsing for longer strings in configuration file. > Setting the default to 2048 characters increases the value array > size in `struct rte_cfgfile_entry`. > > Files using cfgfile library are > 1. drivers/net/mvpp2/ > 2. app/test-dma-perf/ > 3. app/test/ > 4. examples/qos_sched/ > > The structure `rte_cfgfile_entry` is not included in DPDK libraries. > Modifying from 256 to 2048 allows `app/test-dma-perf/main.c` helps to > parse longer string as shared in https://bugs.dpdk.org/show_bug.cgi?id=3D= 1333 > > Signed-off-by: Vipin Varghese > Suggested-by: Ferruh Yigit > --- > lib/cfgfile/rte_cfgfile.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/cfgfile/rte_cfgfile.h b/lib/cfgfile/rte_cfgfile.h > index 232c65c77b..401353c44e 100644 > --- a/lib/cfgfile/rte_cfgfile.h > +++ b/lib/cfgfile/rte_cfgfile.h > @@ -24,7 +24,7 @@ extern "C" { > #endif > > #ifndef CFG_VALUE_LEN > -#define CFG_VALUE_LEN 256 > +#define CFG_VALUE_LEN 2048 > #endif > > /** Configuration file */ Last time I looked at this code, I had the impression such a change would break the ABI. I see that the discussion stopped at a suggestion to change some parsing lo= gic. For now, I marked this patch as Changes requested. Thanks. --=20 David Marchand