From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5483BA00B8; Mon, 28 Oct 2019 12:05:52 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 315461BEF6; Mon, 28 Oct 2019 12:05:52 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id EA89D1BEEC for ; Mon, 28 Oct 2019 12:05:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572260749; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8MDWfM3BoUjlEnS8hSYzAvXZtThomZ7M5AMnbw6CYQ0=; b=V3MKImfu+yep10NLRXW2JEDNQJvicHWW9QuadHHUML5eBG0sd7Zfw//CEY+Z2yfIk3dkFp l8VtdQG29cdddY9UYlGgysWnbcGjZR6b1tQ47CXtnlIdi9oGrzzEHoMNLdLjZqSyAfeSKg 1SHu1MTveIP9WMXsA071fwA2xRoZrlw= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-157-ly4uo-uYOhKwwu48sFFwtA-1; Mon, 28 Oct 2019 07:05:47 -0400 Received: by mail-vk1-f200.google.com with SMTP id m205so4853217vke.11 for ; Mon, 28 Oct 2019 04:05:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UE/mO7L4LiDnDAVXglBDXMiAaAW1H8u9b3PL0r1j0b8=; b=TSS9lPZl2idTGTaf/zZvxKwD5+TxlrjKK2Vd4j0Z9IkQiRS+RKMVYthkBBBOu3kQvC FebFzpevle3a3Jr3vGAjJ0C9jAyaHXCruyCsMBUz4qs/w4jtUBfNYhZTvGfqC2qMQeB5 QFZSOC2F/zJV5AH6xqZFOKU9zzey1hM2eR0SELm1CCZkaZgC9MqpMUmvekbATHyiaNNo cld3hA4+t6ia3nbZkWYS9+yfMptYUPyR8ik+mAPzN1Onl0RA+MXo8P7LS1E8upEbUoGW eoGICfGKEPiHHXUnRMZ/m27FOsKAbYGcEpzTyRLJV+597UDwi3RYtrJlgMm6llgqfH1x Ha6A== X-Gm-Message-State: APjAAAXbC7tGi3+nbtvq7pOpsXmvE7Uy0wxhcEiBtpx8FM9+/W6jtBGr PG/FctTLU356Ccee5LZxOGuD79zxJybfmWgUcgOH4J/jr6+ZOzgZnSvKDwIkqYS5nVuCWyt9teo GaqIOpMtW9+QEzqWnyDA= X-Received: by 2002:a67:7790:: with SMTP id s138mr4360191vsc.198.1572260747133; Mon, 28 Oct 2019 04:05:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqxK6vxMtEkrwWBJQKoRB+yKmWy80r/VYBxmyXEMsOmDOXxbI+/SiwhaHy+if1FwuDKf4ymNmdAcxY7LyGZHCFo= X-Received: by 2002:a67:7790:: with SMTP id s138mr4360170vsc.198.1572260746667; Mon, 28 Oct 2019 04:05:46 -0700 (PDT) MIME-Version: 1.0 References: <20191028104934.21174-1-thomas@monjalon.net> In-Reply-To: <20191028104934.21174-1-thomas@monjalon.net> From: David Marchand Date: Mon, 28 Oct 2019 12:05:35 +0100 Message-ID: To: Thomas Monjalon Cc: Neil Horman , John McNamara , Marko Kovacevic , Ferruh Yigit , Andrew Rybchenko , dev X-MC-Unique: ly4uo-uYOhKwwu48sFFwtA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] ethdev: remove deprecated port count function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 28, 2019 at 11:50 AM Thomas Monjalon wrot= e: > > The function rte_eth_dev_count() was marked as deprecated in DPDK 18.05 > in commit d9a42a69febf ("ethdev: deprecate port count function"). > It was planned to be removed after 19.11 LTS release, > but given we must not break ABI between 19.11 and 20.11, > it is removed now. > > Note the ABI version is not dumped in this commit > because other changes already did. > > Signed-off-by: Thomas Monjalon > --- > doc/guides/rel_notes/deprecation.rst | 5 ----- > doc/guides/rel_notes/release_19_11.rst | 5 +++++ > lib/librte_ethdev/rte_ethdev.c | 6 ------ > lib/librte_ethdev/rte_ethdev.h | 15 --------------- > lib/librte_ethdev/rte_ethdev_version.map | 1 - > 5 files changed, 5 insertions(+), 27 deletions(-) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/= deprecation.rst > index 4249aab833..c10dc301b2 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -48,11 +48,6 @@ Deprecation Notices > structure would be made internal (or removed if all dependencies are c= leared) > in future releases. > > -* ethdev: The function ``rte_eth_dev_count`` will be removed in DPDK 20.= 02. > - It is replaced by the function ``rte_eth_dev_count_avail``. > - If the intent is to iterate over ports, ``RTE_ETH_FOREACH_*`` macros > - are better port iterators. > - > * ethdev: the legacy filter API, including > ``rte_eth_dev_filter_supported()``, ``rte_eth_dev_filter_ctrl()`` as w= ell > as filter types MACVLAN, ETHERTYPE, FLEXIBLE, SYN, NTUPLE, TUNNEL, FDI= R, > diff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/rel_note= s/release_19_11.rst > index ae8e7b2f09..fdba8af04a 100644 > --- a/doc/guides/rel_notes/release_19_11.rst > +++ b/doc/guides/rel_notes/release_19_11.rst > @@ -333,6 +333,11 @@ API Changes > * ethdev: changed ``rte_eth_dev_owner_delete`` return value from ``void`= ` to > ``int`` to provide a way to report various error conditions. > > +* ethdev: The deprecated function ``rte_eth_dev_count`` was removed. > + The function ``rte_eth_dev_count_avail`` is a drop-in replacement. > + If the intent is to iterate over ports, ``RTE_ETH_FOREACH_*`` macros > + are better port iterators. > + > * event: The function ``rte_event_eth_tx_adapter_enqueue`` takes an addi= tional > input as ``flags``. Flag ``RTE_EVENT_ETH_TX_ADAPTER_ENQUEUE_SAME_DEST`= ` which > has been introduced in this release is used when used when all the pac= kets > diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethde= v.c > index 7743205d38..809da09cfc 100644 > --- a/lib/librte_ethdev/rte_ethdev.c > +++ b/lib/librte_ethdev/rte_ethdev.c > @@ -772,12 +772,6 @@ rte_eth_dev_get_sec_ctx(uint16_t port_id) > return rte_eth_devices[port_id].security_ctx; > } > > -uint16_t > -rte_eth_dev_count(void) > -{ > - return rte_eth_dev_count_avail(); > -} > - > uint16_t > rte_eth_dev_count_avail(void) > { > diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethde= v.h > index c36c1b631f..98b1db8a6e 100644 > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -1653,21 +1653,6 @@ __rte_experimental > int rte_eth_dev_owner_get(const uint16_t port_id, > struct rte_eth_dev_owner *owner); > > -/** > - * Get the total number of Ethernet devices that have been successfully > - * initialized by the matching Ethernet driver during the PCI probing ph= ase > - * and that are available for applications to use. These devices must be > - * accessed by using the ``RTE_ETH_FOREACH_DEV()`` macro to deal with > - * non-contiguous ranges of devices. > - * These non-contiguous ranges can be created by calls to hotplug functi= ons or > - * by some PMDs. > - * > - * @return > - * - The total number of usable Ethernet devices. > - */ > -__rte_deprecated > -uint16_t rte_eth_dev_count(void); > - > /** > * Get the number of ports which are usable for the application. > * > diff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev= /rte_ethdev_version.map > index e59d51648f..4b31668a55 100644 > --- a/lib/librte_ethdev/rte_ethdev_version.map > +++ b/lib/librte_ethdev/rte_ethdev_version.map > @@ -12,7 +12,6 @@ DPDK_2.2 { > rte_eth_dev_callback_unregister; > rte_eth_dev_close; > rte_eth_dev_configure; > - rte_eth_dev_count; > rte_eth_dev_default_mac_addr_set; > rte_eth_dev_filter_supported; > rte_eth_dev_flow_ctrl_get; > -- > 2.23.0 > Reviewed-by: David Marchand --=20 David Marchand