From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70B3DA0093; Fri, 22 Apr 2022 10:14:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 167374067B; Fri, 22 Apr 2022 10:14:55 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id A42A740042 for ; Fri, 22 Apr 2022 10:14:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650615293; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gP2PA/4gMgbEveBSoYv7ImfVtBC/DJdfix1fZt+xte0=; b=gfp1XEDyEWHM7HxW1COQkhe+n1VmNgJdGoyUEFVEzGhlFpwRiYy3/xdPKZ27abfbgFc3Gf lnNp9n3rL0KJaAoD7BhNb+ea4/7n4bri87e6YIsfQemtHggADMAd7mUDsIoEfTNoIW7Dcs LpOoMCSKmvwtZ3FCm95yFbN8FVkWMF0= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-468-7iO9S1fcOPG8fPFDui6z4A-1; Fri, 22 Apr 2022 04:14:51 -0400 X-MC-Unique: 7iO9S1fcOPG8fPFDui6z4A-1 Received: by mail-lf1-f72.google.com with SMTP id x17-20020a19e011000000b004713b5759fcso2858715lfg.20 for ; Fri, 22 Apr 2022 01:14:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gP2PA/4gMgbEveBSoYv7ImfVtBC/DJdfix1fZt+xte0=; b=VbE/Y1nfe1GVMXdcXHdmJRyoFonuPWZMBW9dsNs57XifrH4uTr/+1WHBdktTcxoVuO U7xGLvrOXnJypBo+eQcaJNCfEQ7PcR5jEIKoxp3fOJEZIE0fk8npDWthEfkGfKCYr2kP VEMk62xxqLtlL2qFhyufMOFDx4+lvc8D6zY68WWAVKNPUw8V/5DkZuuWc50IdoCAmL0+ R+XmtvEwIcmdrgqSb709o5ib/rwIDltEUP/cVZuT4SwjeN6xVfQuzKuBcy6gcyXkhb3H kSzNYcnq6muYldR2Umi5CKtlRaZJ0gw8mYwpQjKnjhR+zScD+LTXz9QiXVYSZzuKzH5u vXPQ== X-Gm-Message-State: AOAM532s/0Rn/7I77KlW8tXUUD4byBsvgmaF1w3lXS9Bv/HM4feLTxbJ q6Qx54TfeZU3bXeVNXoEaotbaUSsuH1/Hu5Ev1AhspByNw+SCK1UM3WpskRoT35eaat1o0avIWk WPW5izRcDDKLdVf+SecU= X-Received: by 2002:a05:651c:994:b0:24a:fc47:d6ca with SMTP id b20-20020a05651c099400b0024afc47d6camr2110897ljq.297.1650615290057; Fri, 22 Apr 2022 01:14:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzGg1bTF7iFqF4DeWIrPtyTbgCRcNIFpebxxcs7O9R9ctzekMQyusZ5NJK2bvpjtAEM7TivjXju9aAnasZxzmI= X-Received: by 2002:a05:651c:994:b0:24a:fc47:d6ca with SMTP id b20-20020a05651c099400b0024afc47d6camr2110881ljq.297.1650615289840; Fri, 22 Apr 2022 01:14:49 -0700 (PDT) MIME-Version: 1.0 References: <20220416010747.40714-1-fengchengwen@huawei.com> <20220416010747.40714-3-fengchengwen@huawei.com> In-Reply-To: From: David Marchand Date: Fri, 22 Apr 2022 10:14:38 +0200 Message-ID: Subject: Re: [PATCH 2/3] ethdev: fix memory leak when telemetry xstats To: Bruce Richardson Cc: Chengwen Feng , Thomas Monjalon , ferruh.yigit@xilinx.com, Andrew Rybchenko , Nithin Dabilpuram , Kiran Kumar Kokkilagadda , Sunil Kumar Kori , Satha Rao , dev , Kevin Laatz , Conor Walsh , Ciara Power Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Apr 21, 2022 at 11:04 AM Bruce Richardson wrote: > > We need some minimal testing for telemetry commands. > > > > It could be a test automatically calling all available /ethdev/ > > commands on a running testpmd. > > This test could be really simple, not even checking what is returned. > > It would just try every command sequentially with no parameter first, > > then with port 0 and finally with port 1. > > > > That seems reasonable. However, I'd go a little further and have all > available commands called as an initial sanity check. Then we can use some > heuristics to go further, with the *dev/stats commands or xstats commands > all being called with numeric parameters as you suggest. Ok, lgtm too. Just to be clear, I don't have the time to work on this, so this is open to volunteers. -- David Marchand