From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 884B041BB9; Fri, 3 Feb 2023 09:47:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5530A410D7; Fri, 3 Feb 2023 09:47:40 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 3D4D34014F for ; Fri, 3 Feb 2023 09:47:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675414057; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UJWRxymT4F1tHKjEoGLrEsxFPiVC/FrooDRbDHWWVgo=; b=I+spwPdEv241U/UBAKl0e7pnQQinA4kMqrEJt+JMKbgggQgEkjsYFly47F02PXQbyWrOJV 52TgdQeLUt8FZsjhAt3Ont96cn1w9e0SOnrnCv3r2SoAEyFTxXthWwsOfoerXRklzWp/TJ jsi0U/KNMuc/nTw4EKNtZtXcswL3G8Q= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-479-Ww3Bf1ViMt6bSP_AfUY6KQ-1; Fri, 03 Feb 2023 03:47:36 -0500 X-MC-Unique: Ww3Bf1ViMt6bSP_AfUY6KQ-1 Received: by mail-pl1-f199.google.com with SMTP id m12-20020a1709026bcc00b001963da9cc71so2283017plt.11 for ; Fri, 03 Feb 2023 00:47:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UJWRxymT4F1tHKjEoGLrEsxFPiVC/FrooDRbDHWWVgo=; b=keLHO0/VFjS53kj6FgBAWHvpCMBF0THWcZM1VKgpizUV3r/UjacgkY8qNgeZOrHtTN cl7EZxdWlwfR4hGaRW5usJXmm9YwBA75VpKdsGumSIB7aJxrcad7hGgRJorjC2HZ+hks xFPo0YV6rxPaGocd0hGjs5wL0SeDEYtRQskKmbLTtsu+3jxtLojgkJZkTKcw480W/7Uy 4kmnqR2xwJr+euLmRcTUlUnClqAEDnQkL+AniqE4BnSLgBY1RaWH0HBDo4i5czggIAjM d3ZrCDalg/x8TLluFsw6xi9KSK1ynjM/gUFxUuwgI28Rj0kHOJc49Gl65Od+9Kuy/vE9 8PSw== X-Gm-Message-State: AO0yUKXdscMVHZshxKtXxzzIr1h9PXzbQUMJSgyCVlqoCV+Rkm5tU9FB G4Ltb98un+9oUzzbeIS0XZAclks/7NiwpqczqvHReqHMIeKFrwNrwzKSr8ysoJfVmHcd7abRy46 aPAEHusqVluSPe20+DJk= X-Received: by 2002:a17:90b:181:b0:227:104f:4497 with SMTP id t1-20020a17090b018100b00227104f4497mr1186259pjs.68.1675414055179; Fri, 03 Feb 2023 00:47:35 -0800 (PST) X-Google-Smtp-Source: AK7set/SSkh9XRcR5pbJbFOCuL2QKf13jRfcMgkP+/Bfvlc/07sInKZYGlsqxDGYvSahtZH8MuTP1gU68HseaHmsvBg= X-Received: by 2002:a17:90b:181:b0:227:104f:4497 with SMTP id t1-20020a17090b018100b00227104f4497mr1186249pjs.68.1675414054929; Fri, 03 Feb 2023 00:47:34 -0800 (PST) MIME-Version: 1.0 References: <20230202123021.54416-1-simei.su@intel.com> <20230202123632.56730-1-simei.su@intel.com> In-Reply-To: From: David Marchand Date: Fri, 3 Feb 2023 09:47:23 +0100 Message-ID: Subject: Re: [PATCH v5] net/i40e: rework maximum frame size configuration To: "Yang, Qiming" Cc: "Su, Simei" , "Zhang, Yuying" , "Xing, Beilei" , "Zhang, Qi Z" , "dev@dpdk.org" , "stable@dpdk.org" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Feb 3, 2023 at 9:39 AM Yang, Qiming wrote: > > > > > -----Original Message----- > > From: David Marchand > > Sent: Thursday, February 2, 2023 9:49 PM > > To: Su, Simei ; Zhang, Yuying > > ; Xing, Beilei ; Zhang, Qi Z > > > > Cc: dev@dpdk.org; Yang, Qiming ; > > stable@dpdk.org > > Subject: Re: [PATCH v5] net/i40e: rework maximum frame size configuration > > > > On Thu, Feb 2, 2023 at 2:24 PM David Marchand > > wrote: > > > > > > On Thu, Feb 2, 2023 at 1:37 PM Simei Su wrote: > > > > @@ -2467,8 +2466,16 @@ i40e_dev_start(struct rte_eth_dev *dev) > > > > "please call hierarchy_commit() " > > > > "before starting the port"); > > > > > > > > - max_frame_size = dev->data->mtu + I40E_ETH_OVERHEAD; > > > > - i40e_set_mac_max_frame(dev, max_frame_size); > > > > + max_frame_size = dev->data->mtu ? > > > > + dev->data->mtu + I40E_ETH_OVERHEAD : > > > > + I40E_FRAME_SIZE_MAX; > > > > + > > > > + /* Set the max frame size to HW*/ > > > > + ret = i40e_aq_set_mac_config(hw, max_frame_size, TRUE, false, 0, > > NULL); > > > > + if (ret) { > > > > + PMD_DRV_LOG(ERR, "Fail to set mac config"); > > > > + return ret; > > > > + } > > > > > > Reading this patch again. > > > > > > Returning here seems incorrect as we leave rx/tx queue in started state. > > > Don't we need to jump to tx_err label on error? > > > > There is probably an issue with interrupt handler still being registered too. > > Qi, i40e maintainers, please review this patch carefully, and ping me when it > > is ready so that we can test it at RH. > > > > This change will not break interrupt handler, the second parameter is waiting to complete. Just waiting more time to make sure adminq command execute completed. So that subsequent commands(MTU set) can be executed. > And if you have other issues report at RH system, please report it. If i40e_aq_set_mac_config() fails and we return directly, an interrupt handler is left registered, don't you think it is an issue? In any case, I will wait for the next revision before asking for tests on my side. Thanks. -- David Marchand