From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95F79A0C52; Mon, 25 Oct 2021 13:12:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2022E40E32; Mon, 25 Oct 2021 13:12:14 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 0846E407FF for ; Mon, 25 Oct 2021 13:12:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635160331; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TaTjKCDIyjqDSe9NDDfqlS4tqOUtlZoZXjII4tASnjI=; b=iuM/jaPHYBEV90m2BqM0ryuYxousYfi4/O+SChjzEO7Hz/hWvL6bQ46izKyMSBILqXYSW1 fXK7O1TDJYFISfCkaC8WdILmLzJj46xxlDy77dWAwfBuwkbbH9pPMcCalZD2a4UjQmTBlV 5YV93szZacL0hgRMscOM1TveXND+KTo= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-594-Gr_rWu5UPtuoK1l0lJJryA-1; Mon, 25 Oct 2021 07:12:10 -0400 X-MC-Unique: Gr_rWu5UPtuoK1l0lJJryA-1 Received: by mail-lj1-f198.google.com with SMTP id w15-20020a05651c102f00b00210e84abb08so2580182ljm.12 for ; Mon, 25 Oct 2021 04:12:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TaTjKCDIyjqDSe9NDDfqlS4tqOUtlZoZXjII4tASnjI=; b=zxQ7PDmPDI/C9yDSxToKO1TxUIsMYVuRyC94BTjm4IQTjmdaXQZV8U7Wiwcum5kOWj mdqe3pwIRHo7iftywqL0VNOa5HpQdeks7H8ANrM9z6EMY4hGo0e54vK3GgYxTTqeu6EH GOC1/6ODkgKLCk0k7n+hWHNUpi6X9bIhEs/KCpKFQHuUZxIqCJuxBsBwDBl08VoQwkT2 8OQyle5MFFEI3NKbCrRTpKJ5rtAT8AH4HZ32qSB1U2pnu/PJbW2gE1FXqiWFsDl01KrI mQDzVMZ/41PIUAWuM8kZxgArSoNLm/YwkqSEJGBG6nK8ljWJE4sbxPPClS6aflR7fLsG 8sKg== X-Gm-Message-State: AOAM531Yn4LcJQZr53Wbui2QCUuodXKDNu7R5xOt6+qLy+tGqPT89vS4 EP+8A/KA/ElXKEhKTKDTsGQVIEDrdt53E/Vn/ibcUf08I3/URLRSpK6Z/XLNwstHNl+pfk8WpZU Kij1d5xOeTdpjHjtRBTE= X-Received: by 2002:a05:6512:202a:: with SMTP id s10mr16150028lfs.560.1635160328668; Mon, 25 Oct 2021 04:12:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyro6C0vo+aHxC2GsyuPS3ZfaV+AFgfh8JbKDoxXbP4DUPjt/eKu7arAmAHp7C9wdPRw+MSLDMduQy1Za11gxI= X-Received: by 2002:a05:6512:202a:: with SMTP id s10mr16150014lfs.560.1635160328506; Mon, 25 Oct 2021 04:12:08 -0700 (PDT) MIME-Version: 1.0 References: <20211022204934.132186-1-hkalra@marvell.com> <20211024200449.12024-1-david.marchand@redhat.com> <20211024200449.12024-10-david.marchand@redhat.com> <20211025134932.7be9f0f2@sovereign> In-Reply-To: <20211025134932.7be9f0f2@sovereign> From: David Marchand Date: Mon, 25 Oct 2021 13:11:57 +0200 Message-ID: To: Dmitry Kozlyuk Cc: Harman Kalra , dev , Anatoly Burakov , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v6 9/9] interrupts: extend event list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 25, 2021 at 12:49 PM Dmitry Kozlyuk wrote: > > diff --git a/lib/eal/common/eal_common_interrupts.c b/lib/eal/common/eal_common_interrupts.c > > index 3285c4335f..7feb9da8fa 100644 > > --- a/lib/eal/common/eal_common_interrupts.c > > +++ b/lib/eal/common/eal_common_interrupts.c > [...] > > int rte_intr_fd_set(struct rte_intr_handle *intr_handle, int fd) > > @@ -239,6 +330,12 @@ int rte_intr_efds_index_get(const struct rte_intr_handle *intr_handle, > > { > > CHECK_VALID_INTR_HANDLE(intr_handle); > > > > + if (intr_handle->efds == NULL) { > > + RTE_LOG(ERR, EAL, "Event fd list not allocated\n"); > > + rte_errno = EFAULT; > > + goto fail; > > + } > > + > > Here and below: > The check for `nb_intr` will already catch not allocated `efds`, > because `nb_intr` is necessarily 0 in this case. +1. Thanks Dmitry. -- David Marchand