From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC1F4A00C5; Wed, 16 Feb 2022 09:03:45 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 81DB3410F7; Wed, 16 Feb 2022 09:03:45 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 5F0D94013F for ; Wed, 16 Feb 2022 09:03:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644998623; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WSn3u0KBCB8D606M9hpickC7Fjwhu0V3w+KU9M13G1o=; b=GJ9dK7MQIrwWQHe6v2udu+ctWUoS885K4oLhJpVaP2w+AD0XyDOoXQUdUvpKN0j6Q48qLt 4Xxgq/V6twCSQ+6DzmGzvPNAtO2de3em7a0FH2FdS0hEdKfBdSvYhqHGSQwB+79dZ9gbVO qeyDQNJoEzTidOIYGSRLOjziLqj8ss8= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-21-v7oxMeUBNdm78d3k57Tz9g-1; Wed, 16 Feb 2022 03:03:42 -0500 X-MC-Unique: v7oxMeUBNdm78d3k57Tz9g-1 Received: by mail-lj1-f198.google.com with SMTP id p10-20020a2ea4ca000000b0023c8545494fso616557ljm.2 for ; Wed, 16 Feb 2022 00:03:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WSn3u0KBCB8D606M9hpickC7Fjwhu0V3w+KU9M13G1o=; b=4N/NwSB8bMDwT3lkutSAIfPkD/HW/1WhxMJUo7YcS/rVDWKE4vd+45pqC/7Sz91W7v nbvZZIrdpiABuYZfuoAqao7KpGH4dSJPcJoH0mLNuAR5MbmaopV1Fd8+vR38qhAfgVdh t8pbfxnWqmEY5W8o7ju99ebY/04zaaEksUjbwT/tAo+o18dP8iq0pZ2K9k41hHcUURDC J3zWwkjtNhpH7SIyc8ogVYIhzi4g8/TLOZwvM1JITLRFVkPHHfO7mRhsPsUBHsEV+Ya7 dnGuQ7ip4GZY79CFBLee0zABNr32yjzi1GCXLEXcDXH96/5zClaG7qsgW6LKuXyFzYu2 +b3w== X-Gm-Message-State: AOAM531wdc35IBRbI0bisSyz+CHbZEtf3gEbtCYEXgv1uH8WMJtRJBbh IWhG7mFxFUW2xqBaYoyYnBTu+KGfrqv+mzM1JmdayXYGOnWMDCRpdtrl5z8AR1yYooeJT9ztZut 4zyVsBxkQx8oWJZ2cu/o= X-Received: by 2002:a2e:a171:0:b0:244:c2fc:d1d with SMTP id u17-20020a2ea171000000b00244c2fc0d1dmr1120452ljl.159.1644998620975; Wed, 16 Feb 2022 00:03:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJy+TultkLB9DwaA/sFZkgmWzXGBZbE5+YGYtk5t4F9DvtwnhL9CgPpLgzGRsPWhosUbrDNHobFPeh2Kx/Jq57w= X-Received: by 2002:a2e:a171:0:b0:244:c2fc:d1d with SMTP id u17-20020a2ea171000000b00244c2fc0d1dmr1120436ljl.159.1644998620645; Wed, 16 Feb 2022 00:03:40 -0800 (PST) MIME-Version: 1.0 References: <20220215101853.919735-1-robinx.zhang@intel.com> <3208558.0oRPG1VZx4@thomas> In-Reply-To: From: David Marchand Date: Wed, 16 Feb 2022 09:03:29 +0100 Message-ID: Subject: Re: [PATCH] app/testpmd: format dump information of module EEPROM To: "Zhang, RobinX" , "Yigit, Ferruh" , Thomas Monjalon Cc: "dev@dpdk.org" , "Zhang, Qi Z" , "Li, Xiaoyun" , "Singh, Aman Deep" , "Zhang, Yuying" , "Guo, Junfeng" , "Yang, SteveX" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Feb 16, 2022 at 3:27 AM Zhang, RobinX wrote: > The idea behind this is to monitor the quality of the link in the field during testpmd operations. > It is supported in Linux driver with ethtool command "ethtool -m xxx", but missing in DPDK. > > This feature is requested by customer 6WIND and we have been told this is highly important in production. > 6WIND also mentioned some other customers: NEC, EOLO and Open Systems. > Similar request also received from customer CheckPoint. > > > > > > What do you think to have this as a sample application? > > > > It can be in the directory app/ maybe. > > > > Base on the above background, I'm not sure if customer could accept this feature as a sample application. Rather than add this in testpmd or a sample app, does it make sense to provide this info as a telemetry command? This makes those status information available in any dpdk application. There is a "but" with this proposal. Existing applications might have been calling "eeprom" ethdev API already, and adding such a callback in telemetry could lead to concurrency issues. I see that we have other telemetry callbacks for stats, link status which might already have the issue. -- David Marchand