From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD8D4A04E7; Sun, 1 Nov 2020 22:11:09 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5444E29C6; Sun, 1 Nov 2020 22:11:08 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 5C70028EE for ; Sun, 1 Nov 2020 22:11:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604265064; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oXBikTj3h5/3qm0VvlTSMUACQKp5AKpl3BXy4t0uRjc=; b=GWpDgD3tmG3mGCBIGV6UbWNhPw++IftuIPsveQou13iRURsi3Hx8mJcvWp8hiiWOMPpbJh L0TEaVAWRVw0DwcPjBLpUmSkuN2vUZaCh4l2WnlnYsUHlvxvBtTCLqRX0ZQTM6MuVvkcEe bf74NmkmMSh671xlzkL4R5QHCK6Hoz8= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-356-BDz7g-gQOkqej7-tlqj0RQ-1; Sun, 01 Nov 2020 16:11:02 -0500 X-MC-Unique: BDz7g-gQOkqej7-tlqj0RQ-1 Received: by mail-vs1-f72.google.com with SMTP id e7so4093125vsc.15 for ; Sun, 01 Nov 2020 13:11:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oXBikTj3h5/3qm0VvlTSMUACQKp5AKpl3BXy4t0uRjc=; b=tSqC1ShgeTkscpMV/2owbtUd7ncfWQqCfTCDpxc+DShD9QNrpym7HVwhaBDt/PjTLG gG5mMphnoFuy8GbYWm+bi+EekJXICh3RBX3eUziRrtjvoxlHzwG8LxS07CPrwIzSUm3/ 0jdTdfowB/AqrmPNmUoFlKY4gZWNWSwBPLcMwUG+WEonh/A8FLnzTPIgGlbXUd3d4jmT e9Uri9OOVXhaMeahojn1BE9PwECIV+z8Lf1jZp4ejMVxteLOqtF7j8sT2E7bD+3lVB99 libJYaGT3JThvkWRlIFwK9aZD3tHnjWZN+In35+rkYBnyUJQeHSgw4WcMPYjn6qKPxCr LF0g== X-Gm-Message-State: AOAM532PEleQvARKe5XnAzlsRxQvQsDXCrTxQugtW6kbQvbP++j7i1XG Soe5nt4B38YuVN6HxIOl5zBsN/yISawH60m8yYHQoQH+E8XxxEkF3w3hNnfu/ScG59G0c/qLgsG tPTw/NjyYaviKanUuaiA= X-Received: by 2002:a67:2fca:: with SMTP id v193mr13521876vsv.18.1604265062042; Sun, 01 Nov 2020 13:11:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJyKg2u9sGR+Jw8tPtLWRLiy8prjFd85aX9zLE7p892etg84hv0sAKUfCglzvt0c1xX1vmvW2x6GIuSt3HNkJtw= X-Received: by 2002:a67:2fca:: with SMTP id v193mr13521869vsv.18.1604265061765; Sun, 01 Nov 2020 13:11:01 -0800 (PST) MIME-Version: 1.0 References: <20200612212434.6852-2-timothy.mcdaniel@intel.com> <1604258796-19966-1-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: <1604258796-19966-1-git-send-email-timothy.mcdaniel@intel.com> From: David Marchand Date: Sun, 1 Nov 2020 22:10:50 +0100 Message-ID: To: Timothy McDaniel Cc: dev , Erik Gabriel Carrillo , Gage Eads , Van Haaren Harry , Jerin Jacob Kollanukkaran , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v15 00/23] Add DLB PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Nov 1, 2020 at 8:25 PM Timothy McDaniel wrote: > > The following patch series adds support for a new eventdev PMD. The DLB > PMD adds support for the Intel Dynamic Load Balancer (DLB) hardware. > The DLB is a PCIe device that provides load-balanced, prioritized > scheduling of core-to-core communication. The device consists of > queues and arbiters that connect producer and consumer cores, and > implements load-balanced queueing features including: > - Lock-free multi-producer/multi-consumer operation. > - Multiple priority levels for varying traffic types. > - 'Direct' traffic (i.e. multi-producer/single-consumer) > - Simple unordered load-balanced distribution. > - Atomic lock-free load balancing across multiple consumers. > - Queue element reordering feature allowing ordered load-balanced > distribution. > > The DLB hardware supports both load balanced and directed ports and > queues. Unlike other eventdev devices already in the repo, not all > DLB ports and queues are equally capable. In particular, directed > ports are limited to a single link, and must be connected to a directed > queue. > Additionally, even though LDB ports may link multiple queues, the > number of queues that may be linked is limited by hardware. Another > difference is that DLB does not have a straightforward way of carrying > the flow_id in the queue elements (QE) that the hardware operates on. > > While reviewing the code, please be aware that this PMD has full > control over the DLB hardware. Intel will be extending the DLB PMD > in the future (not as part of this first series) with a mode that we > refer to as the bifurcated PMD. The bifurcated PMD communicates with a > kernel driver to configure the device, ports, and queues, and memory > maps device MMIO so datapath operations occur purely in user-space. > > The framework to support both the PF PMD and bifurcated PMD exists in > this patchset, and is why the iface.[ch] layer is present. > > Major changes in V15 > ==================== > Address comments from David Marchand: > - this patch-set is based on Nov 1, 2020 dpdk-next-eventdev > - fix docs build (doxy-api.conf.in and doxy-api-index.md) > - restore blank line in MAINTAINERS file > - move dlb announcement in release_20_11.rst after ethdev > - use headers = files() for exported meson public headers > - fix a typo in 'add documentation ..." commit message > - use eal version of cldemote > - convert a couple of printfs to LOG messages There are still printf in drivers/event/dlb/pf/dlb_main.c from a grep I did on v15. Why were they kept? + I did not look too much at the PCI code in this file, but I suspect we could factor some of it with librte_pci. > - fix missing "~" in dlb documentation > - delay introduction of _delayed token pop functions to > token pop commit (fixes 8 or so unused function errors) > - all patches build incrementally (gcc), and checkpatches reports > success There is a valid warning on patch 6: http://mails.dpdk.org/archives/test-report/2020-November/164347.html WARNING:REPEATED_WORD: Possible repeated word: 'of' #1493: FILE: drivers/event/dlb/pf/base/dlb_osdep_bitmap.h:364: + * Returns the bitmap's longest contiguous range of of set bits upon success, > - I am not able to run clang locally. If clang errors are still > present I will ask IT to install clang on a build server tomorrow. This time, compilation passed for each patch on my build system (using ./devtools/test-meson-builds.sh, x86, arm, ppc + doc generation). -- David Marchand