From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 19712A00C2; Fri, 9 Dec 2022 09:22:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AFBD240E0F; Fri, 9 Dec 2022 09:22:33 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 48F5D40E03 for ; Fri, 9 Dec 2022 09:22:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670574151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Hy1eS699Bc06Dy1VVADVUCdO7GF9CoF+fTInvuAD7GE=; b=TNfojpxGIhit3gy16bdoJ8YsAp2AGBUo6s4RKM7FfT+YIZjvYqnkMZdYmLM+vYCBzvJmkT ww7WCjSzswqvkg//wo/yDkVASibpRG3RM8LGbxydSznmds+a1GRuraSd1JlI8EKbq+Me0W IjvpuN5zoa5TJLN6QDzJs+T3NAILGpU= Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-3-yZcD5nhBPaaXAykb8eWWXg-1; Fri, 09 Dec 2022 03:22:30 -0500 X-MC-Unique: yZcD5nhBPaaXAykb8eWWXg-1 Received: by mail-pf1-f198.google.com with SMTP id e6-20020aa78c46000000b005772151d489so2861160pfd.15 for ; Fri, 09 Dec 2022 00:22:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Hy1eS699Bc06Dy1VVADVUCdO7GF9CoF+fTInvuAD7GE=; b=Ho2L4f00hkEh7bRmL3Zu29CDrSqKhDvFINoKipmDpzpHqehNKFycPFyusYi7+5/shS +K6/335lX4G4+lu0XSY/59j3knH7g7C2R6/045fEG/yl1/q9kTLbgy5t8PA8zeq52jB/ KJnnxThwEOiLiAClXft5r1RSP/SzcqP1mSesZVCiOz4rMWB+1JVk9uIkWDxroM+PRTGz zmQD9TcpRccFXw2nuZrRpdX+P73DLNrU5gm9GcuezZV5VOu/5Ujy1XdWTboGrHO9UMP0 AUAwW6UIkbsnSfIESGUekql3YZ2b/0/XXzpRLEdDEcz8EPc/8O+mL0Js2CCeV1zD+XSN uwsQ== X-Gm-Message-State: ANoB5pklqisMGIiWxq5JZdC9Yef1iDrp+17cUdg4eVNTYUPc6yfU6pFo 6iBIHB9trxx2CnHyUnUJsNuhybqw3tGMYvq3Vs8sbeHheG9DYQnD51THpc06NE5LLTBjpG/EvRM hA0wiBn7XJJIWUeMEyNE= X-Received: by 2002:a17:902:7688:b0:186:971b:b7e5 with SMTP id m8-20020a170902768800b00186971bb7e5mr94739072pll.54.1670574149401; Fri, 09 Dec 2022 00:22:29 -0800 (PST) X-Google-Smtp-Source: AA0mqf5EQF7iH+H1wqBu/1kAp4PlKvjnTEPphegC84Lwqp0tgEN+AcyjKjNT9TBKDWvu9oh32z/6mp3T6ddAJ+O6dM8= X-Received: by 2002:a17:902:7688:b0:186:971b:b7e5 with SMTP id m8-20020a170902768800b00186971bb7e5mr94739068pll.54.1670574149046; Fri, 09 Dec 2022 00:22:29 -0800 (PST) MIME-Version: 1.0 References: <20221206122341.3046688-1-ferruh.yigit@amd.com> <20221206122341.3046688-2-ferruh.yigit@amd.com> In-Reply-To: <20221206122341.3046688-2-ferruh.yigit@amd.com> From: David Marchand Date: Fri, 9 Dec 2022 09:22:17 +0100 Message-ID: Subject: Re: [PATCH 2/2] devtools: configure source repo to use as ABI reference To: Ferruh Yigit Cc: Thomas Monjalon , Bruce Richardson , dev@dpdk.org, Akhil Goyal X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Dec 6, 2022 at 1:24 PM Ferruh Yigit wrote: > > By default 'test-meson-builds.sh' script clones the repository which the > script is in, and selects a configured branch ('DPDK_ABI_REF_VERSION') > as a reference for ABI check. > > This patch enables selecting different repository to close for reference > using 'DPDK_ABI_REF_SRC' environment variable. > > It is possible to put these variables to 'devel.config' config file, or > provide via command line, like: > ` > DPDK_ABI_REF_SRC=~/dpdk-stable/ \ DPDK_ABI_REF_SRC could be passed as a remote repository. This should remove the need for any "git remote" configuration. $ DPDK_ABI_REF_SRC=https://dpdk.org/git/dpdk-stable DPDK_ABI_REF_VERSION=v22.11.1 ./devtools/test-meson-builds.sh diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh index 406bf4e184..48f4e52df3 100755 --- a/devtools/test-meson-builds.sh +++ b/devtools/test-meson-builds.sh @@ -18,8 +18,8 @@ srcdir=$(dirname $(readlink -f $0))/.. # # - DPDK_MESON_OPTIONS # -# - DPDK_ABI_REF_SRC # - DPDK_ABI_REF_DIR +# - DPDK_ABI_REF_SRC # - DPDK_ABI_REF_VERSION # # - DPDK_BUILD_TEST_EXAMPLES @@ -186,10 +186,14 @@ build () # [meson options] if [ -n "$DPDK_ABI_REF_VERSION" -a "$abicheck" = ABI ] ; then abirefdir=${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION if [ ! -d $abirefdir/$targetdir ]; then - abirefsrc=${DPDK_ABI_REF_SRC:-$srcdir} # clone current sources if [ ! -d $abirefdir/src ]; then - git clone --local --no-hardlinks \ + abirefsrc=${DPDK_ABI_REF_SRC:-$srcdir} + abirefcloneopts= + if [ -d $abirefsrc ]; then + abirefcloneopts="--local --no-hardlinks" + fi + git clone $abirefcloneopts \ --single-branch \ -b $DPDK_ABI_REF_VERSION \ $abirefsrc $abirefdir/src > DPDK_ABI_REF_VERSION=v22.11.1 \ > DPDK_ABI_REF_DIR=/tmp/dpdk-abiref \ > ./devtools/test-meson-builds.sh > ` > > When 'DPDK_ABI_REF_SRC' is not defined, script behaves as it did > previously. > > Other alternative to using 'DPDK_ABI_REF_SRC' variable is adding that > other repo as a new 'remote' to the exiting git repository. -- David Marchand