From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01444A32A2 for ; Fri, 25 Oct 2019 11:36:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 73D991C1DD; Fri, 25 Oct 2019 11:36:53 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 7D3E31C1A8 for ; Fri, 25 Oct 2019 11:36:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571996208; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MK97uxz+4RQybUeDyQe5gdcxcaJPX0Bx0tTo8dDBJMs=; b=QrRnDWuCDFtO3pZ6KzVsHOak/mh4gceTnFtVk+cSJ+zlMxMRtPLohPWR05H4ZVHhhcMori iCKQSJ35Q8lnm94ymq40bFqqnzXMerxNc87/s8wy/7KgftwgBzJSMP3nblsVDaV7VYknwB +GAJk8OJ6bdc0oD53e7wDq3+hQCNoSA= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-225--FVNCoU_NNO9INdRQgkk5g-1; Fri, 25 Oct 2019 05:36:45 -0400 Received: by mail-vk1-f198.google.com with SMTP id n124so546800vkg.13 for ; Fri, 25 Oct 2019 02:36:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Z6Uh5gVs/3tedtMfSvSl+zp//1vbo2qRFRmdKKTsRzM=; b=sNk1j+9ZtdYkZ7WUE2eUufCAijbir/rYKg5ZvjJcp2WWIQDpPT2tVI8EoVcQfsK3We lkiycy34KHqU8qyihPDYRLqz98INMJ3RvMTjava7Z3JolcsIWJFfZbcdporgC3/Hn9Kt 0DzMHZtGVRltTr48ZDRSUJkz1fDt1/qcJWlYO3+E7hbV8yWlWY0/6kD1p29bmjm49xng XxB8ACWMKykaIVF8aNiYOvro7w1yttgNMcmRkK/+4xJtuQs589R2Q0sCj/GG5U2d6n2d b+pvNwBR8t5S4bSTJnh2eBG9+eJyAu3lvAg5T14oRo1Q4cVoHo0mwG6bXumz/bCdVMW9 vWtg== X-Gm-Message-State: APjAAAVYryZrNM446B1oq/czJ0dvWMKy3S3Et+mznLMUd57E+CpBg5EW Po1L6QepZZCajGQ1ozJZaTcnd8/KIuYmF8QC/joV3fLV9QH8MAasn8gHG2w8AF/TRBzhntr3MvW 5qYom+igjfN6jKeB85Gc= X-Received: by 2002:a05:6102:387:: with SMTP id m7mr1416029vsq.105.1571996205165; Fri, 25 Oct 2019 02:36:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqwXLphmaeQ1/Fi6+klEtkRq3JOtHcLzCTHqQt4KZLP4PnWBkQ8gFBDMCzTHeTkM5soEXtakKkePrGfedix23gE= X-Received: by 2002:a05:6102:387:: with SMTP id m7mr1416017vsq.105.1571996204782; Fri, 25 Oct 2019 02:36:44 -0700 (PDT) MIME-Version: 1.0 References: <26384fad6f9afcba9d3311d1bf73e76f4577225d.1563276298.git.anatoly.burakov@intel.com> In-Reply-To: From: David Marchand Date: Fri, 25 Oct 2019 11:36:32 +0200 Message-ID: To: "Burakov, Anatoly" Cc: dev , John McNamara , Marko Kovacevic , Bruce Richardson , Thomas Monjalon X-MC-Unique: -FVNCoU_NNO9INdRQgkk5g-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2 1/2] eal/freebsd: add support for base virtaddr option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 25, 2019 at 11:06 AM Burakov, Anatoly wrote: > > On 24-Oct-19 7:56 PM, David Marchand wrote: > > On Thu, Oct 24, 2019 at 5:18 PM Anatoly Burakov > > wrote: > >> > >> According to our docs, only Linuxapp supports base-virtaddr option. > >> That is, strictly speaking, not true because most of the things > >> that are attempting to respect base-virtaddr are in common files, > >> so FreeBSD already *mostly* supports this option in practice. > >> > >> This commit fixes the remaining bits to explicitly support > >> base-virtaddr option, and moves the arg parsing from EAL to common > >> options parsing code. Documentation is also updated to reflect > >> that all platforms now support base-virtaddr. > >> > >> Signed-off-by: Anatoly Burakov > >> Reviewed-by: David Marchand > >> --- > >> > >> Notes: > >> v2: > >> - Harmonize FreeBSD reattach implementation with Linux > >> > >> doc/guides/linux_gsg/eal_args.include.rst | 6 +++ > >> doc/guides/linux_gsg/linux_eal_parameters.rst | 6 --- > >> doc/guides/rel_notes/release_19_11.rst | 5 +++ > >> lib/librte_eal/common/eal_common_options.c | 38 +++++++++++++++++= + > > > > I was about to apply it, and I realised that the usage() in Linux > > still references the --base-virtaddr option but it was not moved to > > the common code. > > What do you think of this hunk? > > > > diff --git a/lib/librte_eal/common/eal_common_options.c > > b/lib/librte_eal/common/eal_common_options.c > > index 1cdbd35..020f36e 100644 > > --- a/lib/librte_eal/common/eal_common_options.c > > +++ b/lib/librte_eal/common/eal_common_options.c > > @@ -1692,6 +1692,7 @@ static int xdigit2val(unsigned char c) > > " --"OPT_NO_PCI" Disable PCI\n" > > " --"OPT_NO_HPET" Disable HPET\n" > > " --"OPT_NO_SHCONF" No shared config (mmap'd f= iles)\n" > > + " --"OPT_BASE_VIRTADDR" Base virtual address\n" > > "\n", RTE_MAX_LCORE); > > rte_option_usage(); > > } > > diff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/= eal.c > > index ef5dafa..c0aac21 100644 > > --- a/lib/librte_eal/linux/eal/eal.c > > +++ b/lib/librte_eal/linux/eal/eal.c > > @@ -539,7 +539,6 @@ enum rte_proc_type_t > > " --"OPT_SOCKET_LIMIT" Limit memory allocation on > > sockets (comma separated values)\n" > > " --"OPT_HUGE_DIR" Directory where hugetlbfs > > is mounted\n" > > " --"OPT_FILE_PREFIX" Prefix for hugepage filena= mes\n" > > - " --"OPT_BASE_VIRTADDR" Base virtual address\n" > > " --"OPT_CREATE_UIO_DEV" Create /dev/uioX (usually > > done by hotplug)\n" > > " --"OPT_VFIO_INTR" Interrupt mode for VFIO > > (legacy|msi|msix)\n" > > " --"OPT_LEGACY_MEM" Legacy memory mode (no > > dynamic allocation, contiguous segments)\n" > > > > > > Should be OK, i think. The whitespace seems to be slightly off, but > otherwise, looks good. I suppose you mean the inline patch was whitespace damaged :-). I moved this option a bit earlier in the list. Please check and send a fix if you think it is wrong. Applied, thanks. -- David Marchand