From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-f67.google.com (mail-vs1-f67.google.com [209.85.217.67]) by dpdk.org (Postfix) with ESMTP id 51F101F28 for ; Thu, 2 May 2019 15:53:48 +0200 (CEST) Received: by mail-vs1-f67.google.com with SMTP id d8so1414396vsp.2 for ; Thu, 02 May 2019 06:53:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/C90EyKANOnEMbHIXyjn9gwG2nQtlEbJsMQ80gCVRw0=; b=KLfU/mmqiPsm/POn0gm6eOv6RUhU7uZbOt5W5HW7IOnHR68GcwJ0+HKqwSbVdosi0U BIf4FWc+buQV9tIcc5gQ/CnMcFFGexy4L3KZyBIRqGRr33c5AkyFFPO7p7bIH40gcaA2 aN732IEj+bMUw3dkdtcm44RL/UBrUj9WDphctGPjlW3GweeU+xEwlhxJSAYL+u92xLBK hPkctLA9t0p1oMKR1H5/WdAPeTA1gpnNLtIhSwmN4aRecfqR1bDXipmrblZKesyYoYQO +BEuebklEWyqub0VmsC5rJ9BKvx1TEw/6y6hjxdOwU2uxoOXlU7v+oGBvWN9in/NsOSJ Vwng== X-Gm-Message-State: APjAAAV2jS3k35rWbaaJUnedfG2kfkRs972QZVQ5+jKoMSGKxaukZHzp 2aETcI6aN7qEGvnL/ZMtuxeGrvivZSH9T+MAwAMnIQ== X-Google-Smtp-Source: APXvYqyO0R/CoClNylcHyZMXYvdlMkmftPloXpAt4c4N0ngKoveQyJhicx16/dYxjI+Sou+AfmMyix+x1zSArWRuUcc= X-Received: by 2002:a67:7f85:: with SMTP id a127mr2052399vsd.141.1556805227643; Thu, 02 May 2019 06:53:47 -0700 (PDT) MIME-Version: 1.0 References: <20190501195014.2938-1-bruce.richardson@intel.com> <8175150.iIoqqa2Iee@xps> <20190502132433.GC1980@bricha3-MOBL.ger.corp.intel.com> <20190502134632.GE1980@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20190502134632.GE1980@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Thu, 2 May 2019 15:53:36 +0200 Message-ID: To: Bruce Richardson Cc: Thomas Monjalon , dev , dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 0/4] fix warnings with gcc 9 on Fedora 30 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 May 2019 13:53:48 -0000 On Thu, May 2, 2019 at 3:46 PM Bruce Richardson wrote: > On Thu, May 02, 2019 at 03:32:20PM +0200, David Marchand wrote: > > On Thu, May 2, 2019 at 3:24 PM Bruce Richardson > > <[1]bruce.richardson@intel.com> wrote: > > > > On Thu, May 02, 2019 at 02:32:41PM +0200, David Marchand wrote: > > > On Thu, May 2, 2019 at 2:19 PM Thomas Monjalon > > <[1][2]thomas@monjalon.net> > > > wrote: > > > > > > 01/05/2019 21:50, Bruce Richardson: > > > > This set of changes fixes warnings seen when compiling DPDK > > on > > > Fedora 30. > > > > In most cases these warnings appear to be false positives, > > which > > > means we > > > > have the option to just disable the warning. Because the > > changes > > > required > > > > to the code to silence the warnings are fairly small I've > > chosen > > > in all cases > > > > to change the code rather than disable the warnings, but > > I'm open > > > to doing > > > > the opposite if it's felt it's a better solution. [One > > thing I > > > didn't like > > > > about disabling the warnings is that the disabling flags > > are not > > > supported > > > > by clang, so adding them involves compiler checks :-(] > > > > > > > > NOTE: this set does not cover all warnings with GCC9, but > > it does > > > cover > > > > those seen when building with meson. There is still one > > warning > > > disable > > > > flag needed when building with make, which will need a > > follow-on > > > set to > > > > fix. > > > > > > > > Bruce Richardson (4): > > > > net/ixgbe: fix warning with GCC 9 on Fedora 30 > > > > bus/fslmc: fix printf of null pointer > > > > raw/skeleton_rawdev: fix warnings with GCC 9 on Fedora 30 > > > > raw/dpaa2_cmdif: fix warnings with GCC 9 on Fedora 30 > > > Cc: [2][3]stable@dpdk.org > > > Applied, thanks > > > > > > I had a comment on patch 2, and the bigger problem is > > > -Waddress-of-packed-member. > > > The quicker solution for now is to downgrade it to warning only > > so that > > > we can fix the parts later rather than globally disable it. > > > -- > > Well, it is already a warning, it's just that with make we build by > > default > > with -Werror when building from git. > > > > Err, why don't we have -Werror for meson ? > > > > Because it's generally not a good idea to use -Werror by default. However, > the test-meson-build script (which we should all be using for test > compilation before upstreaming) sets it for all builds. > Yes ok, so that old releases still build on newer toolchains. As for the test-meson-builds.sh and test-build.sh scripts, they are still widely unknown except by maintainers. But at least, the ci build script would catch the errors, since it configures with "meson build --werror -Dexamples=all $OPTS" -- David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 518BAA0AC5 for ; Thu, 2 May 2019 15:53:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B07D75F17; Thu, 2 May 2019 15:53:49 +0200 (CEST) Received: from mail-vs1-f67.google.com (mail-vs1-f67.google.com [209.85.217.67]) by dpdk.org (Postfix) with ESMTP id 51F101F28 for ; Thu, 2 May 2019 15:53:48 +0200 (CEST) Received: by mail-vs1-f67.google.com with SMTP id d8so1414396vsp.2 for ; Thu, 02 May 2019 06:53:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/C90EyKANOnEMbHIXyjn9gwG2nQtlEbJsMQ80gCVRw0=; b=KLfU/mmqiPsm/POn0gm6eOv6RUhU7uZbOt5W5HW7IOnHR68GcwJ0+HKqwSbVdosi0U BIf4FWc+buQV9tIcc5gQ/CnMcFFGexy4L3KZyBIRqGRr33c5AkyFFPO7p7bIH40gcaA2 aN732IEj+bMUw3dkdtcm44RL/UBrUj9WDphctGPjlW3GweeU+xEwlhxJSAYL+u92xLBK hPkctLA9t0p1oMKR1H5/WdAPeTA1gpnNLtIhSwmN4aRecfqR1bDXipmrblZKesyYoYQO +BEuebklEWyqub0VmsC5rJ9BKvx1TEw/6y6hjxdOwU2uxoOXlU7v+oGBvWN9in/NsOSJ Vwng== X-Gm-Message-State: APjAAAV2jS3k35rWbaaJUnedfG2kfkRs972QZVQ5+jKoMSGKxaukZHzp 2aETcI6aN7qEGvnL/ZMtuxeGrvivZSH9T+MAwAMnIQ== X-Google-Smtp-Source: APXvYqyO0R/CoClNylcHyZMXYvdlMkmftPloXpAt4c4N0ngKoveQyJhicx16/dYxjI+Sou+AfmMyix+x1zSArWRuUcc= X-Received: by 2002:a67:7f85:: with SMTP id a127mr2052399vsd.141.1556805227643; Thu, 02 May 2019 06:53:47 -0700 (PDT) MIME-Version: 1.0 References: <20190501195014.2938-1-bruce.richardson@intel.com> <8175150.iIoqqa2Iee@xps> <20190502132433.GC1980@bricha3-MOBL.ger.corp.intel.com> <20190502134632.GE1980@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20190502134632.GE1980@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Thu, 2 May 2019 15:53:36 +0200 Message-ID: To: Bruce Richardson Cc: Thomas Monjalon , dev , dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 0/4] fix warnings with gcc 9 on Fedora 30 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190502135336.sSbH8_0hCyaMuSOyocMsW61XZz0fuq_zNy09Jjatkho@z> On Thu, May 2, 2019 at 3:46 PM Bruce Richardson wrote: > On Thu, May 02, 2019 at 03:32:20PM +0200, David Marchand wrote: > > On Thu, May 2, 2019 at 3:24 PM Bruce Richardson > > <[1]bruce.richardson@intel.com> wrote: > > > > On Thu, May 02, 2019 at 02:32:41PM +0200, David Marchand wrote: > > > On Thu, May 2, 2019 at 2:19 PM Thomas Monjalon > > <[1][2]thomas@monjalon.net> > > > wrote: > > > > > > 01/05/2019 21:50, Bruce Richardson: > > > > This set of changes fixes warnings seen when compiling DPDK > > on > > > Fedora 30. > > > > In most cases these warnings appear to be false positives, > > which > > > means we > > > > have the option to just disable the warning. Because the > > changes > > > required > > > > to the code to silence the warnings are fairly small I've > > chosen > > > in all cases > > > > to change the code rather than disable the warnings, but > > I'm open > > > to doing > > > > the opposite if it's felt it's a better solution. [One > > thing I > > > didn't like > > > > about disabling the warnings is that the disabling flags > > are not > > > supported > > > > by clang, so adding them involves compiler checks :-(] > > > > > > > > NOTE: this set does not cover all warnings with GCC9, but > > it does > > > cover > > > > those seen when building with meson. There is still one > > warning > > > disable > > > > flag needed when building with make, which will need a > > follow-on > > > set to > > > > fix. > > > > > > > > Bruce Richardson (4): > > > > net/ixgbe: fix warning with GCC 9 on Fedora 30 > > > > bus/fslmc: fix printf of null pointer > > > > raw/skeleton_rawdev: fix warnings with GCC 9 on Fedora 30 > > > > raw/dpaa2_cmdif: fix warnings with GCC 9 on Fedora 30 > > > Cc: [2][3]stable@dpdk.org > > > Applied, thanks > > > > > > I had a comment on patch 2, and the bigger problem is > > > -Waddress-of-packed-member. > > > The quicker solution for now is to downgrade it to warning only > > so that > > > we can fix the parts later rather than globally disable it. > > > -- > > Well, it is already a warning, it's just that with make we build by > > default > > with -Werror when building from git. > > > > Err, why don't we have -Werror for meson ? > > > > Because it's generally not a good idea to use -Werror by default. However, > the test-meson-build script (which we should all be using for test > compilation before upstreaming) sets it for all builds. > Yes ok, so that old releases still build on newer toolchains. As for the test-meson-builds.sh and test-build.sh scripts, they are still widely unknown except by maintainers. But at least, the ci build script would catch the errors, since it configures with "meson build --werror -Dexamples=all $OPTS" -- David Marchand