From: David Marchand <david.marchand@redhat.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>,
techboard@dpdk.org,
Stephen Hemminger <stephen@networkplumber.org>,
Bruce Richardson <bruce.richardson@intel.com>,
Conor Walsh <conor.walsh@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 0/6] update dpdk-setup.sh
Date: Thu, 26 Nov 2020 17:30:46 +0100 [thread overview]
Message-ID: <CAJFAV8z_HFS_dbmP4QvSoO5E=OrWMSaCikrgQDXiKu8csfPZTA@mail.gmail.com> (raw)
In-Reply-To: <20201126141832.2277628-1-ferruh.yigit@intel.com>
On Thu, Nov 26, 2020 at 3:19 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> This is an effort to update the dpdk-setup.sh script and keep it one
> more year until whole functionality of it is replaced.
>
> Other option is to remove it completely, please comment.
I would simply remove this script.
Binding devices can be done with either driverctl (which is available
in most distributions) and dpdk-devbind.py (which a Howto already in
the doc).
As for permissions, what this script is doing is scary.
I would prefer users don't rely on this:
usertools/dpdk-setup.sh: sudo chmod a+x /dev/vfio
usertools/dpdk-setup.sh: sudo chmod 0666 /dev/vfio/*
OVS uses a udev rule for non root support:
https://github.com/openvswitch/ovs/blob/master/rhel/usr_lib_udev_rules.d_91-vfio.rules
We could describe this in the DPDK documentation.
--
David Marchand
prev parent reply other threads:[~2020-11-26 16:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 14:18 Ferruh Yigit
2020-11-26 14:18 ` [dpdk-dev] [PATCH v2 1/6] usertools/setup: remove make based build Ferruh Yigit
2020-11-26 14:44 ` Walsh, Conor
2020-11-26 14:18 ` [dpdk-dev] [PATCH v2 2/6] usertools/setup: remove inserting custom kernel modules Ferruh Yigit
2020-11-26 14:49 ` Walsh, Conor
2020-11-26 14:18 ` [dpdk-dev] [PATCH v2 3/6] usertools/setup: remove running built applications Ferruh Yigit
2020-11-26 14:55 ` Walsh, Conor
2020-11-26 14:18 ` [dpdk-dev] [PATCH v2 4/6] usertools/setup: remove hugepage functions Ferruh Yigit
2020-11-26 15:01 ` Walsh, Conor
2020-11-26 14:18 ` [dpdk-dev] [PATCH v2 5/6] usertools/setup: fix loading vfio module Ferruh Yigit
2020-11-26 15:05 ` Walsh, Conor
2020-11-26 18:31 ` David Marchand
2020-11-27 9:55 ` Ferruh Yigit
2020-11-27 13:56 ` Thomas Monjalon
2020-11-27 15:29 ` Ferruh Yigit
2020-11-26 14:18 ` [dpdk-dev] [PATCH v2 6/6] usertools/setup: move removal target to 21.11 Ferruh Yigit
2020-11-26 15:13 ` Walsh, Conor
2020-11-26 16:30 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8z_HFS_dbmP4QvSoO5E=OrWMSaCikrgQDXiKu8csfPZTA@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=conor.walsh@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stephen@networkplumber.org \
--cc=techboard@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).