From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0184845BD6; Fri, 25 Oct 2024 15:21:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AB1DB4027E; Fri, 25 Oct 2024 15:21:19 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id AFAB04021F for ; Fri, 25 Oct 2024 15:21:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729862477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KsKQ2N9JZ6jS7brh1TXlA3caIs7T12J5Z2+S07VHIgQ=; b=SKg8XsGrWw9ycIrCzCO/Yb/lhC62tccMZICa6WiOkz2w4X6K0mczQA9vbP0iuXMoMYnZvu kpKPO3KpBnVm8OmU8rjSfd/KDT2IZoyiuE4QKSHEOz4wiJdkAJt82DTnKSQCc1HOYr66Yq 3GCyaQk1zH2QkbxeMtYXe8lHphzXLfk= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-317-Wzjd6u9TMZOK8a2v01ZnEw-1; Fri, 25 Oct 2024 09:21:16 -0400 X-MC-Unique: Wzjd6u9TMZOK8a2v01ZnEw-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2fb4e2da8baso15986081fa.0 for ; Fri, 25 Oct 2024 06:21:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729862474; x=1730467274; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KsKQ2N9JZ6jS7brh1TXlA3caIs7T12J5Z2+S07VHIgQ=; b=Gu1+LtsiJC19ScSApa4hJ4aJ8iakIxV2oVTfODMSQPoLpJIWTdBWEEI35hLXvJ5t2/ tVSWo62oZtmqtFHT26Sx3cwFIgg2zAok9y0obv17FhJEl1GdpCOSLTnQwToC52RK3i2x 0ka55tZJjYmPJguV7kUpVc2Afo8iQhdVx3TaFaqZfh6QT1Hpd3CRcGPFUIiCnn+XVVQF Lcq6HVY4lrKcxwCQ8rk8EXTFG9KFloSU+tCV4W/YFqnqdJWaxO22reBeyWJ4/bTcC9Hw /ME9Wej1o35WskleH/QsBa1P86Zh07Znf6Ypepb4J6NTclh5LIbGaCF0nywObhU3St8W M10Q== X-Gm-Message-State: AOJu0YwCUzRW7H8GbgmmnFEUgRAWZBhlUGhp4oopVIl3h0fiC7rbS3Sh OLHiuoGKxoFRT8lC8h2FSx2oRMoLWsMT35XxuOtd0pURMHH/IeykvAWCuarI85OTwBlv4vk8Rz3 n3THPFCX/q9sovGHO4pY4QIm++D1K7V9XdIWISsold1p8hxSh9j5ssns8oHlEho4QVl3PpHfKss 6b6SMWOTeail6bOcs= X-Received: by 2002:a2e:e02:0:b0:2fb:5504:7966 with SMTP id 38308e7fff4ca-2fca8264827mr25406191fa.30.1729862474384; Fri, 25 Oct 2024 06:21:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHPuEiHFziQ2s18bWUR3j+HNXjx/G1gsSPWatpZvEv1bWOcZI9SGxOS0ggxA7VRBhUr6xa6JH/6Vh109e/awNE= X-Received: by 2002:a2e:e02:0:b0:2fb:5504:7966 with SMTP id 38308e7fff4ca-2fca8264827mr25405971fa.30.1729862473800; Fri, 25 Oct 2024 06:21:13 -0700 (PDT) MIME-Version: 1.0 References: <20241025122746.1775593-1-bruce.richardson@intel.com> In-Reply-To: <20241025122746.1775593-1-bruce.richardson@intel.com> From: David Marchand Date: Fri, 25 Oct 2024 15:21:02 +0200 Message-ID: Subject: Re: [PATCH] net/i40e/base: fix invalid log format characters To: Bruce Richardson Cc: dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Oct 25, 2024 at 2:28=E2=80=AFPM Bruce Richardson wrote: > > With commit cb593a832630 ("net/i40e/base: reduce size of time > variables"), the time_left value is 32-bits rather than 64-bits. > However the printf-style format strings were never updated in the logs, > so were left at PRIu64. Change them to PRIu32, fixing the build when > additional format warnings were enabled. > > Fixes: cb593a832630 ("net/i40e/base: reduce size of time variables") > > Signed-off-by: Bruce Richardson Reviewed-by: David Marchand I'll wait for the CI then apply it directly in main. Btw, I tested this patch after removing following options: $ git diff diff --git a/drivers/net/i40e/base/meson.build b/drivers/net/i40e/base/meson.build index d94108629b..ffe264a934 100644 --- a/drivers/net/i40e/base/meson.build +++ b/drivers/net/i40e/base/meson.build @@ -12,8 +12,6 @@ sources =3D [ ] error_cflags =3D ['-Wno-sign-compare', '-Wno-unused-value', - '-Wno-format', '-Wno-format-security', - '-Wno-format-nonliteral', '-Wno-strict-aliasing', '-Wno-unused-but-set-variable', '-Wno-unused-parameter', ] and it builds fine on my f39. The -Wformat-security caught my eye especially, because net/i40e is the only driver silencing this warning while the whole DPDK tree is built with it. --=20 David Marchand