From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 439A0431A6; Thu, 19 Oct 2023 09:09:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1BD0640263; Thu, 19 Oct 2023 09:09:03 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id C12354021F for ; Thu, 19 Oct 2023 09:09:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697699340; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ndeho7fnaKIiN+GywXg6bSrtYZlKY0VrAG6j4XO47iM=; b=VDBuAagO9wm/I1CRpTcYDei7NwQiK17Ap+z/w0jp6wFheSTBB+t56X7DOhZkeuREfF5fzV msvK7PX66mdLKz97u/nn4E7Rp34t4qx/rsIUd+e/a1KQ4jSvGa8PgZb6YGgzHNi2/ZNQv/ Vop4kEzJuFHykHjegbrA7bLmEK8bvvM= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-108-vjHpkqdwOxWg3Yp5XBuEzg-1; Thu, 19 Oct 2023 03:08:58 -0400 X-MC-Unique: vjHpkqdwOxWg3Yp5XBuEzg-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2c50257772bso68514511fa.3 for ; Thu, 19 Oct 2023 00:08:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697699337; x=1698304137; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ndeho7fnaKIiN+GywXg6bSrtYZlKY0VrAG6j4XO47iM=; b=Asw1hXOoNp3XJ/WGxD7aUZFvmHQhbdfmsOiWa95X5SZHsb9mXprKqdMwglKYiERJTE uEZQzq59kxw5fcYxDRu22WilX/uMYRLLINFTSr3tFmcxfGBcJr1QL1pQURheZY3oruVg u+y1c8WhoWvLGWK9EEoa15RR4XcB6S2bQkquTXGpuP+45NToIU3pe1fCzMPKZh5o356w 856xvc8zDF0H2LUSS1Z29YCKVI5Yx6iIvbmuntiDFdgZmSK0t0DfWLF0d5i0fkl+t8V0 yVe/7W3LjqA83XBF8hrMIob3ykNFDy5y+2xpIMlL1nLcQlxbt07OqcK12ZK6fHWUPJoZ FGFg== X-Gm-Message-State: AOJu0YxxRKW3VV7jaX5vkv5IQkoN+NBRO6LdGIzMs3Yq8Et0x6IOqzG3 9y2dLA/qWUod/mlBRfJM59B+zqFjsHHbzpUx9DgRXr+Figl+lll7eWQnSf666/J8VmGUUUTVfkj wfvnGF86VLYxaP6Clw8k= X-Received: by 2002:a2e:8ecc:0:b0:2c5:115c:2d33 with SMTP id e12-20020a2e8ecc000000b002c5115c2d33mr767801ljl.3.1697699337319; Thu, 19 Oct 2023 00:08:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFCR8maWpWyhAAEqqO4dVKCfjA3KYkUbeDFKmcLW2Lwq7hMGTG2uYyiOyHrMjyo3C9nSs//J4taEJCPjKGkMc4= X-Received: by 2002:a2e:8ecc:0:b0:2c5:115c:2d33 with SMTP id e12-20020a2e8ecc000000b002c5115c2d33mr767791ljl.3.1697699336985; Thu, 19 Oct 2023 00:08:56 -0700 (PDT) MIME-Version: 1.0 References: <20231017113125.2990147-1-david.marchand@redhat.com> <20231017113429.GA23126@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20231017113429.GA23126@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> From: David Marchand Date: Thu, 19 Oct 2023 09:08:45 +0200 Message-ID: Subject: Re: [PATCH] devtools: extend check on compiler builtin atomics To: David Marchand Cc: Tyler Retzlaff , dev@dpdk.org, thomas@monjalon.net X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 17, 2023 at 1:34=E2=80=AFPM Tyler Retzlaff wrote: > > On Tue, Oct 17, 2023 at 01:31:25PM +0200, David Marchand wrote: > > rte_memory_order_* should be used when calling the new stdatomic API. > > Add a check on __ATOMIC_* tokens. > > > > Signed-off-by: David Marchand > Acked-by: Tyler Retzlaff > [snip] > > -v RET_ON_FAIL=3D1 \ > > - -v MESSAGE=3D'Using __atomic_xxx built-ins, prefer rte_at= omic_xxx' \ > > + -v MESSAGE=3D'Using __atomic_xxx/__ATOMIC_XXX built-ins, = prefer rte_atomic_xxx' \ > > Not sure if it should say prefer rte_atomic_xxx/rte_memory_order_xxx ? Looks ok to me, I did this small change while applying. Applied, thanks. --=20 David Marchand