From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 38F32A0471
	for <public@inbox.dpdk.org>; Tue, 13 Aug 2019 11:57:59 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id B84241B952;
	Tue, 13 Aug 2019 11:57:57 +0200 (CEST)
Received: from mail-vk1-f195.google.com (mail-vk1-f195.google.com
 [209.85.221.195]) by dpdk.org (Postfix) with ESMTP id 826741B952
 for <dev@dpdk.org>; Tue, 13 Aug 2019 11:57:56 +0200 (CEST)
Received: by mail-vk1-f195.google.com with SMTP id z67so1126201vkd.5
 for <dev@dpdk.org>; Tue, 13 Aug 2019 02:57:56 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=vVHleQa9QzEcah6OwohchAK9fQcuZCgEoSAnzdAQuAw=;
 b=U3AV7JaQhbfRtxJRYPJGSJroMPs3bPNvpKO8bFz6XEAdXsMBOKuEf26TtAcQRYmY6M
 XrLkqouxqutF931lSsG7bgZgJTxvQyMzm7fQtU78I7zFRdITyuMmhI3hYhQEJneRUEr6
 veHr6A1uFa09+ZydjaIXqaAC7/3/n2INnxr1TMqYma3uyDqq5uIaEdMXIKidFv6QJpLs
 FTBq78YaP/Kgc0xsXBYEpfWpyBA5RL7xnMLRN/pqyNXUZ2cZffpMAxplT4HBX+9tHger
 omLr4wFp71EGqusr6qC4JCKpUL2vCJabkfLdDL2hkZXmzvBkcCHeUzhPh8PzrZmjer08
 LD/Q==
X-Gm-Message-State: APjAAAXMmqvgHeCYwIKegKOXYPn0+mbi89gVlHkqKFOSJKVK7EgXW7TT
 wqXrrRcqY1hRlln7IJI4mIlLR4LCcrDiCf1SDIjImw==
X-Google-Smtp-Source: APXvYqxtJJmQVIeKvTrwbL90g/gmk/lL+SmT3+r2JtiUWPn8NJFLNO3hUZ/XMguXEuXQmvc52xjzoKF7P+YeDn0t9Xs=
X-Received: by 2002:a1f:50c1:: with SMTP id e184mr14009875vkb.86.1565690275723; 
 Tue, 13 Aug 2019 02:57:55 -0700 (PDT)
MIME-Version: 1.0
References: <1565665572-65495-1-git-send-email-haiyue.wang@intel.com>
 <1565665572-65495-2-git-send-email-haiyue.wang@intel.com>
 <20190812202436.662e6ca8@hermes.lan>
In-Reply-To: <20190812202436.662e6ca8@hermes.lan>
From: David Marchand <david.marchand@redhat.com>
Date: Tue, 13 Aug 2019 11:57:44 +0200
Message-ID: <CAJFAV8z_hq95=Rt8Hw9xHcWOuUOvMs+Jh=fBTgRZakyg90Oocw@mail.gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
 Haiyue Wang <haiyue.wang@intel.com>
Cc: dev <dev@dpdk.org>, Neil Horman <nhorman@tuxdriver.com>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [RFC v2 1/3] ethdev: add the API for getting trace
	information
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Aug 13, 2019 at 5:24 AM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Tue, 13 Aug 2019 11:06:10 +0800
> Haiyue Wang <haiyue.wang@intel.com> wrote:

> >  int rte_eth_tx_queue_info_get(uint16_t port_id, uint16_t queue_id,
> >       struct rte_eth_txq_info *qinfo);
> >
> > +int
> > +rte_eth_trace_info_get(uint16_t port_id, uint16_t queue_id,
> > +     enum rte_eth_trace type, char *buf, int sz);
> > +
>
> You didn't run checkpatch, otherwise you would have seen complaints
> about not listing API as experimental.

The checks in checkpatches.sh won't catch this.
But trying to build dpdk as a shared library will.

Example: https://travis-ci.com/david-marchand/dpdk/jobs/224737320


-- 
David Marchand