From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 32891A053A; Wed, 5 Feb 2020 11:58:28 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 16FEA1C136; Wed, 5 Feb 2020 11:58:27 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 1E84A1C12A for ; Wed, 5 Feb 2020 11:58:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580900304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4HWLjAKAkk+vYYFHxfJAyHM3cV8OOHw56lxxEQBlewU=; b=VvCvmyZ3/vKbfSsyftwbX5/TSiybgaOekiNIe20pd/mXcVhISZdFc1knr4JGIRXlpYd/xf 5mdqpUtIy35sw9N++GXoLoWd2D8q3FMKKu0g0M/IrV5WlSHWMm0W0Rpj/Xk1zTTdcUjsgb VCuxN6asXuD0Qaiw4HiynoN5Lj8k7Jc= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-268-x8IuNGNWPl2rIR3tJZXpLQ-1; Wed, 05 Feb 2020 05:58:20 -0500 Received: by mail-ua1-f69.google.com with SMTP id a30so506223uae.6 for ; Wed, 05 Feb 2020 02:58:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OK0TH9Cf7YYq8F1U7MytC+P3b0uw/d6SZv+8Pjn0Y3Q=; b=Zrr2zmT9lvQlpmhvaAOxAXhjBJEmdKZ8K/gHc3j4EfTvnqYBemMB34V2JlhfXuzfid drNrNYyNFUnZVq7Vh/9AmcVbmduVF41GLLNISdhCGdGHBDIcbm9xpTf7uohf9hGuswux Af+lDW0oOxBZH8yyfN2gr81m/3W0KYvzvyl5i49264OboWq8QYUS9A4xndM8QLqAAn9g X5MUzbABSjbOITS15pfs4vrawWikyzFfaZxEJ7H/xWUbAJrt7TfwHFeoG7AH+w8I6gNq ZfS2mz/Y7f3INn0ssA01DJzcacAvhQM89CJTbgMvfU53aLrXXdbWrCa/hSKhXLqv42ys nAjg== X-Gm-Message-State: APjAAAVIgdyuNc9K8cDoxWYp6r7k3OqOPIsOaC7tbThyzStzep8+L5My uQsTsWGyfAoGP/WodfK4SkXEt75qScqk2a4ERZp7C77ngPeFUyu1WcIQbIrD2I5BKYMa6jo7Sr9 bygP4QIAKm5izSTvozbA= X-Received: by 2002:a1f:fe4e:: with SMTP id l75mr1184491vki.18.1580900299543; Wed, 05 Feb 2020 02:58:19 -0800 (PST) X-Google-Smtp-Source: APXvYqw8MheKk4RruBI2CP/s3VG9EeipZl91G1MPCeSRtSR8eSB61AXsSLnR88Nw2nr48oeW2ydV0oQEP9IuBPnTZDw= X-Received: by 2002:a1f:fe4e:: with SMTP id l75mr1184479vki.18.1580900299238; Wed, 05 Feb 2020 02:58:19 -0800 (PST) MIME-Version: 1.0 References: <20200204160309.64827-1-ciara.power@intel.com> In-Reply-To: <20200204160309.64827-1-ciara.power@intel.com> From: David Marchand Date: Wed, 5 Feb 2020 11:58:08 +0100 Message-ID: To: Ciara Power Cc: Bruce Richardson , dev , Pawel Modrak , dpdk stable X-MC-Unique: x8IuNGNWPl2rIR3tJZXpLQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] examples/ioat: fix unchecked return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Feb 4, 2020 at 5:13 PM Ciara Power wrote: > > The function call to get the device info can return negative values on > failure, which was previously unchecked. This return value is now > checked and the function exits on failure. > > Coverity issue: 350361 > Fixes: c8e6ceecebc1 ("examples/ioat: add new sample app for ioat driver") > Cc: pawelx.modrak@intel.com > Cc: stable@dpdk.org We had the same patch proposed in 19.11 timeframe that got deferred to 20.0= 2. https://patchwork.dpdk.org/patch/63375/ Will mark https://patchwork.dpdk.org/patch/65563/ as rejected. Besides, we have a patch with the exact same subject than this one. https://patchwork.dpdk.org/patch/65562/ A title must (briefly) describe what functional impact the patch has. --=20 David Marchand