From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 891CBA0573; Wed, 19 Oct 2022 10:28:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 31E4540A8B; Wed, 19 Oct 2022 10:28:50 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 783424069C for ; Wed, 19 Oct 2022 10:28:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666168127; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=chbuNThrZ7tA3B+/4Y2uN2myinJCdsAApenQFE51x8w=; b=hx8ZF07sX6MV2O+5aVVUpNLkTAtJhqs1Suf1CiaMJ8Pn/78g88kvQn5blVmAtbKPBT8UXQ r4Xuf+10Uk717tpUzxDfZqU5JGsA8gkhdgb1hrAW0s8MTCxZ4FG4NxOHOhTpsZPzt4H0AT g4T19dugGc3T0jz201+KoLNAkHYVuzE= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-520-XMlCzGLGNKKWuU3Ab9QWpw-1; Wed, 19 Oct 2022 04:28:46 -0400 X-MC-Unique: XMlCzGLGNKKWuU3Ab9QWpw-1 Received: by mail-pj1-f72.google.com with SMTP id 88-20020a17090a09e100b00208c35d9452so8080603pjo.6 for ; Wed, 19 Oct 2022 01:28:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=chbuNThrZ7tA3B+/4Y2uN2myinJCdsAApenQFE51x8w=; b=DZubx4cdeEIMJaRF4dwxwmxBsnxSk5UvneTRKWkBrvynFtect4yImg0KdoekHWuuFC rWc9Ty+wS/0OLMMJyYcGZKrngkKdhQw/UUqPbwR/ohJXCrTR161sW94f2HwMTTXdec6c LEQPSwLhZZK+0tGRmgAk7drBrnqCgpxX3kWKhPKCh2yYgy2zFty5M+RSZ9wDn2sJsesK kEz7yx2DAHSS2J0yru4Tr9yqbGccxF/Y9mcsJX1gD90C1mWWFw7hcwW9avzxHdA7DYte PKxY1qE29PBkutDHfIf/1lN+OVzByN3AwHslsF/oysJGnZSpejzevmwz1LC4t8sTPRhG sJrA== X-Gm-Message-State: ACrzQf1+JSrnfEZw/D3HvJWkh8eV3ii6AQ8chOV1woSOUw7uGGZJgZZx 871JbHnJ+YK9RWLNiZnYo5h05epeWGs8uV2D6UmXyA9Q1aP3/ykxfoPV+vOd7EtFo/+E6tqH1X7 UZtcUi+vYmyMPATV434U= X-Received: by 2002:a17:90a:428e:b0:205:d5fe:e0b3 with SMTP id p14-20020a17090a428e00b00205d5fee0b3mr8341364pjg.33.1666168125512; Wed, 19 Oct 2022 01:28:45 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5GB6cQui1Mh7Il9XlzZsyd1QLrOXQUBEWNP6XoCaxMJqVCuPOeWGom61aM54MiXZUPWPg1ZfATurj2fwimgCE= X-Received: by 2002:a17:90a:428e:b0:205:d5fe:e0b3 with SMTP id p14-20020a17090a428e00b00205d5fee0b3mr8341344pjg.33.1666168125181; Wed, 19 Oct 2022 01:28:45 -0700 (PDT) MIME-Version: 1.0 References: <20221013074928.3062458-1-david.marchand@redhat.com> <98CBD80474FA8B44BF855DF32C47DC35D87411@smartserver.smartshare.dk> <98CBD80474FA8B44BF855DF32C47DC35D87415@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87415@smartserver.smartshare.dk> From: David Marchand Date: Wed, 19 Oct 2022 10:28:33 +0200 Message-ID: Subject: Re: [PATCH] trace: take live traces via telemetry To: =?UTF-8?Q?Morten_Br=C3=B8rup?= Cc: bruce.richardson@intel.com, dev@dpdk.org, Jerin Jacob , Sunil Kumar Kori , Ciara Power X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 19, 2022 at 10:21 AM Morten Br=C3=B8rup wrote: > > > It seems to me that these values are Boolean, and should be true or > > false (not surrounded by quotation marks), instead of some string > > representing a Boolean value. Note: This would require expanding the > > telemetry library with a Boolean type. > > > > Indeed. > > > > > > > > Alternatively, use integer values 0 or 1. > > > > > > If we want to represent Boolean values as strings, I vote for "TRUE" > > and "FALSE", using all upper case to indicate that they are magic > > strings - and also to help avoid confusion with the JSON true/false > > Boolean values, which are all lower case. > > > > Introducing those strings is confusing, especially if we later > > introduce the boolean type. > > I had a quick try and adding the boolean type is relatively easy (I > > just posted a patch, see > > https://patchwork.dpdk.org/project/dpdk/patch/20221019073702.3948624-1- > > david.marchand@redhat.com/). > > > > I would either go with adding this new type (though we are past rc1, > > this addition is self contained and low risk), or use simple integers. > > +1 to adding this new type. > > It might be wider ranging, though: > > Are other existing telemetry data in fact Boolean, but currently using so= me other type, and should switch to using the new Boolean type too? I wondered about the same :-) but I did not check, for now. --=20 David marchand