From: David Marchand <david.marchand@redhat.com>
To: Daniel Gregory <daniel.gregory@bytedance.com>
Cc: Stanislaw Kardach <stanislaw.kardach@gmail.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Tyler Retzlaff <roretzla@linux.microsoft.com>,
dev@dpdk.org, Liang Ma <liangma@liangbit.com>,
Punit Agrawal <punit.agrawal@bytedance.com>,
Sachin Saxena <sachin.saxena@nxp.com>
Subject: Re: [PATCH 0/2] eal/riscv: implement prefetch using zicbop
Date: Fri, 12 Jul 2024 19:22:35 +0200 [thread overview]
Message-ID: <CAJFAV8zatWiYQoe4kETcM61=OS1k=QaPRsNjYSYDspKC+voiQw@mail.gmail.com> (raw)
In-Reply-To: <20240530171948.19763-1-daniel.gregory@bytedance.com>
Hello,
On Thu, May 30, 2024 at 7:21 PM Daniel Gregory
<daniel.gregory@bytedance.com> wrote:
>
> Instructions from RISC-V's Zicbop extension can be used to implement the
> rte_prefetch* family of functions. On modern versions of GCC (13.1.0+)
> and Clang (17.0.1+), these are emitted by __builtin_prefetch() when the
> extension is present.
>
> In order to support older compiler versions, this patchset manually
> emits these instructions using inline assembly. To do this, I have added
> a new flag, RTE_PREFETCH_WRITE_ARCH_DEFINED, that
> (similarly to RTE_WAIT_UNTIL_EQUAL_ARCH_DEFINED) hides the generic
> implementation of rte_prefetch*_write.
>
> I am still in the process of acquiring hardware that supports this
> extension, so I haven't tested how this affects performance yet.
Let's hope you get such hardware by the next release.
We will need reviews too.
CC: Sachin.
--
David Marchand
prev parent reply other threads:[~2024-07-12 17:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 17:19 Daniel Gregory
2024-05-30 17:19 ` [PATCH 1/2] eal: add flag to hide generic prefetch_write Daniel Gregory
2024-05-30 17:19 ` [PATCH 2/2] eal/riscv: add support for zicbop extension Daniel Gregory
2024-05-31 8:49 ` Daniel Gregory
2024-10-05 1:31 ` Stephen Hemminger
2024-10-07 7:48 ` Stanisław Kardach
2024-07-12 17:22 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8zatWiYQoe4kETcM61=OS1k=QaPRsNjYSYDspKC+voiQw@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=daniel.gregory@bytedance.com \
--cc=dev@dpdk.org \
--cc=liangma@liangbit.com \
--cc=punit.agrawal@bytedance.com \
--cc=roretzla@linux.microsoft.com \
--cc=sachin.saxena@nxp.com \
--cc=stanislaw.kardach@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).