From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC15D42D06; Tue, 20 Jun 2023 10:49:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 41958410D7; Tue, 20 Jun 2023 10:49:08 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D4D214068E for ; Tue, 20 Jun 2023 10:49:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687250946; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A0FScQbhIx0usiCsMYCnXJxit6BRrWAugN7BwJAYovg=; b=NGS40tjB9c4Esqdi5chrBIgM3EKIlw8PFepVbORlqRW/EF2kg6IbQWQt3+IWS+c4Gq6GMD EESkFL4UD/z6ZBfmlqQfXvBN4nmia3YfqYC0hszKG3HS/ozzq5A/IBQsO+iARQVDOSRUvW CdmL9qLBY96x2R9+FMoMTUtTm5D/fhQ= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-593-ln5oOkerPMeqMpCEYLgF8w-1; Tue, 20 Jun 2023 04:49:03 -0400 X-MC-Unique: ln5oOkerPMeqMpCEYLgF8w-1 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7639ab7a736so282501085a.1 for ; Tue, 20 Jun 2023 01:49:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687250942; x=1689842942; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A0FScQbhIx0usiCsMYCnXJxit6BRrWAugN7BwJAYovg=; b=OxxXHKAV/H9H369nUBdzDxpI5iAiArc48f6SxQG5x62k7crriF6Blhn4+zAezhSTkG 5JTwRPk4mt7BWRpSsmZI18a2d+RELXBZd6gSmMUURc84QWPghnfMCeCQSbdMndbYfkMo h4KXF/zz/7wK9MTvEJGe+nLWyc8c68mODZxztUrxeKIwMLuC8BWSlSRVUHx3wVu2jQvp fmdKZTEDZVIkcE6KCTrUyxkA1J5qnWLI90R3hCBUNfXSEZr2798WSThHiyKqF6LLbNuS JuATa2pN/cOsiY6qMSs025yYn4ch2o1gWY2NVZkJ/jkkz8WxHmYk519Eg/ESAdWh2B4x PBhw== X-Gm-Message-State: AC+VfDywObXFvp0STIo4bp9hpXZ1Qsfy9Oa3wx6Zlq1OlIknihSg+s2f jco9Ux7bUU2DaDVkD/22cRmeFL0nEADWfAcwS7sHLIg6/FooHqn14cmbEact5QhxrOev0+8QXAB p+l0f3BLXVi/D5XxuTZ8= X-Received: by 2002:a05:620a:29c5:b0:763:a513:3906 with SMTP id s5-20020a05620a29c500b00763a5133906mr4287828qkp.57.1687250942639; Tue, 20 Jun 2023 01:49:02 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6KJmvdVvTYIzMqxWq/P24Nffol64u5kojEG5wzQvaeF1MGQct8tvhawtuZ96ezCegf0C1I6cuomhmWysHdT50= X-Received: by 2002:a05:620a:29c5:b0:763:a513:3906 with SMTP id s5-20020a05620a29c500b00763a5133906mr4287805qkp.57.1687250942383; Tue, 20 Jun 2023 01:49:02 -0700 (PDT) MIME-Version: 1.0 References: <20211117112847.7362-6-david.marchand@redhat.com> <20230616071450.3542479-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Tue, 20 Jun 2023 10:48:50 +0200 Message-ID: Subject: Re: [PATCH v3] build: select optional libraries To: Bruce Richardson Cc: thomas@monjalon.net, dev@dpdk.org, bluca@debian.org, tredaelli@redhat.com, i.maximets@ovn.org, james.r.harris@intel.com, mohammed@hawari.fr, Aaron Conole , Michael Santana X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jun 20, 2023 at 10:45=E2=80=AFAM Bruce Richardson wrote: > > > > > I notice the change in behaviour for enabling the deprecated libs= . Is there > > > > > any other change in behaviour for current users? > > > > > > > > The only change I see, is that this implementation breaks enabling > > > > deprecated libs via disable_libs. > > > > It may break existing developer build directory and maybe some > > > > packaging scripts, this is why I am a bit puzzled. > > > > > > > > Relooking at the disable_libs option current implementation, it see= ms > > > > backward to pass a disable_libs option when you want to build some > > > > deprecated library. > > > > It is more straightforward to request building libraries via > > > > -Denable_libs=3D explicitly or -Denable_libs=3D* > > > > implicitly. > > > > > > > > But again, we may be breaking something for people who relied on th= is behavior. > > > > > > > > > > That's what I expected, and I think that is ok. I just wanted to chec= k that > > > the change in behaviour was only for the deprecated libs case. > > > > Thomas, wdyt? > > It requires some release note, at least. > > > I am assuming this is not targetting this release though, right? Assuming > 23.11, we can put in a deprecation note informing of the change ahead of > time too. I was hoping to get it in this release. But I am fine with postponing and announcing the change beforehand. --=20 David Marchand