From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AFDBEA0544; Tue, 7 Jun 2022 13:30:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5C2664021D; Tue, 7 Jun 2022 13:30:13 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 0FE8440156 for ; Tue, 7 Jun 2022 13:30:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654601411; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EuaI2dn0n5jVG8MBmuud//y6sXvDo/ZUIdNZqagtOAQ=; b=iR9YZsuDMJCv0GC1EVk6z1a82cLURKQmu43jN1XngPF4KT0uLyblO4lNF0WGXBPJHGgTnH MXsKiEc+n3xou+HxEZuwx1h1hhUaIUdlkmTylVpitIXrd5S9VhVxydxXeZBZYYdHzgkAm5 pbyyrv/JMqeus1DJ5oAilQAiJ+rhq+o= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-354-buAd0rGUPIC5xK51xgE7lA-1; Tue, 07 Jun 2022 07:30:10 -0400 X-MC-Unique: buAd0rGUPIC5xK51xgE7lA-1 Received: by mail-lj1-f197.google.com with SMTP id e3-20020a2e9303000000b00249765c005cso2942734ljh.17 for ; Tue, 07 Jun 2022 04:30:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EuaI2dn0n5jVG8MBmuud//y6sXvDo/ZUIdNZqagtOAQ=; b=n6jf9qWi/6vSUrzKaewRKwptHVabyp2ap3mE/P12fSQj2afv6V5lc7x/GujFmThoY2 hP6H/zXxQK29/DRU4hj6doUclnXvG68OwD0y/7v7gK1ZxxlHYyWPonJDG7vkzblssQhV RfmNd4gS80BV4gvIZ2W3lSXnGUw+NsuLs8muqWNOLHrj5Kp95rdN2REJBO8gSUWXrGGU xCMvXSKXO9oOZLqFojhhyIL9xqk4UQRPZnU0EmJmG5DLJcOS9QHf1Bv48LHjScAI9zSJ OZ3yH5OnVgjtwu4cFVnqXiG/8rgSrarWLFeQCKCw7IJyz3lpB/oV25OZ39xyi4jTc8K9 e10g== X-Gm-Message-State: AOAM533/XoqW+93oHIRjqTQ6ACN8HVfCopAgE1PP0aK/7sUBrpUKwfwq RKNnuebwLyTRVAxbH8q8+CIBspYcGF1ZVIFEeY8zn+CvB3gwnSVf9QtW9whw85uFHB4CaEApGGf k0gZYj2RvR/ChjU6XdcI= X-Received: by 2002:a2e:9e04:0:b0:255:a211:f440 with SMTP id e4-20020a2e9e04000000b00255a211f440mr3676246ljk.159.1654601408945; Tue, 07 Jun 2022 04:30:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzpXz2NTzQH7QptaZbpgNfeK4YflCuobV0aQ9TFe+VD7VXenTszGjhVrJKRETwtUs6PV6erL6MrQWuy5frLajA= X-Received: by 2002:a2e:9e04:0:b0:255:a211:f440 with SMTP id e4-20020a2e9e04000000b00255a211f440mr3676223ljk.159.1654601408424; Tue, 07 Jun 2022 04:30:08 -0700 (PDT) MIME-Version: 1.0 References: <1646956157-245769-1-git-send-email-nicolas.chautru@intel.com> <1646956157-245769-2-git-send-email-nicolas.chautru@intel.com> <02d1bd6c-b86f-bf81-3fb8-c2007497c1a5@oss.nxp.com> In-Reply-To: <02d1bd6c-b86f-bf81-3fb8-c2007497c1a5@oss.nxp.com> From: David Marchand Date: Tue, 7 Jun 2022 13:29:57 +0200 Message-ID: Subject: Re: [PATCH v1] bbdev: add new operation for FFT processing To: Hemant Agrawal , "Chautru, Nicolas" Cc: "thomas@monjalon.net" , "Zhang, Mingshan" , "dev@dpdk.org" , "gakhil@marvell.com" , "Vargas, Hernan" , Maxime Coquelin , "trix@redhat.com" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi guys, On Thu, May 26, 2022 at 8:05 AM Hemant Agrawal wrote: > On 5/26/2022 3:37 AM, Chautru, Nicolas wrote: > > Hi Hernant, > > Gentle reminder in case you can find the time. Could please have a look this patch for bbdev api extension. This is targeting 22.11. > > New operation type for FFT processing (On top of 4 existing operations types). There is no impact to the la12xx PMD but would be good to get review/feedback. > > This can be used for vanilla FFT and/or chained FFT/iFFT + point-wise multiplication making it applicable for SRS processing. > > Thanks, > > Nic > > Acked-by: Hemant Agrawal > > HI Nicolas, > > Yes, I had a look into it. I see no issue in it. This is fairly > independent feature addition to BBDEV. > Hemant, For this v22.11 change, we will need some acks on the ABI breakage announce in v22.07: https://patchwork.dpdk.org/project/dpdk/patch/1647542252-35727-2-git-send-email-nicolas.chautru@intel.com/ Could you review it? Thanks. -- David Marchand