From: David Marchand <david.marchand@redhat.com>
To: Tianhao Chai <cth451@gmail.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>, dev <dev@dpdk.org>,
Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: Re: [PATCH] rte_dev: allow C-symbol-in-C++ dma operations
Date: Thu, 5 May 2022 11:53:20 +0200 [thread overview]
Message-ID: <CAJFAV8zc1Z4wF8f+LMFCEdfqoO-w5re2vUuJdRrTpz51bDV5FA@mail.gmail.com> (raw)
In-Reply-To: <YnOSObkaN2aS/lF/@bricha3-MOBL.ger.corp.intel.com>
On Thu, May 5, 2022 at 11:00 AM Bruce Richardson
<bruce.richardson@intel.com> wrote:
> On Wed, May 04, 2022 at 11:39:35PM -0500, Tianhao Chai wrote:
> > Currently the "extern C" section ends right before rte_dev_dma_unmap
> > and other DMA function declarations, causing some C++ compilers to
> > produce C++ mangled symbols to rte_dev_dma_unmap instead of C symbols.
> > This leads to build failures later when linking a final executable
> > against this object.
> >
> Fixes: a753e53d517b ("eal: add device event monitor framework")
Cc: stable@dpdk.org
>
> > Signed-off-by: Tianhao Chai <cth451@gmail.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Applied, thanks.
--
David Marchand
next prev parent reply other threads:[~2022-05-05 9:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 4:39 Tianhao Chai
2022-05-05 9:00 ` Bruce Richardson
2022-05-05 9:53 ` David Marchand [this message]
2022-05-05 9:43 ` Tyler Retzlaff
2022-05-06 17:41 ` Morten Brørup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8zc1Z4wF8f+LMFCEdfqoO-w5re2vUuJdRrTpz51bDV5FA@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=cth451@gmail.com \
--cc=dev@dpdk.org \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).