From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7C7FA04FF; Thu, 5 May 2022 11:53:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 59DAD40C35; Thu, 5 May 2022 11:53:36 +0200 (CEST) Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [170.10.129.74]) by mails.dpdk.org (Postfix) with ESMTP id 2180C40042 for ; Thu, 5 May 2022 11:53:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651744414; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=s7qUYWyQoNKjs8ITLCzzfPcOcJ9VlD8r7GY5d1widcA=; b=QaYm8nhUQnOlE0lquG4z599YpWU5EEogwN/by2BTtYr+ziGWmSEw9zm5AU6M5/G9IRE6QV GWg5/mRlg3MXMTKInWLM9mtOKupmIzDJayKbpBKFW2B3k1g6UZ6FzSBVUbvwqc50sVEbZA AgshHlZq6UAsUtuMLa+6p1LUsg+6dMw= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-609-xEmIKWrOPcKmjUfT6fnQsg-1; Thu, 05 May 2022 05:53:33 -0400 X-MC-Unique: xEmIKWrOPcKmjUfT6fnQsg-1 Received: by mail-lf1-f69.google.com with SMTP id bt27-20020a056512261b00b004720e026d4dso1531833lfb.16 for ; Thu, 05 May 2022 02:53:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=s7qUYWyQoNKjs8ITLCzzfPcOcJ9VlD8r7GY5d1widcA=; b=idu0QdpAlbAlbeJ/7V5MJYFSn19VScdyckyAzeuTkuWwfqHnOQDgmXjOaNMgd+Rk51 5L/Uwzccq6M40EK7WudrrZtnck4tOYPNdFQdIXpVQT5jn0CaYeXKqc7MiWwI/OV8hYKV 3adg3Fy2/9LH1Ij11kymp1cgs6CCVjJhN2HDrZb6fCiZx5YgwIovdeXidLgID77tn8G9 +NrNeVNDmxlIxBfykj7t/OXzFr0DFCdaIHIVjg5q/pQPKv+dgaong4d3+FkROC0v36Ha dU0cO4MIo9Z/4BpMuCY62mBA28NmOXvaVo9J1ZQSggHiXd3EjU5DGhYltmVKfI+jzOjZ guUA== X-Gm-Message-State: AOAM533tVpQqbfPNLCdPS/D4O6CR6lg5LzgP/4aUzmZqsU8hW1UEPqqT BGVX3lttBFbSiyDeORb7+jyxhFEjizr402GrYy7jE5GnV6AdOJbcUj1CAxk0qQdDo1KK+Ov2tvn Cuff90aSF8G4TauiQVS4= X-Received: by 2002:a05:6512:3204:b0:472:4792:e29c with SMTP id d4-20020a056512320400b004724792e29cmr16867827lfe.553.1651744412062; Thu, 05 May 2022 02:53:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxzbefhFSNDooLAsdyZQrt6R2Oguu0EkQ0RocgBpsydoA4gtA300Rqa+IQTVTsryQJn9sGbMLGpCs9/Mq8RTwc= X-Received: by 2002:a05:6512:3204:b0:472:4792:e29c with SMTP id d4-20020a056512320400b004724792e29cmr16867811lfe.553.1651744411814; Thu, 05 May 2022 02:53:31 -0700 (PDT) MIME-Version: 1.0 References: <20220505043935.GA312259@cth-desktop-dorm.onozuka.cth451.me> In-Reply-To: From: David Marchand Date: Thu, 5 May 2022 11:53:20 +0200 Message-ID: Subject: Re: [PATCH] rte_dev: allow C-symbol-in-C++ dma operations To: Tianhao Chai Cc: Bruce Richardson , dev , Tyler Retzlaff Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, May 5, 2022 at 11:00 AM Bruce Richardson wrote: > On Wed, May 04, 2022 at 11:39:35PM -0500, Tianhao Chai wrote: > > Currently the "extern C" section ends right before rte_dev_dma_unmap > > and other DMA function declarations, causing some C++ compilers to > > produce C++ mangled symbols to rte_dev_dma_unmap instead of C symbols. > > This leads to build failures later when linking a final executable > > against this object. > > > Fixes: a753e53d517b ("eal: add device event monitor framework") Cc: stable@dpdk.org > > > Signed-off-by: Tianhao Chai > Acked-by: Bruce Richardson Acked-by: Tyler Retzlaff Applied, thanks. -- David Marchand