From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 27227A0562;
Fri, 3 Apr 2020 11:14:20 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 5EEB21C0D6;
Fri, 3 Apr 2020 11:14:19 +0200 (CEST)
Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com
[207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 199321C0D2
for <dev@dpdk.org>; Fri, 3 Apr 2020 11:14:17 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1585905257;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=Ih+YEU83ieqA0UNKBu5ytn5xnHjzevyAcQWg27SBR3w=;
b=UKxfhu1nzADjdsn+qmTfAjzNDcJ6sPk3v70pRvdRqyrmRCpyKkNCdpcn6gBFBMyU/Mx77q
GjqJYLs41abbZDZYzUTvx3QpSrbRMf77Xp/e1sU8kIjAK8SmwSbYlmTXjYMWhYIkyc7zX3
dCqJN0oowxs5HK4gjZIWJXZd/rwG384=
Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com
[209.85.222.69]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-81-Kx-6Eq7GMDKY13FjJzMimg-1; Fri, 03 Apr 2020 05:14:15 -0400
X-MC-Unique: Kx-6Eq7GMDKY13FjJzMimg-1
Received: by mail-ua1-f69.google.com with SMTP id f15so2435006uap.19
for <dev@dpdk.org>; Fri, 03 Apr 2020 02:14:15 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=Feu+WJHVtTHmBGIkLcuokI5daT60oGHAShpDcPnzPXI=;
b=rqDYlh9/BKvzc1nHp5HfcNemTInrcJ7oD2uj7NMr1iGltLhrJTftho5SB2/DGm4HDY
Suus8zPL+oPADMm89Z542QioFrjFKZPC/8e3NBGd9hphxC9DL5JG1+bbWBv1aOPaJp5k
dNhGkgtuFaVO5e1xrB+Wl8IZNuUEon/RAhNyDd3GXtRD7C+oWv0y/yGd4InM2ScW2DU3
8ZiVyHxBWmM+95TVRtfkOjyj0ovNqCFxIrgdL6m6xagAZGgVkUGlw6pBgjBZl7B+DDbS
j1C3UuPvMKQ+YdYlu0kNySj21QKBqDA+yIwOt6Wkru2ADh2PlR+neKKJRu9qUxx3n5Om
xKTw==
X-Gm-Message-State: AGi0PubRjOcjz51F1BDZDJeyqS2Wvr9Hbl3IgmvfGO9mLC0NHVQVLkEm
RZQ6f0jUUywJkL69djnQg65771h1T/Kq5K8ji/0os2HNr/Fwz0L+TrcQCVX5VfhCSqDa+Go5B/b
EwbAJ04P1ocJ8GvfjsG4=
X-Received: by 2002:a67:e995:: with SMTP id b21mr5883722vso.105.1585905255207;
Fri, 03 Apr 2020 02:14:15 -0700 (PDT)
X-Google-Smtp-Source: APiQypI3TuI0hYWSRkLJSf2vmBstgCPoqCAeKIxFb9ogKkcICfI9ZVyvi4Tkbxn5r3XF7//Yv7Sjg/M5Eh3Vm+8zPQA=
X-Received: by 2002:a67:e995:: with SMTP id b21mr5883705vso.105.1585905254939;
Fri, 03 Apr 2020 02:14:14 -0700 (PDT)
MIME-Version: 1.0
References: <20200402183253.866-1-jerinjacobk@gmail.com>
<CAJFAV8zman3vNDyr_BBohMXvdajV2uKBCsCgqu64q_x-NOf2TQ@mail.gmail.com>
<CAJFAV8z_cTt1ZcWUkda9J8d6TMfY2djMz6rxnwrPQoFSfNz8Gg@mail.gmail.com>
<CY4PR1801MB18636103B7732A3087BA1039DEC70@CY4PR1801MB1863.namprd18.prod.outlook.com>
<CAJFAV8wTPCF6_mgV0JTaroGYyrROUzstrJ+hjfVkrvts6TC22g@mail.gmail.com>
<20200403091034.GA543@bricha3-MOBL.ger.corp.intel.com>
In-Reply-To: <20200403091034.GA543@bricha3-MOBL.ger.corp.intel.com>
From: David Marchand <david.marchand@redhat.com>
Date: Fri, 3 Apr 2020 11:14:03 +0200
Message-ID: <CAJFAV8zcBY-mMNPpKwNVATY6pmm5ui3KNQrXBzDgpearMbCGqQ@mail.gmail.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
Jerin Jacob <jerinjacobk@gmail.com>,
Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@intel.com>,
dev <dev@dpdk.org>, Neil Horman <nhorman@tuxdriver.com>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/2] build: meson make
experimental tag as global
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Fri, Apr 3, 2020 at 11:10 AM Bruce Richardson
<bruce.richardson@intel.com> wrote:
> > diff --git a/drivers/meson.build b/drivers/meson.build
> > index 987e616ae7..4d8f842ab8 100644
> > --- a/drivers/meson.build
> > +++ b/drivers/meson.build
> > @@ -20,7 +20,7 @@ dpdk_driver_classes =3D ['common',
> > disabled_drivers =3D run_command(list_dir_globs, get_option('disable_d=
rivers'),
> > ).stdout().split()
> >
> > -default_cflags =3D machine_args
> > +default_cflags =3D machine_args + ['-DALLOW_EXPERIMENTAL_API']
> > if cc.has_argument('-Wno-format-truncation')
> > default_cflags +=3D '-Wno-format-truncation'
> > endif
>
> I see nothing wrong with that.
>
> Out of interest, is there a reason we don't just set it at the top level =
as
> a project c_arg, e.g. after setting "-include rte_config.h" in
> config/meson.build?
As long as it is not inherited by examples and external apps, I am
fine with any simple solution :-).
--=20
David Marchand