From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F3CFDA050B; Thu, 7 Apr 2022 10:20:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8651B40689; Thu, 7 Apr 2022 10:20:21 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id C7F094014F for ; Thu, 7 Apr 2022 10:20:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649319619; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2fqXdfvDOGhgmjwxCwamOBhdqd3eO06V5WMF+ag2SsQ=; b=cmH+FI3dYAJ21W7N16NsvYgdBAkNzeLyUkJo+VubGfHzoztyQn0RSGRgEJy4/xWFzKSg5W 0G1IjRK9YTlwYsBLRtf7tUG3UXg98pn4gTkXIiY8NgBIBICTCug/Yv7/m+ylkF8W6FG0eq ZJFZ7bUd4c4Op89cokNuygBoLwnubNQ= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-441-5exRjqMjNz-5-BKVKfd0Iw-1; Thu, 07 Apr 2022 04:20:18 -0400 X-MC-Unique: 5exRjqMjNz-5-BKVKfd0Iw-1 Received: by mail-lf1-f69.google.com with SMTP id n2-20020a0565120ac200b0044a2c76f7e1so1580830lfu.5 for ; Thu, 07 Apr 2022 01:20:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2fqXdfvDOGhgmjwxCwamOBhdqd3eO06V5WMF+ag2SsQ=; b=Jyp/ksAMLPHxIuQz5beHrhF2DsCn4KniGUMg1WrKkBm6GUhD9EfKg5vBSiE4BV2lvW RgGDb1rA3Ty5YmX92Y2K55d6N427Q7Il0KGszWl9YIpXRfqS5glWS8nM7q6mYcgN/pAG bjDdWDcxVrZf+1jmHojPMrMDo8uqOVxWKhIlQubu5IedZcWv3zMGmDUN6KPrUXJxnnO1 jJugeDtCIDZvZfz/4N0rEDvW1wqaUMXDbyzF5t0F2sFbjPhFRiQC3ZF2UlbuKXfhgbgA qvV/T+Ww09hpcciA3P7yg1n/md353BC211l7AKIQKdzO5ZXMujJ/M1iQ268eArEaUHNu zcdw== X-Gm-Message-State: AOAM532mNnzOOj8U1SS+OHTQS+ksXNdvu0kodtk4w+FPskkeO1zfGgrk mY4bYECMHzgispKrnepZgPXATSksnXzXA0hVtZOb+XLS4KPLmv7o4L1/L8zh+6NlATvkOH19jcD 8r5B+tb9qC4XZxr+0QkM= X-Received: by 2002:a05:6512:3f1b:b0:450:abeb:33cf with SMTP id y27-20020a0565123f1b00b00450abeb33cfmr8518708lfa.217.1649319614849; Thu, 07 Apr 2022 01:20:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz9hfxDBVcc3wAtFQ4FJ1BAVJrT2QUNWyqcCfaRwHav0FWRONBU41xV4jMmL7spT/PltMq1rOGy1Fc0TcOlREw= X-Received: by 2002:a05:6512:3f1b:b0:450:abeb:33cf with SMTP id y27-20020a0565123f1b00b00450abeb33cfmr8518692lfa.217.1649319614565; Thu, 07 Apr 2022 01:20:14 -0700 (PDT) MIME-Version: 1.0 References: <20220328121758.26632-1-david.marchand@redhat.com> <20220330134956.18927-1-david.marchand@redhat.com> <20220330134956.18927-3-david.marchand@redhat.com> <20220403202105.6a90024b@shemminger-XPS-13-9360> In-Reply-To: <20220403202105.6a90024b@shemminger-XPS-13-9360> From: David Marchand Date: Thu, 7 Apr 2022 10:20:03 +0200 Message-ID: Subject: Re: [RFC PATCH v2 2/9] eal: annotate spinlock and rwlock To: Stephen Hemminger Cc: dev , Maxime Coquelin , "Xia, Chenbo" , Jiayu Hu , "Wang, YuanX" , Xuan Ding , Ruifeng Wang , Jan Viktorin , David Christensen , Bruce Richardson , Konstantin Ananyev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Apr 4, 2022 at 8:21 AM Stephen Hemminger wrote: > > On Wed, 30 Mar 2022 15:49:49 +0200 > David Marchand wrote: > > > +#ifdef RTE_ANNOTATE_LOCKS > > + > > +#define RTE_ANNOTATED_LOCK \ > > + __attribute__((lockable)) > > + > > +#define RTE_GUARDED_BY(...) \ > > + __attribute__((guarded_by(__VA_ARGS__))) > > +#define RTE_GUARDED_VAR \ > > + __attribute__((guarded_var)) > > Could we use attributes that match the existing syntax and lower case. > That is what was done for hot/cold and format attributes. Yes, I reconsidered and I'll do that. -- David Marchand