From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DCE834601C; Wed, 8 Jan 2025 11:59:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 751C74014F; Wed, 8 Jan 2025 11:59:19 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 2778B400D6 for ; Wed, 8 Jan 2025 11:59:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736333957; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=59aCEn8IuFTMq2IWCvvuB//7+wTSJ8++xQmhvDnp3ys=; b=HbRAwTjlPSnQBinFQUshLBk+7EPAh2QilWAjJ7gCSlCaBYF14Q4E2xHVyz0RbwHuDtlXz+ neMUyh6zWgPlqkIDAmM56W/XLXzfB7KGjr6VZjqtJsv+GZdNd1hsfBbYrpFQydyY0GFy99 4fN5Clz+pkkCxxHYUcGsTSz7ru1+iLY= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-548-Nwkn_lxIMQ6u5NBPMGQXiw-1; Wed, 08 Jan 2025 05:59:16 -0500 X-MC-Unique: Nwkn_lxIMQ6u5NBPMGQXiw-1 X-Mimecast-MFC-AGG-ID: Nwkn_lxIMQ6u5NBPMGQXiw Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-30036354518so44579951fa.2 for ; Wed, 08 Jan 2025 02:59:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736333954; x=1736938754; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=59aCEn8IuFTMq2IWCvvuB//7+wTSJ8++xQmhvDnp3ys=; b=rBSCtnVfVGEYHZf/QMm692jYmyvCu0lqkOqYHwvExuxKC+W6dJaDQZ0k0G0ZgsZyHN 93+/BAX6OAimGlzF5bazDTnVAWlEsXGPO/lg9ScTsHCnt3rNH1zbSW4GXVn89WUg9AeA I0fXU5tM5bDhhkyrKGCP15Dvc+aWKIyPVcFGsT50BYBaYNfKINTV06IYKoCYBNRgKYz/ dTLBerYZBxSHbxxHUNvEJq8Q8rWiposF+bVubicJ2tSh3haIYVlIHcvEue4I32uvy3Wb 4W7LaHkC/GXXGjU8h1IuBmEsOOSvS/sYXYpfnwpyNLX8XMp4JxcJnc7dNuZXuAlY8P4l X7cw== X-Forwarded-Encrypted: i=1; AJvYcCXvAGN1LMB7Afd0Zk8iSj0HNQMpEvFRbQmF25Wkm4gGY3fKi8YrKLEYt7Ez/3gCTKc/T/k=@dpdk.org X-Gm-Message-State: AOJu0YxtRux6iuN1KcJ3oosNCGx0k9rBbPatRZ/yOaO2xLJVCmKqrBh3 vxCVSBrjETj1xAu2SajPFlvyUnifZ4Q8XdEBtAA2UQo1++td1VlKKT4WMo/1872HICmguXMeXRH NApWdOIppP/6RUaaueHi3Kd1nfJm/PRyvjOnXC18OqXKwRwYp6Z2Ukybd5WEPuz7ozppRr1Dd74 FiyNWXaEH8eRLv/wA= X-Gm-Gg: ASbGncstonhhSKI4GaoPaTIDNiGlqqno6V6XRfLuSSj5uT5m9fBktFj8kASbpSybSZS 8n7Fwl0PBvv+tN6PSizJNcrErVWOuU8oIPpaE5rl8 X-Received: by 2002:ac2:4e08:0:b0:542:23b3:d81b with SMTP id 2adb3069b0e04-5428450707amr531220e87.5.1736333954597; Wed, 08 Jan 2025 02:59:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IE1je9LoNpAstUvG20krHwe08Sbi2Y3Yy672AEfLl0Q3PtgppEulg/wuGkyS1a0iThCBNKu3nHOkyXxR2Vm00I= X-Received: by 2002:ac2:4e08:0:b0:542:23b3:d81b with SMTP id 2adb3069b0e04-5428450707amr531204e87.5.1736333954197; Wed, 08 Jan 2025 02:59:14 -0800 (PST) MIME-Version: 1.0 References: <1710968771-16435-1-git-send-email-roretzla@linux.microsoft.com> <1735670291-23224-1-git-send-email-andremue@linux.microsoft.com> <1735670291-23224-15-git-send-email-andremue@linux.microsoft.com> In-Reply-To: <1735670291-23224-15-git-send-email-andremue@linux.microsoft.com> From: David Marchand Date: Wed, 8 Jan 2025 11:59:03 +0100 X-Gm-Features: AbW1kvbd-fF2kiCH6L3vfALc4ktYfmxD1MGtw5OFjkHo7bmcLbuUzUmc4GxxhHc Message-ID: Subject: Re: [PATCH v8 14/29] drivers/net: replace packed attributes To: Jeroen de Borst , Rushil Gupta , Joshua Washington Cc: roretzla@linux.microsoft.com, bruce.richardson@intel.com, dev@dpdk.org, stephen@networkplumber.org, Andre Muezerie X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: WrTZ6uXBzuRwLH0phxBZmXByTAmZLEdLq9JfIpsbfUk_1736333955 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Dec 31, 2024 at 7:40=E2=80=AFPM Andre Muezerie wrote: > > MSVC struct packing is not compatible with GCC. Replace macro > __rte_packed with __rte_packed_begin to push existing pack value > and set packing to 1-byte and macro __rte_packed_end to restore > the pack value prior to the push. > > Macro __rte_packed_end is deliberately utilized to trigger a > MSVC compiler warning if no existing packing has been pushed allowing > easy identification of locations where the __rte_packed_begin is > missing. > > Signed-off-by: Andre Muezerie Just a heads up to the GVE driver maintainers. This patch touches drivers code when it comes to packing structures. So far the GVE *base* driver was relying on the __packed (kernel) construct= . For MSVC support, Andre introduces __rte_packed_begin/end macros. Please shout if you are against those changes on this base driver code. Thanks. --=20 David Marchand