From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3675043C93; Tue, 12 Mar 2024 17:13:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 031EB40ED9; Tue, 12 Mar 2024 17:13:55 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 053BE402D8 for ; Tue, 12 Mar 2024 17:13:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710260033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4RRXeb1oBkLsEHpdpU/25frcw+zJGvqpnzBPGztzc+g=; b=RrR0KWZz/29fgHE2EDQj4ePIJL3nwuQXK8RcEbduO543D9I0A+Wm6GUZOzMge2VnrFF2Wh A69pdWLjDuuraNN3g7ww874bjZuy9j1gAxOoYzZ9VNGzNekWFJ/SfcfPfLjJnqNV5j2E8A pVKVuC4GOEoEu0Wi1FyS9oSrTtKRstQ= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-650-yr5K7nhgNuu9BSy3DA04QQ-1; Tue, 12 Mar 2024 12:13:52 -0400 X-MC-Unique: yr5K7nhgNuu9BSy3DA04QQ-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2d32d9a312eso42069761fa.2 for ; Tue, 12 Mar 2024 09:13:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710260030; x=1710864830; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4RRXeb1oBkLsEHpdpU/25frcw+zJGvqpnzBPGztzc+g=; b=hjuLh/DR04HDvj/sH8hkjsNK3asUnLdkclV2eK3cJC+zCYapTnV4WHhocMlzvOCsSd yKPl5rdHs/xhqRN4d3UwjOsJkJvLF7k/gQjVo/zFmdaydD9v2lLL9KkKHGsuS/b1MaBM JMQSRxYfzwG9F5aIr+JkGX65rriWQ5oSzR71Phec11kEVYd3DWpD2gw6+LNNmDQhb+KN AvGUv08UF2CEaG1to3x8w117D2cLRFMVaya1Z3ytDHdtMNGr09co5SAzXD1g0QDkaFOJ tBCGCmVaRa3ZEtVEkcHeN6I8V5LhNqFB/JjsRzTZEQHkF2FP23uP+eajZL47IEiWqgIk L2cQ== X-Forwarded-Encrypted: i=1; AJvYcCXy2BjXFWslh38GIz1j7XwFVboFfpogGmy9IUTqE0B6FD96kWvsg0+a9Yz0Ybn6lmy3ybsYryeS9NSGD80= X-Gm-Message-State: AOJu0YzabvdT2X0Z7WeZ2b+2fWIJkeCufYnD7cAv42F5ED5DO+TXCrc7 fBQHEDiD5J6hGcgwfHgAz898J0XVCRGl9OV0wQmH3ItIlTiPD8xPaQUKedrHBNfslOIhyFahgN/ mI96mUx5AMYC1zBDPIb3tTj6/2u7AhK9htNgiuOz/tHXTqB++NcaNOTyg6iQ/qxu16y8v9renpT QgK6eEDMQzb3o/UDM= X-Received: by 2002:a2e:890e:0:b0:2d2:c8ee:c99b with SMTP id d14-20020a2e890e000000b002d2c8eec99bmr7315557lji.29.1710260030662; Tue, 12 Mar 2024 09:13:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHZXAmmdkWLjmlE7ZkY9zlq6iWuME9hbaI/MQwMu+jt5/pxw0NlIfff8syidPRp1bhhtmKIEIoYwqSqTquohLI= X-Received: by 2002:a2e:890e:0:b0:2d2:c8ee:c99b with SMTP id d14-20020a2e890e000000b002d2c8eec99bmr7315537lji.29.1710260030316; Tue, 12 Mar 2024 09:13:50 -0700 (PDT) MIME-Version: 1.0 References: <20231212153640.1561504-1-brian.dooley@intel.com> <20240312135020.2969533-1-brian.dooley@intel.com> In-Reply-To: From: David Marchand Date: Tue, 12 Mar 2024 17:13:39 +0100 Message-ID: Subject: Re: [PATCH v6 1/5] ci: replace IPsec-mb package install To: "Power, Ciara" Cc: "Dooley, Brian" , Aaron Conole , Michael Santana , "dev@dpdk.org" , "gakhil@marvell.com" , "De Lara Guarch, Pablo" , "probb@iol.unh.edu" , "wathsala.vithanage@arm.com" , Thomas Monjalon , Bruce Richardson X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Mar 12, 2024 at 4:26=E2=80=AFPM Power, Ciara wrote: > > From: David Marchand > > On Tue, Mar 12, 2024 at 2:50=E2=80=AFPM Brian Dooley > > wrote: > > > > > > From: Ciara Power > > > > > > The IPsec-mb version that is available through current package > > > managers is 1.2. > > > This release moves the minimum required IPsec-mb version for IPsec-mb > > > based SW PMDs to 1.4. > > > To compile these PMDs, a manual step is added to install IPsec-mb v1.= 4 > > > using dpkg. > > > > > > Signed-off-by: Ciara Power > > > --- > > > .github/workflows/build.yml | 25 ++++++++++++++++++++++--- > > > 1 file changed, 22 insertions(+), 3 deletions(-) > > > > > > diff --git a/.github/workflows/build.yml b/.github/workflows/build.ym= l > > > index 776fbf6f30..ed44b1f730 100644 > > > --- a/.github/workflows/build.yml > > > +++ b/.github/workflows/build.yml > > > @@ -106,9 +106,15 @@ jobs: > > > run: sudo apt update || true > > > - name: Install packages > > > run: sudo apt install -y ccache libarchive-dev libbsd-dev libb= pf-dev > > > - libfdt-dev libibverbs-dev libipsec-mb-dev libisal-dev libjan= sson-dev > > > + libfdt-dev libibverbs-dev libisal-dev libjansson-dev > > > libnuma-dev libpcap-dev libssl-dev ninja-build pkg-config py= thon3-pip > > > python3-pyelftools python3-setuptools python3-wheel > > > zlib1g-dev > > > + - name: Install ipsec-mb library > > > + run: | > > > + wget "https://launchpad.net/ubuntu/+archive/primary/+files/l= ibipsec- > > mb-dev_1.4-3_amd64.deb" > > > + wget "https://launchpad.net/ubuntu/+archive/primary/+files/l= ibipsec- > > mb1_1.4-3_amd64.deb" > > > + sudo dpkg -i libipsec-mb1_1.4-3_amd64.deb > > > + sudo dpkg -i libipsec-mb-dev_1.4-3_amd64.deb > > > > I am not enthousiastic at advertising a kind of out of tree approach. > > That's a bit like if NVIDIA asked us to stop testing distribution rdma-= core > > packages and instead rely on MOFED. > > > > Why are we removing support for versions that are packaged by the main > > distributions? > > With Ubuntu 22.04, ipsec-mb v1.2 is the version available through the pac= kage manager. > We were aiming to make v1.4 the minimum version for ipsec-mb PMDs from th= is release onwards, > removing the many ifdef codepaths in the PMDs for older versions. (patch = included in this patchset) > > Some of the other CI environments were updated to install v1.4 already to= support this change, > but we found the github CI robot was limited for ipsec-mb versions when u= sing the package manager. > It had some failures comparing ABI with v1.2 installed (SW PMDs compiled = in reference build, but not compiled after patch). Such a change means that users of the Ubuntu/Fedora dpdk package lose access to those drivers hypothetically. "Hypothetically", because in reality, Ubuntu and others distributions won't update to non LTS versions. On the other hand, if a user was building DPDK (and not the one provided by the distribution), now the user has to stop using the ipsec mb provided by the distribution: building/packaging/maintaining the ipsec mb library is now forced on the user plate. I am unclear if this qualifies as a ABI breakage, but I am not confortable with this change. --=20 David Marchand