From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5736845C5A; Fri, 8 Nov 2024 18:09:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1F9E2433B6; Fri, 8 Nov 2024 18:09:15 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 4B8704067C for ; Fri, 8 Nov 2024 18:09:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731085752; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0WArkVLYwQzxOMIkKMfvqbEG+oP4GVLCnjbUCD4QIh8=; b=LYT2m2AjoqKyF3ZbGJVYXgtCZ52GWk0hxVJQJlECtSodyAc8Tx0xzF9dupoYrCOLQYHfgr HUzGcOXDgFh2LXqrWsr62R8lXF7EsoAjpAjOgkEjjIuc3ww561FMRFW8VD5/nhYTWe/pdA 7i2b4Jp6fzVGLbDnosqDvRHqh+/JPz0= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-443-JkQVSFEWO42BRiVe-GSxPw-1; Fri, 08 Nov 2024 12:09:11 -0500 X-MC-Unique: JkQVSFEWO42BRiVe-GSxPw-1 X-Mimecast-MFC-AGG-ID: JkQVSFEWO42BRiVe-GSxPw Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-539e0fa6f3dso2186889e87.1 for ; Fri, 08 Nov 2024 09:09:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731085749; x=1731690549; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0WArkVLYwQzxOMIkKMfvqbEG+oP4GVLCnjbUCD4QIh8=; b=POAL53CitjU4eRbLontXALCUjVdL6qpPlxWuwl3dvjV2laq2GuTps7f7M+4578Ntkv YJznG92uABN5IwV3ixz15KzseMYmMbLXBuKuxdv4uX3kJdzEypeAYrONOdVL1EaalNN+ Cffhg1gW2CXuu84BTsK5WREd+uIzyAXUPQtUox+GlWHoriyvufLb7dr1mBDcdwP8ppiY EM+HxWvEwFdRRXYRuL0uhDd/IeIjb8HcpPFucQta4s45GqtcvpBTfdq3HnJkIP70JDEz B2/1lnS2WnVRxDsS1Km6FcGBqmEVRBVMbu8JHttMxRBoEIQvv0gRDIo2trnSq8mYwpNC /Oag== X-Gm-Message-State: AOJu0YwR7qfTmCMrekHw+fJExym96zViqIkqlIlAYy0eFm7BVw+4GVSZ 8gyWzQWHcES2rQI2niCZRupavXB4XVh9bTf3JMT/0UzpRbUQqyrGkCmYKJhKiczqYFadZfx8cE+ /Nt8FeYygE74q12mRfmw1zeOaBEaWtA98nVgKeyV53epz9rbDCzeTndaa165B6eWdZbLT+GDuxv lBmDX+DeGacHZVWJK7YlJr0gs= X-Received: by 2002:a05:6512:ea8:b0:538:9e1e:b06f with SMTP id 2adb3069b0e04-53d862cd177mr3142110e87.27.1731085749538; Fri, 08 Nov 2024 09:09:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IH7pbJ3G9JxN44Is16A3L3sxHgl6lrySmhsbv7R/JAI/mbtfZ3USw05o0I3yoho1DzxW02VXSMEgd0x562TgHI= X-Received: by 2002:a05:6512:ea8:b0:538:9e1e:b06f with SMTP id 2adb3069b0e04-53d862cd177mr3142002e87.27.1731085747799; Fri, 08 Nov 2024 09:09:07 -0800 (PST) MIME-Version: 1.0 References: <20200814173441.23086-1-stephen@networkplumber.org> <20241108085710.2943741-1-david.marchand@redhat.com> In-Reply-To: <20241108085710.2943741-1-david.marchand@redhat.com> From: David Marchand Date: Fri, 8 Nov 2024 18:08:56 +0100 Message-ID: Subject: Re: [PATCH v32 00/12] Log library enhancements To: dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: y6gzpqcrb05s_8iIeHxDTm1q2prOTqjCrPynB4ue-Ak_1731085750 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Nov 8, 2024 at 9:57=E2=80=AFAM David Marchand wrote: > > Improvements and unification of logging library. > This version works on all platforms: Linux, Windows and FreeBSD. > > This is update to rework patch set. It adds several new features > to the console log output. > > * Putting a timestamp on console output which is useful for > analyzing performance of startup codes. Timestamp is optional > and must be enabled on command line. > > * Displaying console output with colors. > It uses the standard conventions used by many other Linux commands > for colorized display. The default is to enable color if the > console output is going to a terminal. But it can be always > on or disabled by command line flag. This default was chosen > based on what dmesg(1) command does. > > Color is used by many tools (vi, iproute2, git) because it is helpful= ; > DPDK drivers and libraries print lots of not very useful messages. > And having error messages highlighted in bold face helps. > This might also get users to pay more attention to error messages. > Many bug reports have earlier messages that are lost because > there are so many info messages. > > * Add support for automatic detection of systemd journal > protocol. If running as systemd service will get enhanced > logging. > > * Use of syslog is optional and the meaning of the > --syslog flag has changed. The default is *not* to use > unless requested. > > Add Stephen as maintainer for log because by now have added > more than previous authors. > > > Resending for CI: > > Changes since v31: > - rebased, > - fixed build with MSVC: escape character was restored to \033 > (used until v25) instead of \e, Applied, thanks. --=20 David Marchand