[PATCH] net/mana: support building the driver on arm64

[PATCH] net/mana: support building the driver on arm64

[longli]

From: Long Li <longli@microsoft.com>

The driver has been verified on Linux arm64. Enable this build option and
add a missing header file for arm64.

Signed-off-by: Long Li <longli@microsoft.com>
---
 drivers/net/mana/meson.build | 4 ++--
 drivers/net/mana/mp.c        | 1 +
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/mana/meson.build b/drivers/net/mana/meson.build
index 2d72eca5a8..330d30b2ff 100644
--- a/drivers/net/mana/meson.build
+++ b/drivers/net/mana/meson.build
@@ -1,9 +1,9 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2022 Microsoft Corporation
 
-if not is_linux or not dpdk_conf.has('RTE_ARCH_X86')
+if not is_linux or not (dpdk_conf.has('RTE_ARCH_X86') or dpdk_conf.has('RTE_ARCH_ARM64'))
     build = false
-    reason = 'only supported on x86 Linux'
+    reason = 'only supported on x86 or arm64 Linux'
     subdir_done()
 endif
 
diff --git a/drivers/net/mana/mp.c b/drivers/net/mana/mp.c
index 738487f65a..34b45ed832 100644
--- a/drivers/net/mana/mp.c
+++ b/drivers/net/mana/mp.c
@@ -5,6 +5,7 @@
 #include <rte_malloc.h>
 #include <ethdev_driver.h>
 #include <rte_log.h>
+#include <stdlib.h>
 
 #include <infiniband/verbs.h>
 
-- 
2.43.0

Re: [PATCH] net/mana: support building the driver on arm64

[Ferruh Yigit]

On 8/26/2024 11:38 PM, longli@linuxonhyperv.com wrote:
> From: Long Li <longli@microsoft.com>
> 
> The driver has been verified on Linux arm64. Enable this build option and
> add a missing header file for arm64.
> 
> Signed-off-by: Long Li <longli@microsoft.com>
>

Hi Long,

I don't see this patch in the mail list and patchwork, it can be because
of the email address it has been sent, fyi.

Re: [PATCH] net/mana: support building the driver on arm64

[David Marchand]

Hello,

On Tue, Aug 27, 2024 at 12:01 PM Ferruh Yigit <ferruh.yigit@amd.com> wrote:
>
> On 8/26/2024 11:38 PM, longli@linuxonhyperv.com wrote:
> > From: Long Li <longli@microsoft.com>
> >
> > The driver has been verified on Linux arm64. Enable this build option and
> > add a missing header file for arm64.
> >
> > Signed-off-by: Long Li <longli@microsoft.com>
> >
>
> Hi Long,
>
> I don't see this patch in the mail list and patchwork, it can be because
> of the email address it has been sent, fyi.

The mail was waiting in the moderation queue.
Long, please fix your send-email setup, or send with a mail address
registered to the dev@ ml.


Thanks.

-- 
David Marchand

RE: [PATCH] net/mana: support building the driver on arm64

[Long Li]

> > Hi Long,
> >
> > I don't see this patch in the mail list and patchwork, it can be
> > because of the email address it has been sent, fyi.
> 
> The mail was waiting in the moderation queue.
> Long, please fix your send-email setup, or send with a mail address registered
> to the dev@ ml.

I think the patch has made it to patchwork:
https://patchwork.dpdk.org/project/dpdk/patch/1724711938-3108-1-git-send-email-longli@linuxonhyperv.com/

The sender is longli@linuxonhyperv.com, the author is longli@microsoft.com. I hope that is okay.

Long

Re: [PATCH] net/mana: support building the driver on arm64

[David Marchand]

On Wed, Aug 28, 2024 at 1:59 AM Long Li <longli@microsoft.com> wrote:
> > The mail was waiting in the moderation queue.
> > Long, please fix your send-email setup, or send with a mail address registered
> > to the dev@ ml.
>
> I think the patch has made it to patchwork:
> https://patchwork.dpdk.org/project/dpdk/patch/1724711938-3108-1-git-send-email-longli@linuxonhyperv.com/
>

I released this mail from the moderation queue, so the patch could
make it to patchwork.

> The sender is longli@linuxonhyperv.com, the author is longli@microsoft.com. I hope that is okay.

The @linuxonhyperv.com address one is not registered to the dev ml,
which is the reason why the mail got moderated.

Hope it is clear now..


-- 
David Marchand

RE: [PATCH] net/mana: support building the driver on arm64

[Long Li]

 
> I released this mail from the moderation queue, so the patch could make it to
> patchwork.
> 
> > The sender is longli@linuxonhyperv.com, the author is
> longli@microsoft.com. I hope that is okay.
> 
> The @linuxonhyperv.com address one is not registered to the dev ml, which is
> the reason why the mail got moderated.
> 
> Hope it is clear now..

Thank you, I have subscribed as longli@linuxonhyperv.com. I don't know the reason why it got bounced and membership disabled in the past.

Long

Re: [PATCH] net/mana: support building the driver on arm64

[Ferruh Yigit]

On 8/26/2024 11:38 PM, longli@linuxonhyperv.com wrote:
> From: Long Li <longli@microsoft.com>
> 
> The driver has been verified on Linux arm64. Enable this build option and
> add a missing header file for arm64.
> 
> Signed-off-by: Long Li <longli@microsoft.com>
>

Applied to dpdk-next-net/main, thanks.