From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AFD68A0547; Fri, 9 Apr 2021 16:34:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 24B7A141057; Fri, 9 Apr 2021 16:34:33 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 7CC5514104F for ; Fri, 9 Apr 2021 16:34:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617978870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Alf82q7OKfZJBMXcUOBgH3s2R1EeX+bTlP27yVCfUM0=; b=B6drsj1snloL2Gv6vmOp1BWuHZtJ2uQb43Ue7y7zTEht8+pdlMAOuYcqCRI2vNAV9kYur5 r7pXWSKsRVsn5tXE4oxdG3iFkVKg68AM99U6gw3ezLSWC3oWIcBEqGX3hxZ1khJNC0EeCC RhrWNun3TdxoW738mhymc9MvBQNwX3U= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-269-bVcAoHwSNiu_1ZeyaLVaFA-1; Fri, 09 Apr 2021 10:34:26 -0400 X-MC-Unique: bVcAoHwSNiu_1ZeyaLVaFA-1 Received: by mail-vk1-f199.google.com with SMTP id m124so1336785vkg.3 for ; Fri, 09 Apr 2021 07:34:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Alf82q7OKfZJBMXcUOBgH3s2R1EeX+bTlP27yVCfUM0=; b=Ksz6/tdqDrOOvOEPlWk1ENiHRToQYTK4FgziDtOimgEEz9O55JU8wvuT8Prae/hHa2 isN34pJWC8KOfxi7mdvMNUEctDwar7HVFnRGhmIWe7xbMYrXbvCbhOs3Awup2+fw6BUR rzrJAFMBwDrdK2LpdIK3k0+R/opfeJiNHaB/OKi0x4jno0mnbdkagtHdoEHfGRKwdgHx AheLtmEITiyeWbvkz2B3GYB+bMVRH523xmdDrS/zJ1jKqwqvhGdYocXe0OSLQ42tKuyN C4daoxjaWGRy8WPcIB0qhRlyzaIAz3mNTrAj7DbjBMhI9e31diBJc6IwKF1qS6qpnLaP JlKg== X-Gm-Message-State: AOAM530+gf0lBLkuaM9OvRPQprM/MnTHVAWskj7+7J2sr9rN01zpiitg /EbQYo2Wz4B/ViRVnnsmakmDo0v7PsjrwDuURYmAVQLQLVSJbZze/9TEWQZzelz9zNh1oV8E2YN undl0q2G8nPA5KBsCGaE= X-Received: by 2002:ac5:ccc4:: with SMTP id j4mr11343204vkn.18.1617978866446; Fri, 09 Apr 2021 07:34:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzLstc+4ss8QvLntgHy/M5N1KR4xvUw55CgNXTEwk5pjBPuynGPGqHxcXtIRsBiHAP76xlq0l74+E1c3NDV91I= X-Received: by 2002:ac5:ccc4:: with SMTP id j4mr11343184vkn.18.1617978866255; Fri, 09 Apr 2021 07:34:26 -0700 (PDT) MIME-Version: 1.0 References: <20210407201603.149234-2-lucp.at.work@gmail.com> In-Reply-To: <20210407201603.149234-2-lucp.at.work@gmail.com> From: David Marchand Date: Fri, 9 Apr 2021 16:34:15 +0200 Message-ID: To: Luc Pelletier Cc: Olivier Matz , Honnappa Nagarahalli , dev , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] eal: fix hang in ctrl thread creation error logic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Apr 7, 2021 at 10:29 PM Luc Pelletier wrote: > > The affinity of a control thread is set after it has been launched. If > setting the affinity fails, pthread_cancel is called followed by a call > to pthread_join, which can hang forever if the thread's start routine > doesn't call a pthread cancellation point. > > This patch modifies the logic so that the control thread exits > gracefully if the affinity cannot be set successfully and removes the > call to pthread_cancel. > > Fixes: 6383d26 ("eal: set name when creating a control thread") Fixed sha1's while applying. We prefer sha1 on 12 chars, like described in https://doc.dpdk.org/guides/contributing/patches.html#commit-messages-body. > Cc: stable@dpdk.org > > Signed-off-by: Luc Pelletier Acked-by: Olivier Matz Reviewed-by: Honnappa Nagarahalli Series applied, thanks for the fixes. -- David Marchand